Merge lp:~rharding/launchpad/meta_1000282 into lp:launchpad

[Richard Harding]

Update JS so that the meta.js parser can properly parse the file.

= Summary =
The comment in the import queue js file caused it to not get loaded into the
list of modules in build/js/lp/meta.js. This means the combo loader didn't
know it existed and couldn't load it.

== Pre Implementation ==
N/A

== Implementation Notes ==
Adjust the comment out of the JS block so that the parser that generates the
meta.js can correctly parse the file.

Note that while working this out I hit an error with the addClass() for a non-existent submit button. I wrapped that so that it only applies the class if the button is found.

== Q/A ==
https://translations.launchpad.net/+imports/+index
should load without any JS errors.

[Curtis Hovey (sinzui)]

Thank you.

review: Approve (code)

[Curtis Hovey (sinzui)]

We agreed to remove the comment because there is nothing special about loading oops or event in a module.

=== modified file 'lib/lp/translations/javascript/importqueue.js'
--- lib/lp/translations/javascript/importqueue.js	2012-04-28 02:51:07 +0000
+++ lib/lp/translations/javascript/importqueue.js	2012-05-16 16:56:53 +0000
@@ -178,12 +178,11 @@
     Y.all('.status-select').each(function(content_box, index, list) {
         content_box.addClass('hidden');
         });
-    Y.one('#import-queue-submit').addClass('hidden');
+    var submit_button = Y.one('#import-queue-submit');
+    if (submit_button) {
+        submit_button.addClass('hidden');
+    }
 };
-
-}, "0.1", {
-    // "oop" and "event" are required to fix known bugs in YUI, which
-    // are apparently fixed in a later version.
-    "requires": ["oop", "event", "node", "widget", "plugin", "overlay",
-                 "lazr.choiceedit", "lp.client", "lp.client.plugins",
-                 "lp.app.errors"]});
+}, "0.1", { "requires": ["oop", "event", "node", "widget", "plugin",
+    "overlay", "lazr.choiceedit", "lp.client", "lp.client.plugins",
+    "lp.app.errors"]});