Merge lp:~zeitgeist/unity-lens-video/fix-1196878-port-to-libzeitgeist2 into lp:unity-lens-video

Status: Needs review
Proposed branch: lp:~zeitgeist/unity-lens-video/fix-1196878-port-to-libzeitgeist2
Merge into: lp:unity-lens-video
Diff against target: 176 lines (+24/-22)
7 files modified
configure.ac (+1/-1)
debian/control (+1/-1)
src/Makefile.am (+2/-2)
src/blacklist-tracker.vala (+2/-2)
src/remote-scope.vala (+9/-8)
src/scope.vala (+8/-7)
tests/unit/Makefile.am (+1/-1)
To merge this branch: bzr merge lp:~zeitgeist/unity-lens-video/fix-1196878-port-to-libzeitgeist2
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Needs Fixing
PS Jenkins bot continuous-integration Pending
Review via email: mp+172511@code.launchpad.net

Commit message

Ported to libzeitgeist2

Description of the change

Fixes LP #1196878 where the lens is ported to libzeitgeist2

(PS: Already signed contributor's agreement)

To post a comment you must log in.
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

+1

review: Approve
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Could you please update this MR? It seems that there's still a conflict in debian/control when merging with trunk.

review: Needs Fixing

Unmerged revisions

119. By Manish Sinha (मनीष सिन्हा)

Fixes LP #1196878 where the lens is ported to libzeitgeist2

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'configure.ac'
--- configure.ac 2013-05-16 11:33:59 +0000
+++ configure.ac 2013-07-02 09:35:32 +0000
@@ -75,7 +75,7 @@
75 gee-1.075 gee-1.0
76 libsoup-gnome-2.476 libsoup-gnome-2.4
77 json-glib-1.077 json-glib-1.0
78 zeitgeist-1.0 >= 0.3.878 zeitgeist-2.0 >= 0.9.12
79 unity >= 7.0.079 unity >= 7.0.0
80 unity-extras >= 6.91.1180 unity-extras >= 6.91.11
81 )81 )
8282
=== modified file 'debian/control'
--- debian/control 2013-06-20 16:13:54 +0000
+++ debian/control 2013-07-02 09:35:32 +0000
@@ -12,7 +12,7 @@
12 libjson-glib-dev,12 libjson-glib-dev,
13 libsoup-gnome2.4-dev,13 libsoup-gnome2.4-dev,
14 libunity-dev (>= 7.0.0),14 libunity-dev (>= 7.0.0),
15 libzeitgeist-dev (>= 0.3.8),15 libzeitgeist-2.0-dev (>= 0.9.12),
16 valac-0.18,16 valac-0.18,
17 xvfb,17 xvfb,
18Standards-Version: 3.9.418Standards-Version: 3.9.4
1919
=== modified file 'src/Makefile.am'
--- src/Makefile.am 2013-06-20 16:13:59 +0000
+++ src/Makefile.am 2013-07-02 09:35:32 +0000
@@ -43,7 +43,7 @@
43 --pkg gio-unix-2.0 \43 --pkg gio-unix-2.0 \
44 --pkg glib-2.0 \44 --pkg glib-2.0 \
45 --pkg gee-1.0 \45 --pkg gee-1.0 \
46 --pkg zeitgeist-1.0 \46 --pkg zeitgeist-2.0 \
47 --vapidir $(srcdir) \47 --vapidir $(srcdir) \
48 --vapidir $(top_srcdir)/vapi \48 --vapidir $(top_srcdir)/vapi \
49 --target-glib=2.26 \49 --target-glib=2.26 \
@@ -59,7 +59,7 @@
59 --pkg gio-unix-2.0 \59 --pkg gio-unix-2.0 \
60 --pkg glib-2.0 \60 --pkg glib-2.0 \
61 --pkg gee-1.0 \61 --pkg gee-1.0 \
62 --pkg zeitgeist-1.0 \62 --pkg zeitgeist-2.0 \
63 --pkg libsoup-gnome-2.4 \63 --pkg libsoup-gnome-2.4 \
64 --pkg libsoup-2.4 \64 --pkg libsoup-2.4 \
65 --pkg json-glib-1.0 \65 --pkg json-glib-1.0 \
6666
=== modified file 'src/blacklist-tracker.vala'
--- src/blacklist-tracker.vala 2012-11-19 11:00:54 +0000
+++ src/blacklist-tracker.vala 2013-07-02 09:35:32 +0000
@@ -101,8 +101,8 @@
101 {101 {
102 if (e.num_subjects () > 0)102 if (e.num_subjects () > 0)
103 {103 {
104 unowned Subject s = e.get_subject (0);104 Subject s = e.get_subject (0);
105 unowned string uri = s.get_uri ();105 unowned string uri = s.uri;
106 if (uri == null || uri == "") continue;106 if (uri == null || uri == "") continue;
107107
108 if (uri.has_suffix ("*"))108 if (uri.has_suffix ("*"))
109109
=== modified file 'src/remote-scope.vala'
--- src/remote-scope.vala 2013-06-20 16:13:59 +0000
+++ src/remote-scope.vala 2013-07-02 09:35:32 +0000
@@ -19,6 +19,7 @@
19 */19 */
2020
21using Config;21using Config;
22using Zeitgeist;
2223
23namespace Unity.VideoLens24namespace Unity.VideoLens
24{25{
@@ -497,22 +498,22 @@
497 private void zeitgeist_init () throws Error498 private void zeitgeist_init () throws Error
498 {499 {
499 zg_sources = new Zeitgeist.DataSourceRegistry ();500 zg_sources = new Zeitgeist.DataSourceRegistry ();
500 var templates = new PtrArray.sized(1);501 var templates = new GenericArray<Event>();
501 var ev = new Zeitgeist.Event.full (Zeitgeist.ZG_ACCESS_EVENT, Zeitgeist.ZG_USER_ACTIVITY, "lens://unity-lens-video");502 var ev = new Zeitgeist.Event.full (Zeitgeist.ZG.ACCESS_EVENT, Zeitgeist.ZG.USER_ACTIVITY, "lens://unity-lens-video");
502 templates.add ((ev as GLib.Object).ref());503 templates.add (ev);
503 var data_source = new Zeitgeist.DataSource.full ("98898", "Unity Video Lens", "", templates);504 var data_source = new Zeitgeist.DataSource.full ("98898", "Unity Video Lens", "", templates);
504 zg_sources.register_data_source (data_source, null);505 zg_sources.register_data_source (data_source, null);
505 }506 }
506507
507 private void zeitgeist_insert_event (string uri, string title, string icon)508 private void zeitgeist_insert_event (string uri, string title, string icon)
508 {509 {
509 var subject = new Zeitgeist.Subject.full (uri, Zeitgeist.NFO_VIDEO, Zeitgeist.NFO_REMOTE_DATA_OBJECT, "", uri, title, icon);510 var subject = new Zeitgeist.Subject.full (uri, Zeitgeist.NFO.VIDEO, Zeitgeist.NFO.REMOTE_DATA_OBJECT, "", uri, title, icon);
510 var event = new Zeitgeist.Event.full (Zeitgeist.ZG_ACCESS_EVENT, Zeitgeist.ZG_USER_ACTIVITY, "lens://unity-lens-video");511 var event = new Zeitgeist.Event.full (Zeitgeist.ZG.ACCESS_EVENT, Zeitgeist.ZG.USER_ACTIVITY, "lens://unity-lens-video");
511 event.add_subject (subject);512 event.add_subject (subject);
512513
513 var ev_array = new PtrArray.sized(1);514 var ev_array = new GenericArray<Event>();
514 ev_array.add ((event as GLib.Object).ref ());515 ev_array.add (event);
515 Zeitgeist.Log.get_default ().insert_events_from_ptrarray (ev_array, null);516 Zeitgeist.Log.get_default ().insert_events_no_reply (ev_array);
516 }517 }
517 }518 }
518}519}
519520
=== modified file 'src/scope.vala'
--- src/scope.vala 2013-06-20 16:13:59 +0000
+++ src/scope.vala 2013-07-02 09:35:32 +0000
@@ -19,6 +19,7 @@
19 */19 */
2020
21using Config;21using Config;
22using Zeitgeist;
2223
23namespace Unity.VideoLens24namespace Unity.VideoLens
24{25{
@@ -194,11 +195,11 @@
194195
195 var time_range = new Zeitgeist.TimeRange.to_now ();196 var time_range = new Zeitgeist.TimeRange.to_now ();
196 var event_template = new Zeitgeist.Event ();197 var event_template = new Zeitgeist.Event ();
197 var subject = new Zeitgeist.Subject.full (uri, Zeitgeist.NFO_VIDEO, "", "", "", "", "");198 var subject = new Zeitgeist.Subject.full (uri, Zeitgeist.NFO.VIDEO, "", "", "", "", "");
198 event_template.add_subject (subject);199 event_template.add_subject (subject);
199200
200 var templates = new PtrArray.sized (1);201 var templates = new GenericArray<Event>();
201 templates.add ((event_template as GLib.Object).ref());202 templates.add (event_template);
202 var results = yield Zeitgeist.Log.get_default ().find_events (time_range, templates, Zeitgeist.StorageState.ANY, MAX_ZG_EVENTS, Zeitgeist.ResultType.MOST_RECENT_SUBJECTS, cancellable);203 var results = yield Zeitgeist.Log.get_default ().find_events (time_range, templates, Zeitgeist.StorageState.ANY, MAX_ZG_EVENTS, Zeitgeist.ResultType.MOST_RECENT_SUBJECTS, cancellable);
203 process_zg_events (results, cancellable, search_status);204 process_zg_events (results, cancellable, search_status);
204 }205 }
@@ -210,7 +211,7 @@
210 if (Utils.is_video (path) && !Utils.is_hidden (path))211 if (Utils.is_video (path) && !Utils.is_hidden (path))
211 {212 {
212 var file = File.new_for_path (path);213 var file = File.new_for_path (path);
213 if (!is_blacklisted(file.get_uri ()))214 if (!is_blacklisted(file.get_uri()))
214 return true;215 return true;
215 }216 }
216 }217 }
@@ -230,7 +231,7 @@
230 if (cancellable.is_cancelled ())231 if (cancellable.is_cancelled ())
231 return;232 return;
232233
233 var event_uri = event.get_subject (0).get_uri ();234 var event_uri = event.get_subject (0).uri;
234 if (event_uri.has_prefix ("file://"))235 if (event_uri.has_prefix ("file://"))
235 {236 {
236 try237 try
@@ -266,10 +267,10 @@
266 // this one can be any unicode string:267 // this one can be any unicode string:
267 VideoFile video = VideoFile ()268 VideoFile video = VideoFile ()
268 {269 {
269 title = event.get_subject (0).get_text (),270 title = event.get_subject (0).text,
270 comment = "",271 comment = "",
271 uri = event_uri,272 uri = event_uri,
272 icon = event.get_subject (0).get_storage (),273 icon = event.get_subject (0).storage,
273 category = CAT_INDEX_ONLINE274 category = CAT_INDEX_ONLINE
274 };275 };
275 result_list.add (video);276 result_list.add (video);
276277
=== modified file 'tests/unit/Makefile.am'
--- tests/unit/Makefile.am 2013-06-20 18:12:31 +0000
+++ tests/unit/Makefile.am 2013-07-02 09:35:32 +0000
@@ -17,7 +17,7 @@
17 --pkg json-glib-1.0 \17 --pkg json-glib-1.0 \
18 --pkg glib-2.0 \18 --pkg glib-2.0 \
19 --pkg gee-1.0 \19 --pkg gee-1.0 \
20 --pkg zeitgeist-1.0 \20 --pkg zeitgeist-2.0 \
21 --pkg libsoup-gnome-2.4 \21 --pkg libsoup-gnome-2.4 \
22 --pkg libsoup-2.4 \22 --pkg libsoup-2.4 \
23 --vapidir $(srcdir) \23 --vapidir $(srcdir) \

Subscribers

People subscribed via source and target branches