Merge lp:~yann-papouin/ocb-addons/6.1-bug-1008513-dav-import-error into lp:ocb-addons/6.1

Proposed by Yann Papouin
Status: Merged
Merged at revision: 6847
Proposed branch: lp:~yann-papouin/ocb-addons/6.1-bug-1008513-dav-import-error
Merge into: lp:ocb-addons/6.1
Diff against target: 90 lines (+31/-14)
3 files modified
document_webdav/dav_fs.py (+11/-5)
document_webdav/webdav.py (+9/-4)
document_webdav/webdav_server.py (+11/-5)
To merge this branch: bzr merge lp:~yann-papouin/ocb-addons/6.1-bug-1008513-dav-import-error
Reviewer Review Type Date Requested Status
Stefan Rijnhart (Opener) Approve
Pedro Manuel Baeza code review Approve
Review via email: mp+219794@code.launchpad.net

Description of the change

Backport from 7.0 needed to run OpenERP 6.1 with DAV support on latest Linux distribution

To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

I think you may keep osv.except_osv in case both imports fail, or put an external dependency on manifest.

Regards.

review: Needs Fixing (code review)
Revision history for this message
Yann Papouin (yann-papouin) wrote :

You're right. Fixed!

Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Thanks for the changes!

Regards.

review: Approve (code review)
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Thanks, I was aware of the problem and the fix looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'document_webdav/dav_fs.py'
--- document_webdav/dav_fs.py 2011-12-19 16:54:40 +0000
+++ document_webdav/dav_fs.py 2014-05-16 09:22:46 +0000
@@ -27,13 +27,19 @@
2727
28import netsvc28import netsvc
29import urlparse29import urlparse
30
31from DAV.constants import COLLECTION #, OBJECT
32from DAV.errors import DAV_Error, DAV_Forbidden, DAV_NotFound
33from DAV.iface import dav_interface
34import urllib30import urllib
3531
36from DAV.davcmd import copyone, copytree, moveone, movetree, delone, deltree32try:
33 from pywebdav.lib.constants import COLLECTION # , OBJECT
34 from pywebdav.lib.errors import DAV_Error, DAV_Forbidden, DAV_NotFound
35 from pywebdav.lib.iface import dav_interface
36 from pywebdav.lib.davcmd import copyone, copytree, moveone, movetree, delone, deltree
37except ImportError:
38 from DAV.constants import COLLECTION #, OBJECT
39 from DAV.errors import DAV_Error, DAV_Forbidden, DAV_NotFound
40 from DAV.iface import dav_interface
41 from DAV.davcmd import copyone, copytree, moveone, movetree, delone, deltree
42
37from cache import memoize43from cache import memoize
38from tools import misc44from tools import misc
3945
4046
=== modified file 'document_webdav/webdav.py'
--- document_webdav/webdav.py 2011-12-19 16:54:40 +0000
+++ document_webdav/webdav.py 2014-05-16 09:22:46 +0000
@@ -30,11 +30,16 @@
30from tools.translate import _30from tools.translate import _
3131
32try:32try:
33 from DAV import utils33 from pywebdav.lib import utils
34 from DAV.propfind import PROPFIND34 from pywebdav.lib.propfind import PROPFIND
35 from DAV.report import REPORT35 from pywebdav.lib.report import REPORT
36except ImportError:36except ImportError:
37 raise osv.except_osv(_('PyWebDAV Import Error!'), _('Please install PyWebDAV from http://code.google.com/p/pywebdav/downloads/detail?name=PyWebDAV-0.9.4.tar.gz&can=2&q=/'))37 try:
38 from DAV import utils
39 from DAV.propfind import PROPFIND
40 from DAV.report import REPORT
41 except ImportError:
42 raise osv.except_osv(_('PyWebDAV Import Error!'), _('Please install PyWebDAV from http://code.google.com/p/pywebdav/downloads/detail?name=PyWebDAV-0.9.4.tar.gz&can=2&q=/'))
3843
39import tools44import tools
4045
4146
=== modified file 'document_webdav/webdav_server.py'
--- document_webdav/webdav_server.py 2012-02-09 09:06:22 +0000
+++ document_webdav/webdav_server.py 2014-05-16 09:22:46 +0000
@@ -38,7 +38,6 @@
38import netsvc38import netsvc
39from dav_fs import openerp_dav_handler39from dav_fs import openerp_dav_handler
40from tools.config import config40from tools.config import config
41from DAV.WebDAVServer import DAVRequestHandler
42from service import http_server41from service import http_server
43from service.websrv_lib import FixSendError, HttpOptions42from service.websrv_lib import FixSendError, HttpOptions
44from BaseHTTPServer import BaseHTTPRequestHandler43from BaseHTTPServer import BaseHTTPRequestHandler
@@ -48,13 +47,20 @@
48import time47import time
49from string import atoi48from string import atoi
50import addons49import addons
51from DAV.utils import IfParser, TagList
52from DAV.errors import DAV_Error, DAV_Forbidden, DAV_NotFound
53from DAV.propfind import PROPFIND
54# from DAV.constants import DAV_VERSION_1, DAV_VERSION_2
55from xml.dom import minidom50from xml.dom import minidom
56from redirect import RedirectHTTPHandler51from redirect import RedirectHTTPHandler
5752
53try:
54 from pywebdav.lib.WebDAVServer import DAVRequestHandler
55 from pywebdav.lib.utils import IfParser, TagList
56 from pywebdav.lib.errors import DAV_Error, DAV_Forbidden, DAV_NotFound
57 from pywebdav.lib.propfind import PROPFIND
58except ImportError:
59 from DAV.WebDAVServer import DAVRequestHandler
60 from DAV.utils import IfParser, TagList
61 from DAV.errors import DAV_Error, DAV_Forbidden, DAV_NotFound
62 from DAV.propfind import PROPFIND
63
58khtml_re = re.compile(r' KHTML/([0-9\.]+) ')64khtml_re = re.compile(r' KHTML/([0-9\.]+) ')
5965
60def OpenDAVConfig(**kw):66def OpenDAVConfig(**kw):

Subscribers

People subscribed via source and target branches