Merge lp:~yann-papouin/account-financial-tools/6.1-bug-1255543-chart-update-records-wrong-dict into lp:~account-core-editors/account-financial-tools/6.1

Proposed by Yann Papouin
Status: Merged
Merged at revision: 106
Proposed branch: lp:~yann-papouin/account-financial-tools/6.1-bug-1255543-chart-update-records-wrong-dict
Merge into: lp:~account-core-editors/account-financial-tools/6.1
Diff against target: 11 lines (+1/-1)
1 file modified
account_chart_update/account.py (+1/-1)
To merge this branch: bzr merge lp:~yann-papouin/account-financial-tools/6.1-bug-1255543-chart-update-records-wrong-dict
Reviewer Review Type Date Requested Status
Joaquin Gutierrez (community) code review and test Approve
Pedro Manuel Baeza code review, no test Approve
Review via email: mp+196911@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Thanks for catching up!

Regards.

review: Approve (code review, no test)
Revision history for this message
Joaquin Gutierrez (joaquing-pedrosa) wrote :

Hello Yann:

Good job.

Thank

review: Approve (code review and test)
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

I proceed with the merge, having two functional reviews and this fix is needed for some tasks now on l10n_fr, as I have readed.

Regards.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'account_chart_update/account.py'
--- account_chart_update/account.py 2012-12-07 09:52:37 +0000
+++ account_chart_update/account.py 2013-11-27 14:37:40 +0000
@@ -1193,7 +1193,7 @@
1193 taxes_res = self._update_taxes(1193 taxes_res = self._update_taxes(
1194 cr, uid, wizard, log, tax_codes_res['mapping'], context=context)1194 cr, uid, wizard, log, tax_codes_res['mapping'], context=context)
1195 accounts_res = self._update_accounts(1195 accounts_res = self._update_accounts(
1196 cr, uid, wizard, log, taxes_res['pending'], context=context)1196 cr, uid, wizard, log, taxes_res['mapping'], context=context)
1197 self._update_taxes_pending_for_accounts(cr, uid, wizard, log, taxes_res['pending'], accounts_res['mapping'], context=context)1197 self._update_taxes_pending_for_accounts(cr, uid, wizard, log, taxes_res['pending'], accounts_res['mapping'], context=context)
1198 fps_res = self._update_fiscal_positions(cr, uid, wizard, log, taxes_res['mapping'], accounts_res['mapping'], context=context)1198 fps_res = self._update_fiscal_positions(cr, uid, wizard, log, taxes_res['mapping'], accounts_res['mapping'], context=context)
11991199

Subscribers

People subscribed via source and target branches