Merge lp:~xnox/upstart/buildd-cgmanager into lp:upstart/async

Proposed by Dimitri John Ledkov
Status: Merged
Merged at revision: 1664
Proposed branch: lp:~xnox/upstart/buildd-cgmanager
Merge into: lp:upstart/async
Diff against target: 39 lines (+17/-11)
1 file modified
test/tests/test_util_check_env.c (+17/-11)
To merge this branch: bzr merge lp:~xnox/upstart/buildd-cgmanager
Reviewer Review Type Date Requested Status
James Hunt Approve
Review via email: mp+222165@code.launchpad.net
To post a comment you must log in.
Revision history for this message
James Hunt (jamesodhunt) wrote :

Thanks - applied with minor tweaks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'test/tests/test_util_check_env.c'
--- test/tests/test_util_check_env.c 2014-05-12 13:21:06 +0000
+++ test/tests/test_util_check_env.c 2014-06-05 11:09:52 +0000
@@ -165,18 +165,24 @@
165165
166166
167#ifdef ENABLE_CGROUPS167#ifdef ENABLE_CGROUPS
168 TEST_FEATURE ("checking for cgmanager");168 struct stat buffer;
169 ret = connect_to_cgmanager();169 int status;
170 switch(ret) {170 if (stat("/sys/fs/cgroup/cgmanager/sock", &buffer) == 0) {
171 case -2: TEST_FAILED("Found no cgroup manager"); break;171 TEST_FEATURE ("checking for cgmanager");
172 case -1: TEST_FAILED("Error connecting to cgmanager"); break;172 ret = connect_to_cgmanager();
173 case 0: print_my_cgroup(); break;173 switch(ret) {
174 default: TEST_FAILED("Unknown error from connect_to_cgmanager: %d", ret);174 case -2: TEST_FAILED("Found no cgroup manager"); break;
175 case -1: TEST_FAILED("Error connecting to cgmanager"); break;
176 case 0: print_my_cgroup(); break;
177 default: TEST_FAILED("Unknown error from connect_to_cgmanager: %d", ret);
178 }
179
180 TEST_FEATURE("cgroup sandbox");
181 TEST_EQ(check_cgroup_sandbox(), 0);
182 disconnect_cgmanager();
183 } else {
184 nih_warn ("Skipping CGManager tests, CGManager socket not found");
175 }185 }
176
177 TEST_FEATURE("cgroup sandbox");
178 TEST_EQ(check_cgroup_sandbox(), 0);
179 disconnect_cgmanager();
180#endif /* ENABLE_CGROUPS */186#endif /* ENABLE_CGROUPS */
181187
182}188}

Subscribers

People subscribed via source and target branches