Merge lp:~xnox/oneconf/scripts-and-shebangs into lp:oneconf

Proposed by Dimitri John Ledkov
Status: Work in progress
Proposed branch: lp:~xnox/oneconf/scripts-and-shebangs
Merge into: lp:oneconf
Diff against target: 61 lines (+14/-9)
3 files modified
debian/changelog (+8/-0)
debian/rules (+2/-2)
setup.py (+4/-7)
To merge this branch: bzr merge lp:~xnox/oneconf/scripts-and-shebangs
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Needs Fixing
dobey Pending
Review via email: mp+144567@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Hey Dmitrijs!

It seems that Barry didn't get 0.3.3 merged into trunk, do you mind bundling that or coordinate with him?http://launchpadlibrarian.net/129243831/oneconf_0.3.2_0.3.3.diff.gz

Thanks :)

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

setting as WIP meanwhile :)

review: Needs Fixing

Unmerged revisions

270. By Dimitri John Ledkov

* debian/rules: skip installing python2 scripts.
* debian/rules: build with python3 first to get correct shebang.
* setup.py: revert 0.3.2 changes.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2013-01-22 19:02:50 +0000
+++ debian/changelog 2013-01-23 19:37:22 +0000
@@ -1,3 +1,11 @@
1oneconf (0.3.3) UNRELEASED; urgency=low
2
3 * debian/rules: skip installing python2 scripts.
4 * debian/rules: build with python3 first to get correct shebang.
5 * setup.py: revert 0.3.2 changes.
6
7 -- Dmitrijs Ledkovs <dmitrij.ledkov@ubuntu.com> Wed, 23 Jan 2013 19:28:42 +0000
8
1oneconf (0.3.2) raring; urgency=low9oneconf (0.3.2) raring; urgency=low
210
3 * setup.py: Only install the command line scripts for Python 3.11 * setup.py: Only install the command line scripts for Python 3.
412
=== modified file 'debian/rules'
--- debian/rules 2013-01-16 03:04:46 +0000
+++ debian/rules 2013-01-23 19:37:22 +0000
@@ -7,7 +7,7 @@
7export http_proxy = http://127.0.9.1:97export http_proxy = http://127.0.9.1:9
88
9PYTHON2=$(shell pyversions -vr)9PYTHON2=$(shell pyversions -vr)
10PYTHON3=$(shell py3versions -vr)10PYTHON3=3 $(shell py3versions -vr)
1111
12%:12%:
13 dh $@ --with python2,python313 dh $@ --with python2,python3
@@ -36,7 +36,7 @@
36 python$* setup.py install --root=$(CURDIR)/debian/tmp --install-layout=deb36 python$* setup.py install --root=$(CURDIR)/debian/tmp --install-layout=deb
3737
38override_dh_auto_install: $(PYTHON3:%=install-python%)38override_dh_auto_install: $(PYTHON3:%=install-python%)
39 dh_auto_install39 dh_auto_install -- --install-scripts skip && rm -rf debian/tmp/skip
40 # Move the scripts to $(SHARE) and relink some again later. The40 # Move the scripts to $(SHARE) and relink some again later. The
41 # scripts will be included in the "oneconf" binary package41 # scripts will be included in the "oneconf" binary package
42 mkdir -p debian/oneconf/$(share)42 mkdir -p debian/oneconf/$(share)
4343
=== modified file 'setup.py'
--- setup.py 2013-01-22 19:02:50 +0000
+++ setup.py 2013-01-23 19:37:22 +0000
@@ -42,15 +42,12 @@
42Exec=%s42Exec=%s
43""" % oneconf_service_path)43""" % oneconf_service_path)
4444
45# The scripts only work with Python 3.
46if sys.version_info[0] == 3:
47 scripts = ['oneconf-query', 'oneconf-service', 'misc/oneconf-update']
48else:
49 scripts = []
50
51# real setup45# real setup
52setup(name="oneconf", version=VERSION,46setup(name="oneconf", version=VERSION,
53 scripts=scripts,47 scripts=["oneconf-query",
48 "oneconf-service",
49 "misc/oneconf-update",
50 ],
54 packages = ['oneconf',51 packages = ['oneconf',
55 'oneconf.distributor',52 'oneconf.distributor',
56 'oneconf.networksync',53 'oneconf.networksync',

Subscribers

People subscribed via source and target branches