Merge ~xnox/grub:fix-postinst-empty-devices into ~ubuntu-core-dev/grub/+git/ubuntu:ubuntu

[Dimitri John Ledkov]

postinst.in, grub-multi-install: fix logic of skipping installing onto any device, if one chose to not install bootloader on any device. LP: #1896608

[Michael Vogt (mvo)]

This looks correct to me, I will try it later today on the machine that failed originally.

review: Approve

[Michael Vogt (mvo)]

Still approving (but added some ideas) - I tested the fix on the affected machine and it works as expected.

diff --git a/debian/changelog b/debian/changelog
index a702a27..3d6e540 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,11 @@
+grub2 (2.04-1ubuntu35) UNRELEASED; urgency=medium
+
+  * postinst.in, grub-multi-install: fix logic of skipping installing onto
+    any device, if one chose to not install bootloader on any device. LP:
+    #1896608
+
+ -- Dimitri John Ledkov <[e-mail]>  Mon, 28 Sep 2020 14:05:26 +0100
+
 grub2 (2.04-1ubuntu34) groovy; urgency=medium
 
   * configure.ac: one more dejavu font search path
diff --git a/debian/grub-multi-install b/debian/grub-multi-install
index 9bd4089..bedc700 100755
--- a/debian/grub-multi-install
+++ b/debian/grub-multi-install
@@ -402,7 +402,14 @@ while :; do
         db_fset grub-efi/install_devices_empty seen false
       fi
     else
-      exit 1 # noninteractive
+      # if question was seen we are done
+      # Otherwise, abort
+      db_fget grub-efi/install_devices_empty seen
+      if [ "$RET" = true ]; then
+        break
+      else
+        exit 1
+      fi
     fi
   else
     break
diff --git a/debian/postinst.in b/debian/postinst.in
index e6dfe36..cedc137 100644
--- a/debian/postinst.in
+++ b/debian/postinst.in
@@ -685,7 +685,14 @@ case "$1" in
                   db_fset grub-pc/install_devices_empty seen false
                 fi
               else
-                exit 1 # noninteractive
+                # if question was seen we are done
+                # Otherwise, abort
+                db_fget grub-pc/install_devices_empty seen
+                if [ "$RET" = true ]; then
+                  break
+                else
+                  exit 1
+                fi
               fi
             else
               break