Merge lp:~vthompson/ubuntu-weather-app/reboot-remove-cpp-flag into lp:ubuntu-weather-app

Proposed by Victor Thompson
Status: Merged
Approved by: Andrew Hayzen
Approved revision: 87
Merged at revision: 88
Proposed branch: lp:~vthompson/ubuntu-weather-app/reboot-remove-cpp-flag
Merge into: lp:ubuntu-weather-app
Diff against target: 37 lines (+9/-1)
2 files modified
CMakeLists.txt (+7/-1)
debian/changelog (+2/-0)
To merge this branch: bzr merge lp:~vthompson/ubuntu-weather-app/reboot-remove-cpp-flag
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Andrew Hayzen Approve
Review via email: mp+267437@code.launchpad.net

Commit message

* Remove C++ flag from CMakeLists.txt
* Show README files in QtCreator

Description of the change

* Remove C++ flag from CMakeLists.txt
* Show README files in QtCreator

Please double check that the app still builds OK via the command line and with QtCreator.

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

LGTM tested via click-buddy and QtC deploying to device.

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
87. By Victor Thompson

Merge of reboot and resolve conflict

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2015-08-04 03:01:45 +0000
+++ CMakeLists.txt 2015-08-09 16:08:17 +0000
@@ -11,7 +11,6 @@
11endif()11endif()
1212
13set (UBUNTU_MANIFEST_PATH "manifest.json.in" CACHE INTERNAL "Relative path to the manifest file")13set (UBUNTU_MANIFEST_PATH "manifest.json.in" CACHE INTERNAL "Relative path to the manifest file")
14set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11 -fno-permissive -pedantic -Wall -Wextra")
1514
16find_package(Qt5Core REQUIRED)15find_package(Qt5Core REQUIRED)
17find_package(Qt5Qml REQUIRED)16find_package(Qt5Qml REQUIRED)
@@ -97,5 +96,12 @@
97add_subdirectory(po)96add_subdirectory(po)
98add_subdirectory(tests)97add_subdirectory(tests)
9998
99# make the qml files visible on qtcreator
100file(GLOB QML_JS_FILES
101 RELATIVE ${CMAKE_CURRENT_SOURCE_DIR}
102 *.qml *.js README* *.txt)
103
104add_custom_target(com_ubuntu_weather_QMLFiles DEPENDS ubuntu-weather-app.qml SOURCES ${QML_JS_FILES})
105
100# TODO: Add custom target for autopilot and run.106# TODO: Add custom target for autopilot and run.
101107
102108
=== modified file 'debian/changelog'
--- debian/changelog 2015-08-07 23:50:08 +0000
+++ debian/changelog 2015-08-09 16:08:17 +0000
@@ -12,6 +12,8 @@
12 * Rename EmptyStateComponent to HomePageEmptyStateComponent12 * Rename EmptyStateComponent to HomePageEmptyStateComponent
13 * Add a LocationsPageEmptyStateComponent13 * Add a LocationsPageEmptyStateComponent
14 * Create autopilot test which removes a single location (LP: #1452499)14 * Create autopilot test which removes a single location (LP: #1452499)
15 * Remove C++ flag from CMakeLists.txt
16 * Show README files in QtCreator
1517
16 [ Andrew Hayzen ]18 [ Andrew Hayzen ]
17 * Add mocked locations for autopilot and add a test using the data19 * Add mocked locations for autopilot and add a test using the data

Subscribers

People subscribed via source and target branches

to all changes: