Merge lp:~vthompson/ubuntu-weather-app/reboot-locationspage-empty-state into lp:ubuntu-weather-app

Proposed by Victor Thompson
Status: Merged
Approved by: Victor Thompson
Approved revision: 80
Merged at revision: 83
Proposed branch: lp:~vthompson/ubuntu-weather-app/reboot-locationspage-empty-state
Merge into: lp:ubuntu-weather-app
Diff against target: 135 lines (+61/-5)
5 files modified
app/components/LocationsPageEmptyStateComponent.qml (+40/-0)
app/ui/HomePage.qml (+1/-1)
app/ui/LocationsPage.qml (+10/-0)
debian/changelog (+2/-0)
po/com.ubuntu.weather.pot (+8/-4)
To merge this branch: bzr merge lp:~vthompson/ubuntu-weather-app/reboot-locationspage-empty-state
Reviewer Review Type Date Requested Status
Victor Thompson Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Andrew Hayzen Approve
Review via email: mp+266350@code.launchpad.net

Commit message

* Rename EmptyStateComponent to HomePageEmptyStateComponent
* Add a LocationsPageEmptyStateComponent

Description of the change

* Rename EmptyStateComponent to HomePageEmptyStateComponent
* Add a LocationsPageEmptyStateComponent

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Hah I was going to do this as well, great minds think alike :-)

One inline comment

review: Needs Fixing
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

LGTM, thanks for the extra fixes :-)

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
79. By Victor Thompson

Regenerate pot file

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
80. By Victor Thompson

Merge of trunk and resolve conflicts

Revision history for this message
Victor Thompson (vthompson) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== renamed file 'app/components/EmptyStateComponent.qml' => 'app/components/HomePageEmptyStateComponent.qml'
=== added file 'app/components/LocationsPageEmptyStateComponent.qml'
--- app/components/LocationsPageEmptyStateComponent.qml 1970-01-01 00:00:00 +0000
+++ app/components/LocationsPageEmptyStateComponent.qml 2015-08-07 01:23:00 +0000
@@ -0,0 +1,40 @@
1/*
2 * Copyright (C) 2015 Canonical Ltd
3 *
4 * This file is part of Ubuntu Weather App
5 *
6 * Ubuntu Weather App is free software: you can redistribute it and/or modify
7 * it under the terms of the GNU General Public License version 3 as
8 * published by the Free Software Foundation.
9 *
10 * Ubuntu Weather App is distributed in the hope that it will be useful,
11 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 * GNU General Public License for more details.
14 *
15 * You should have received a copy of the GNU General Public License
16 * along with this program. If not, see <http://www.gnu.org/licenses/>.
17 */
18
19import QtQuick 2.4
20import Ubuntu.Components 1.2
21import "../components"
22
23
24Item {
25 anchors {
26 fill: parent
27 margins: units.gu(2)
28 }
29
30 Label {
31 id: emptyStateLabel
32 anchors {
33 centerIn: parent
34 }
35 horizontalAlignment: Text.AlignHCenter
36 text: i18n.tr("No locations found. Tap the plus icon to search for one.")
37 width: parent.width - units.gu(4)
38 wrapMode: Text.WordWrap
39 }
40}
041
=== modified file 'app/ui/HomePage.qml'
--- app/ui/HomePage.qml 2015-07-29 21:34:56 +0000
+++ app/ui/HomePage.qml 2015-08-07 01:23:00 +0000
@@ -192,7 +192,7 @@
192 fill: parent192 fill: parent
193 }193 }
194 asynchronous: true194 asynchronous: true
195 source: "../components/EmptyStateComponent.qml"195 source: "../components/HomePageEmptyStateComponent.qml"
196 visible: status === Loader.Ready && active196 visible: status === Loader.Ready && active
197 }197 }
198}198}
199199
=== modified file 'app/ui/LocationsPage.qml'
--- app/ui/LocationsPage.qml 2015-08-02 13:43:34 +0000
+++ app/ui/LocationsPage.qml 2015-08-07 01:23:00 +0000
@@ -250,6 +250,16 @@
250 }250 }
251 }251 }
252252
253 Loader {
254 active: locationsList === null || locationsList.length === 0
255 anchors {
256 fill: parent
257 }
258 asynchronous: true
259 source: "../components/LocationsPageEmptyStateComponent.qml"
260 visible: status === Loader.Ready && active
261 }
262
253 function populateLocationsModel() {263 function populateLocationsModel() {
254 currentLocationModel.clear()264 currentLocationModel.clear()
255 locationsModel.clear()265 locationsModel.clear()
256266
=== modified file 'debian/changelog'
--- debian/changelog 2015-08-07 00:12:11 +0000
+++ debian/changelog 2015-08-07 01:23:00 +0000
@@ -9,6 +9,8 @@
9 * Default to OWM if the key file for TWC is blank.9 * Default to OWM if the key file for TWC is blank.
10 * Add sunrise and sunset icons from the spec10 * Add sunrise and sunset icons from the spec
11 * Fix the CMakeLists.txt to include the app icon11 * Fix the CMakeLists.txt to include the app icon
12 * Rename EmptyStateComponent to HomePageEmptyStateComponent
13 * Add a LocationsPageEmptyStateComponent
1214
13 [ Andrew Hayzen ]15 [ Andrew Hayzen ]
14 * Add mocked locations for autopilot and add a test using the data16 * Add mocked locations for autopilot and add a test using the data
1517
=== modified file 'po/com.ubuntu.weather.pot'
--- po/com.ubuntu.weather.pot 2015-08-06 00:10:53 +0000
+++ po/com.ubuntu.weather.pot 2015-08-07 01:23:00 +0000
@@ -8,7 +8,7 @@
8msgstr ""8msgstr ""
9"Project-Id-Version: ubuntu-weather-app\n"9"Project-Id-Version: ubuntu-weather-app\n"
10"Report-Msgid-Bugs-To: \n"10"Report-Msgid-Bugs-To: \n"
11"POT-Creation-Date: 2015-08-06 01:02+0100\n"11"POT-Creation-Date: 2015-08-06 19:16-0500\n"
12"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"12"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
13"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"13"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
14"Language-Team: LANGUAGE <LL@li.org>\n"14"Language-Team: LANGUAGE <LL@li.org>\n"
@@ -46,15 +46,15 @@
46msgid "Sunset"46msgid "Sunset"
47msgstr ""47msgstr ""
4848
49#: ../app/components/EmptyStateComponent.qml:5149#: ../app/components/HomePageEmptyStateComponent.qml:51
50msgid "Searching for current location..."50msgid "Searching for current location..."
51msgstr ""51msgstr ""
5252
53#: ../app/components/EmptyStateComponent.qml:5253#: ../app/components/HomePageEmptyStateComponent.qml:52
54msgid "Cannot determine your location"54msgid "Cannot determine your location"
55msgstr ""55msgstr ""
5656
57#: ../app/components/EmptyStateComponent.qml:6257#: ../app/components/HomePageEmptyStateComponent.qml:62
58msgid "Manually add a location by swiping up from the bottom of the display"58msgid "Manually add a location by swiping up from the bottom of the display"
59msgstr ""59msgstr ""
6060
@@ -66,6 +66,10 @@
66msgid "Remove"66msgid "Remove"
67msgstr ""67msgstr ""
6868
69#: ../app/components/LocationsPageEmptyStateComponent.qml:36
70msgid "No locations found. Tap the plus icon to search for one."
71msgstr ""
72
69#: ../app/components/MultiSelectHeadState.qml:2773#: ../app/components/MultiSelectHeadState.qml:27
70msgid "Select All"74msgid "Select All"
71msgstr ""75msgstr ""

Subscribers

People subscribed via source and target branches

to all changes: