Merge lp:~vthompson/ubuntu-weather-app/reboot-fix-duplicate-location-popup into lp:ubuntu-weather-app

Proposed by Victor Thompson
Status: Merged
Approved by: Andrew Hayzen
Approved revision: 58
Merged at revision: 58
Proposed branch: lp:~vthompson/ubuntu-weather-app/reboot-fix-duplicate-location-popup
Merge into: lp:ubuntu-weather-app
Diff against target: 12 lines (+1/-1)
1 file modified
app/ui/AddLocationPage.qml (+1/-1)
To merge this branch: bzr merge lp:~vthompson/ubuntu-weather-app/reboot-fix-duplicate-location-popup
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Andrew Hayzen Approve
Review via email: mp+263207@code.launchpad.net

Commit message

Fix broken popup component

Description of the change

Fix broken popup component. Without this popup, the user gets no feedback as to whether the location was added.

To post a comment you must log in.
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

LGTM :-)

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'app/ui/AddLocationPage.qml'
--- app/ui/AddLocationPage.qml 2015-06-21 20:14:39 +0000
+++ app/ui/AddLocationPage.qml 2015-06-28 23:38:34 +0000
@@ -234,7 +234,7 @@
234 if (storage.addLocation(citiesModel.get(index))) {234 if (storage.addLocation(citiesModel.get(index))) {
235 mainPageStack.pop()235 mainPageStack.pop()
236 } else {236 } else {
237 PopupUtils.open(locationExistsComponent, addPage)237 PopupUtils.open(locationExistsComponent, addLocationPage)
238 }238 }
239 }239 }
240 }240 }

Subscribers

People subscribed via source and target branches

to all changes: