Merge lp:~vthompson/ubuntu-weather-app/fix-1521701 into lp:ubuntu-weather-app

Proposed by Victor Thompson
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„
Approved revision: 189
Merged at revision: 201
Proposed branch: lp:~vthompson/ubuntu-weather-app/fix-1521701
Merge into: lp:ubuntu-weather-app
Diff against target: 87 lines (+11/-7)
5 files modified
app/components/DayDelegateExtraInfo.qml (+3/-3)
app/components/ForecastDetailsDelegate.qml (+2/-1)
app/ui/LocationPane.qml (+1/-1)
debian/changelog (+3/-0)
po/com.ubuntu.weather.pot (+2/-2)
To merge this branch: bzr merge lp:~vthompson/ubuntu-weather-app/fix-1521701
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Approve
Bartosz Kosiorek (community) Approve
Review via email: mp+280379@code.launchpad.net

Commit message

* Change translatable string from "rain" to "precipitation"

Description of the change

* Change translatable string from "rain" to "precipitation"

This change still needs Design approval.

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Bartosz Kosiorek (gang65) wrote :

It looks perfectly fine for me.

review: Approve
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
https://core-apps-jenkins.ubuntu.com/job/weather-app-autolanding/10/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/1382/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Victor Thompson (vthompson) wrote :

I'll resolve the merge conflicts--but don't we want to wait for design approval? I'm not sure they approve yet.

189. By Victor Thompson

Merge of trunk and resolve conflict.

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'app/components/DayDelegateExtraInfo.qml'
--- app/components/DayDelegateExtraInfo.qml 2015-11-02 21:28:34 +0000
+++ app/components/DayDelegateExtraInfo.qml 2015-12-23 00:45:15 +0000
@@ -48,10 +48,10 @@
48 }48 }
4949
50 ForecastDetailsDelegate {50 ForecastDetailsDelegate {
51 id: chanceOfRainForecast51 id: chanceOfPrecipForecast
52 forecast: i18n.tr("Chance of rain")52 forecast: i18n.tr("Chance of precipitation")
53 imageSource: "../graphics/extended-information_chance-of-rain.svg"53 imageSource: "../graphics/extended-information_chance-of-rain.svg"
54 value: modelData.chanceOfRain54 value: modelData.chanceOfPrecip
55 }55 }
5656
57 ForecastDetailsDelegate {57 ForecastDetailsDelegate {
5858
=== modified file 'app/components/ForecastDetailsDelegate.qml'
--- app/components/ForecastDetailsDelegate.qml 2015-11-02 21:28:34 +0000
+++ app/components/ForecastDetailsDelegate.qml 2015-12-23 00:45:15 +0000
@@ -20,7 +20,7 @@
20import Ubuntu.Components 1.320import Ubuntu.Components 1.3
2121
22Row {22Row {
23 height: icon.height23 height: forecastLabel.height
24 spacing: units.gu(2)24 spacing: units.gu(2)
25 visible: value !== ""25 visible: value !== ""
2626
@@ -39,6 +39,7 @@
39 Label {39 Label {
40 id: forecastLabel40 id: forecastLabel
41 elide: Text.ElideRight41 elide: Text.ElideRight
42 wrapMode: Text.WordWrap
42 width: units.gu(16)43 width: units.gu(16)
43 }44 }
44 45
4546
=== modified file 'app/ui/LocationPane.qml'
--- app/ui/LocationPane.qml 2015-11-02 21:28:34 +0000
+++ app/ui/LocationPane.qml 2015-12-23 00:45:15 +0000
@@ -153,7 +153,7 @@
153 high: (data[tempUnits].tempMax !== undefined) ? Math.round(data[tempUnits].tempMax).toString() + settings.tempScale : "",153 high: (data[tempUnits].tempMax !== undefined) ? Math.round(data[tempUnits].tempMax).toString() + settings.tempScale : "",
154 image: (data.icon !== undefined && iconMap[data.icon] !== undefined) ? iconMap[data.icon] : "",154 image: (data.icon !== undefined && iconMap[data.icon] !== undefined) ? iconMap[data.icon] : "",
155 condition: emptyIfUndefined(data.condition),155 condition: emptyIfUndefined(data.condition),
156 chanceOfRain: emptyIfUndefined(data.propPrecip, "%"),156 chanceOfPrecip: emptyIfUndefined(data.propPrecip, "%"),
157 humidity: emptyIfUndefined(data.humidity, "%"),157 humidity: emptyIfUndefined(data.humidity, "%"),
158 sunrise: data.sunrise || sunrise.toLocaleTimeString(Qt.locale().name, options),158 sunrise: data.sunrise || sunrise.toLocaleTimeString(Qt.locale().name, options),
159 sunset: data.sunset || sunset.toLocaleTimeString(Qt.locale().name, options),159 sunset: data.sunset || sunset.toLocaleTimeString(Qt.locale().name, options),
160160
=== modified file 'debian/changelog'
--- debian/changelog 2015-12-17 02:29:07 +0000
+++ debian/changelog 2015-12-23 00:45:15 +0000
@@ -6,6 +6,9 @@
6 [ Girish Rawat ]6 [ Girish Rawat ]
7 * Added new READMEs7 * Added new READMEs
88
9 [ Victor Thompson ]
10 * Change translatable string from "rain" to "precipitation" (LP:1521701)
11
9 -- Andrew Hayzen <ahayzen@gmail.com> Thu, 03 Dec 2015 15:20:49 +000012 -- Andrew Hayzen <ahayzen@gmail.com> Thu, 03 Dec 2015 15:20:49 +0000
1013
11ubuntu-weather-app (3.1ubuntu1) vivid; urgency=medium14ubuntu-weather-app (3.1ubuntu1) vivid; urgency=medium
1215
=== modified file 'po/com.ubuntu.weather.pot'
--- po/com.ubuntu.weather.pot 2015-11-26 02:05:13 +0000
+++ po/com.ubuntu.weather.pot 2015-12-23 00:45:15 +0000
@@ -8,7 +8,7 @@
8msgstr ""8msgstr ""
9"Project-Id-Version: ubuntu-weather-app\n"9"Project-Id-Version: ubuntu-weather-app\n"
10"Report-Msgid-Bugs-To: \n"10"Report-Msgid-Bugs-To: \n"
11"POT-Creation-Date: 2015-11-26 02:04+0000\n"11"POT-Creation-Date: 2015-12-11 21:39-0600\n"
12"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"12"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
13"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"13"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
14"Language-Team: LANGUAGE <LL@li.org>\n"14"Language-Team: LANGUAGE <LL@li.org>\n"
@@ -19,7 +19,7 @@
19"Plural-Forms: nplurals=INTEGER; plural=EXPRESSION;\n"19"Plural-Forms: nplurals=INTEGER; plural=EXPRESSION;\n"
2020
21#: ../app/components/DayDelegateExtraInfo.qml:5221#: ../app/components/DayDelegateExtraInfo.qml:52
22msgid "Chance of rain"22msgid "Chance of precipitation"
23msgstr ""23msgstr ""
2424
25#: ../app/components/DayDelegateExtraInfo.qml:5925#: ../app/components/DayDelegateExtraInfo.qml:59

Subscribers

People subscribed via source and target branches

to all changes: