Ubuntu Calendar App

Merge lp:~vthompson/ubuntu-calendar-app/fixes-1247192 into lp:ubuntu-calendar-app

  1. fixes-1247192
  2. Merge into trunk
Proposed by Victor Thompson
Status: Rejected
Rejected by: Kunal Parmar
Proposed branch: lp:~vthompson/ubuntu-calendar-app/fixes-1247192
Merge into: lp:ubuntu-calendar-app
Diff against target: 11 lines (+1/-0)
1 file modified
YearView.qml (+1/-0)
To merge this branch: bzr merge lp:~vthompson/ubuntu-calendar-app/fixes-1247192
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Kunal Parmar Needs Fixing
Review via email: mp+193683@code.launchpad.net

Commit message

* Make only current year's GridView visible

Description of the change

* Make only current year's GridView visible

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:165
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/184/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/184
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-ci/184
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-trusty-amd64-ci/18

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/184/rebuild

review: Needs Fixing (continuous-integration)
lp:~vthompson/ubuntu-calendar-app/fixes-1247192 updated
166. By Victor Thompson

Make visible if dragging the PathView

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:166
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/189/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/189
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-ci/189
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-trusty-amd64-ci/23

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/189/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Kunal Parmar (pkunal-parmar) wrote :

This is causing some strage behaviour. While dragging it seems fine, but when you stop dragging you can see empty screen for some time.

Same happens while you are flicking the view, you can see flicker as yearview's visibility changes .

review: Needs Fixing
lp:~vthompson/ubuntu-calendar-app/fixes-1247192 updated
167. By Victor Thompson

merge trunk

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:167
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/225/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-trusty/362
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/225
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-ci/225
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-trusty-amd64-ci/59

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/225/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alan Pope 🍺🐧🐱 🦄 (popey) wrote :

There's a noticeable flicker when moving from one year to the next as Kunal says.. Here's a video. http://youtu.be/pCcCTRSbw1I

lp:~vthompson/ubuntu-calendar-app/fixes-1247192 updated
168. By Victor Thompson

Make all delegates visible while path is moving

169. By Victor Thompson

Merge of trunk

Revision history for this message
Victor Thompson (vthompson) wrote :

Modified this so while the items on the path are still moving they are visible. This prevents the flicker and hopefully satisfies what Leo wants.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Continuous integration, rev:169
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/359/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-trusty/1951
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/359
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-ci/359
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-trusty-amd64-ci/193

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/359/rebuild

review: Needs Fixing (continuous-integration)
lp:~vthompson/ubuntu-calendar-app/fixes-1247192 updated
170. By Victor Thompson

Use index suggestion

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

PASSED: Continuous integration, rev:170
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/361/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-trusty/1953
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-raring-amd64-ci/361
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-saucy-amd64-ci/361
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-calendar-app-trusty-amd64-ci/195

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-calendar-app-ci/361/rebuild

review: Approve (continuous-integration)
Revision history for this message
Kunal Parmar (pkunal-parmar) wrote :

hello, I marked bug as invalid, as I making all view visible is intended behavior.

But if in Autopilot if you need to check if view is current one or not you can use isCurrentItem property.

property bool isCurrentItem: index == root.currentIndex

So I think this MR is not required

Unmerged revisions

170. By Victor Thompson

Use index suggestion

169. By Victor Thompson

Merge of trunk

168. By Victor Thompson

Make all delegates visible while path is moving

167. By Victor Thompson

merge trunk

166. By Victor Thompson

Make visible if dragging the PathView

165. By Victor Thompson

Set previous and next years to be not visible.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'YearView.qml'
--- YearView.qml 2014-03-22 03:07:26 +0000
+++ YearView.qml 2014-04-03 14:46:29 +0000
@@ -23,6 +23,7 @@
23 delegate: GridView{23 delegate: GridView{
24 id: yearView24 id: yearView
25 clip: true25 clip: true
26 visible: index == root.currentIndex || root.moving
2627
27 property bool isCurrentItem: index == root.currentIndex28 property bool isCurrentItem: index == root.currentIndex
28 property int year: (root.currentYear + root.indexType(index))29 property int year: (root.currentYear + root.indexType(index))

Subscribers

People subscribed via source and target branches

to status/vote changes: