Merge lp:~vthompson/music-app/proceeds-to-next into lp:music-app/trusty

[Victor Thompson]

Add a test for app suspension issues.

This adds a test for both music stopping upon app suspension and music stopping when going to next track when app is already suspended.

DO NOT APPROVE UNTIL THE ISSUE IN LP:1292306 IS FIXED!!!!

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:386
http://91.189.93.70:8080/job/music-app-ci/654/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-trusty/1809
    SUCCESS: http://91.189.93.70:8080/job/music-app-raring-amd64-ci/654
    SUCCESS: http://91.189.93.70:8080/job/music-app-saucy-amd64-ci/656
    SUCCESS: http://91.189.93.70:8080/job/music-app-trusty-amd64-ci/375

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/654/rebuild

review: Approve (continuous-integration)

[Andrew Hayzen (ahayzen)]

I wonder if there is a way in autopilot to turn off the screen, as add a wait of 65 and 80 seconds will really slow down the tests.

[Alan Pope 🍺🐧🐱 🦄 (popey)]

bug 1292306 fix should be landing in a Utopic image soon, so we should merge this soon also.

[Victor Thompson (vthompson)]

The fix for lp:1292306 was NOT included in the 14.10 r2 image available in the "ubuntu-touch/utopic-proposed" channel. Just in case anyone else was going to attempt to verify.

[Victor Thompson (vthompson)]

Bug fix was released in the 14.10 image #7. This branch is ready for review and landing.

[lp:~vthompson/music-app/proceeds-to-next]

387. By Victor Thompson on 2014-05-01

Merge and resolve conflict

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:387
http://91.189.93.70:8080/job/music-app-ci/748/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-trusty/2346
    SUCCESS: http://91.189.93.70:8080/job/music-app-raring-amd64-ci/748
    SUCCESS: http://91.189.93.70:8080/job/music-app-saucy-amd64-ci/750
    SUCCESS: http://91.189.93.70:8080/job/music-app-trusty-amd64-ci/469

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/748/rebuild

review: Approve (continuous-integration)

[Andrew Hayzen (ahayzen)]

Just run this on device twice

Ran 18 tests in 1199.034s
OK

First run I had the screen display locked on, second run on auto however once the test finished I manually turned it back on for the next test. I will now run without manually turning the screen on and report the result.

As suggested by Victor, would moving the test to the last position be the best option, so that you can see what the other tests are doing?

[Victor Thompson (vthompson)]

I'll move the tests to the end for now, as I assume it's the best answer. One thing we need to figure out is whether this will work once the media-hub's tracklist implementation lands. When the song switches to the next track everything will be handled in the media hub. We need to determine if 1) media hub will alert the app when the song changes and 2) can autopilot retrieve app components and properties when the app is suspended.

[lp:~vthompson/music-app/proceeds-to-next]

388. By Victor Thompson on 2014-05-02

re-order tests

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:388
http://91.189.93.70:8080/job/music-app-ci/749/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-trusty/2347
    SUCCESS: http://91.189.93.70:8080/job/music-app-raring-amd64-ci/749
    SUCCESS: http://91.189.93.70:8080/job/music-app-saucy-amd64-ci/751
    SUCCESS: http://91.189.93.70:8080/job/music-app-trusty-amd64-ci/470

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/music-app-ci/749/rebuild

review: Approve (continuous-integration)

[Andrew Hayzen (ahayzen)]

OK just run without manually turning the screen on.

Ran 18 tests in 1183.432s
OK

review: Approve

[Victor Thompson (vthompson)]

Setting this as a WIP because the responsibility of testing track management will be done, and done thoroughly, in the media-hub. If the implementation of the media-hub's tracklist functionality and AP allow it, we may eventually land this test, or a similar test, for the app itself.

[Nicholas Skaggs (nskaggs)]

I think I saw a ping about this from you -- if you have a ?, leave it here for me, I'll try and help ;-)

Unmerged revisions

388. By Victor Thompson on 2014-05-02

re-order tests

387. By Victor Thompson on 2014-05-01

Merge and resolve conflict

386. By Victor Thompson on 2014-03-20

Add test for both music stopping on app suspend and music stopping when going to next track when app is suspended.

=== modified file 'tests/autopilot/music_app/tests/test_music.py'
--- tests/autopilot/music_app/tests/test_music.py	2014-04-12 14:31:22 +0000
+++ tests/autopilot/music_app/tests/test_music.py	2014-05-02 00:57:36 +0000
@@ -667,3 +667,36 @@
         actual_title = lambda: self.player.currentMetaTitle
         self.assertThat(actual_title, Eventually(Equals(self.LAST_TITLE)))
         self.assertThat(self.player.isPlaying, Eventually(Equals(True)))
+
+    def test_lifecycle_next_track(self):
+        """ Test that app suspension doesn't prevent playback """
+
+        # populate queue
+        first_genre_item = self.main_view.get_first_genre_item()
+        self.pointing_device.click_object(first_genre_item)
+        trackTitle = "Foss Yeaaaah! (Radio Edit)"
+        song = self.main_view.get_album_sheet_listview_tracktitle(trackTitle)
+        self.pointing_device.click_object(song)
+
+        if not self.player.repeat:
+            repeatbutton = self.main_view.get_repeat_button()
+            logger.debug("Turning on repeat")
+            self.pointing_device.click_object(repeatbutton)
+
+        title = lambda: self.player.currentMetaTitle
+        artist = lambda: self.player.currentMetaArtist
+
+        orgTitle = self.player.currentMetaTitle
+        orgArtist = self.player.currentMetaArtist
+
+        """ Sleep 65 seconds and check next song, should be next song """
+        time.sleep(65)
+        self.assertThat(self.player.isPlaying, Eventually(Equals(True)))
+        self.assertThat(title, Eventually(NotEquals(orgTitle)))
+        self.assertThat(artist, Eventually(NotEquals(orgArtist)))
+
+        """ Sleep 80 seconds and check next song, should be first song """
+        time.sleep(80)
+        self.assertThat(self.player.isPlaying, Eventually(Equals(True)))
+        self.assertThat(title, Eventually(Equals(orgTitle)))
+        self.assertThat(artist, Eventually(Equals(orgArtist)))