Merge lp:~vorlon/upstart/lp.1254326 into lp:upstart

Proposed by Steve Langasek
Status: Merged
Merged at revision: 1577
Proposed branch: lp:~vorlon/upstart/lp.1254326
Merge into: lp:upstart
Diff against target: 28 lines (+9/-1)
2 files modified
ChangeLog (+8/-0)
init/tests/test_state.c (+1/-1)
To merge this branch: bzr merge lp:~vorlon/upstart/lp.1254326
Reviewer Review Type Date Requested Status
Dimitri John Ledkov Approve
Review via email: mp+196428@code.launchpad.net

Description of the change

Fix wrong assumption that SIGUSR1 == 10 in the test code

To post a comment you must log in.
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

This also fixes the test-case under kFreeBSD.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'ChangeLog'
--- ChangeLog 2013-11-18 10:31:21 +0000
+++ ChangeLog 2013-11-23 19:55:40 +0000
@@ -1,3 +1,11 @@
12013-11-23 Steve Langasek <steve.langasek@ubuntu.com>
2
3 * init/tests/test_state.c: fix test case to not assume SIGUSR1 == 10;
4 the numeric value may vary between platforms, what we actually care
5 about is making sure that the deserialization output matches what
6 was in the json - so check the numeric value, NOT the symbolic
7 signal name.
8
12013-11-16 Dmitrijs Ledkovs <xnox@ubuntu.com>92013-11-16 Dmitrijs Ledkovs <xnox@ubuntu.com>
210
3 * init/xdg.c, util/Makefile.am, test/Makefile.am, init/conf.c:11 * init/xdg.c, util/Makefile.am, test/Makefile.am, init/conf.c:
412
=== modified file 'init/tests/test_state.c'
--- init/tests/test_state.c 2013-11-18 10:15:36 +0000
+++ init/tests/test_state.c 2013-11-23 19:55:40 +0000
@@ -4460,7 +4460,7 @@
4460 NIH_HASH_FOREACH (job_classes, iter) {4460 NIH_HASH_FOREACH (job_classes, iter) {
4461 JobClass *class = (JobClass *)iter;4461 JobClass *class = (JobClass *)iter;
4462 if (strcmp (class->name, "whoopsie") == 0) {4462 if (strcmp (class->name, "whoopsie") == 0) {
4463 TEST_EQ (class->reload_signal, SIGUSR1);4463 TEST_EQ (class->reload_signal, 10);
4464 } else4464 } else
4465 TEST_EQ (class->reload_signal, SIGHUP);4465 TEST_EQ (class->reload_signal, SIGHUP);
4466 }4466 }

Subscribers

People subscribed via source and target branches