Merge lp:~vila/bzr/1451448-skip-racy-tests into lp:bzr
Proposed by
Vincent Ladeuil
Status: | Merged |
---|---|
Approved by: | Richard Wilbur |
Approved revision: | no longer in the source branch. |
Merged at revision: | 6604 |
Proposed branch: | lp:~vila/bzr/1451448-skip-racy-tests |
Merge into: | lp:bzr |
Diff against target: |
137 lines (+35/-7) 5 files modified
bzrlib/tests/test_http.py (+18/-3) bzrlib/tests/test_osutils.py (+3/-1) bzrlib/tests/test_transport.py (+2/-1) bzrlib/tests/test_urlutils.py (+3/-2) doc/en/release-notes/bzr-2.7.txt (+9/-0) |
To merge this branch: | bzr merge lp:~vila/bzr/1451448-skip-racy-tests |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Richard Wilbur | Approve | ||
Review via email: mp+270266@code.launchpad.net |
Commit message
Fix test failures blocking package builds.
Description of the change
This MP fixes the failures encountered since python 2.7.9 (see bug).
The http tests are the most trivial http tests so I'm confident the code is ok and that a *new* race is exposed. Moreover it's exposed only when the http client and server are running in the same thread.
I also skip the windows tests are this needs to be fixed and tested on windows (and I don't have access to a windows host) and that shouldn't block other platforms.
To post a comment you must log in.
Thanks for the fixes, Vincent. Both situations seem suspect: running the http client and server in the same thread seems prone to races, running windows filesystem-specific tests on a non-windows filesystem sounds like it would be likely to fail.
+1