Merge lp:~vauxoo/openerp-product-attributes/7.0-prod_vol_weight-dev-humbertoarocha into lp:~product-core-editors/openerp-product-attributes/7.0

[hbto [Vauxoo] http://www.vauxoo.com]

Hello Comm Guys,

We want to submit the following module,
product_volumentric_weight, to your review,

be aware that we want to added new features
to this module in the near future but these
have been keep away from this submission due to the
fact that there are still some agreements to be reached
in the following discussion in this merge proposal.

https://code.launchpad.net/~sebastien.beau/openerp-product-attributes/openerp-product-attributes-product-dimension/+merge/171181

In the meantime the field that bears in this module
is a plain float, later it will evolve into functional float.

Best Regards.

[Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903)]

Thanks Humberto.

Minor fixes:

l30,31: Can you use "from . import" ?
l79: Can you fix indentation ?
l121: Can you use "from . import" ?
l155, datetime, as a standard Python library, should be imported before OpenERP-specific ones.
l161,162: Can you fix indentation ?

Can you add the translation file and remove the wizard and workflow directories ? I guess they will be used later with the new features.

review: Needs Fixing

[Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903)]

model and views are generally in the module directory, not in sub-directories.

IMHO, there is no need for them with such a small module.

[Stefan Rijnhart (Opener) (stefan-opener)]

l.76: only need to depend on product, which depends on base itself.
l.158: please use orm.Model

Shouldn't some kind of UOM be used for this? What I read from Wikipedia, common UOMS are cm3/kg, kg/m3, in3/lb, lb/ft3.
 Without UOM, the amount is meaningless.

About having model files and views in separate directories, I find this a useful convention, no matter how small the module contents are.

review: Needs Fixing

[Daniel Reis (dreis-pt)]

Personally I find sub-directories cumbersome and only really useful on larger modules (my 2 cents).

[David BEAL (ak) (davidbeal)]

> Personally I find sub-directories cumbersome and only really useful on larger
> modules (my 2 cents).

+1

[Stefan Rijnhart (Opener) (stefan-opener)]

Given the vagueness of the criterium 'larger modules', we might as well leave it out of the review then.

[hbto [Vauxoo] http://www.vauxoo.com (humbertoarocha)]

> model and views are generally in the module directory, not in sub-directories.
>
> IMHO, there is no need for them with such a small module.

Hey Guys,

Regarding large / small module, with at vauxoo are sticking to a standard,
no matter how large or small a module is, we, vauxoo, always can find easily
what we are looking for, due to the fact it is more cumbersome, look for
something into account module in openobject-addons than in addons-vauxoo.

So I will kindly disregard your suggestion Daniel Reis.

[hbto [Vauxoo] http://www.vauxoo.com (humbertoarocha)]

> l79: Can you fix indentation ?
> l155, datetime, as a standard Python library, should be imported before
> OpenERP-specific ones.

to be uploaded, already DONE

> l30,31: Can you use "from . import" ?
> l121: Can you use "from . import" ?
> l161,162: Can you fix indentation ?

Can you kindly show me an example, Please

> Can you add the translation file and remove the wizard and workflow
> directories ? I guess they will be used later with the new features.

these are to be done

[hbto [Vauxoo] http://www.vauxoo.com (humbertoarocha)]

> l79: Can you fix indentation ?
> l155, datetime, as a standard Python library, should be imported before
> OpenERP-specific ones.

to be uploaded, already DONE

> l30,31: Can you use "from . import" ?
> l121: Can you use "from . import" ?
> l161,162: Can you fix indentation ?

Can you kindly show me an example, Please

> Can you add the translation file and remove the wizard and workflow
> directories ? I guess they will be used later with the new features.

these are to be done

[lp:~vauxoo/openerp-product-attributes/7.0-prod_vol_weight-dev-humbertoarocha]

216. By hbto [Vauxoo] http://www.vauxoo.com on 2013-10-10

[FIX][product_volumetric_weight] Minor changes

217. By hbto [Vauxoo] http://www.vauxoo.com on 2013-10-10

[FIX][product_volumetric_weight] Less dependencies

[Stefan Rijnhart (Opener) (stefan-opener)]

Hi, I'd still be interested in a response to my comment about UOM.

[Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903)]

@hbto

Here are what the lines should be :
l30: from . import model
l122: from . import product

l43 to l45: Can you move those lines in the module description ?

To answer Stefan, can you add the UOM in the help of the field (l162) ?

review: Needs Fixing (code review)

[Daniel Reis (dreis-pt)]

I personally tried but had trouble with the " from . import" formula: if the addons dir is a symlink and the module dir is another symlink, the import failed.

DR

No dia 27/12/2013, às 19:04, "Maxime Chambreuil \(http://www.savoirfairelinux.com\)" <email address hidden> escreveu:

> Review: Needs Fixing code review
>
> @hbto
>
> Here are what the lines should be :
> l30: from . import model
> l122: from . import product
>
> l43 to l45: Can you move those lines in the module description ?
>
> To answer Stefan, can you add the UOM in the help of the field (l162) ?
> --
> https://code.launchpad.net/~vauxoo/openerp-product-attributes/7.0-prod_vol_weight-dev-humbertoarocha/+merge/189956
> Your team OpenERP Community is subscribed to branch lp:openerp-product-attributes.
>
> _______________________________________________
> Mailing list: https://launchpad.net/~openerp-community
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~openerp-community
> More help : https://help.launchpad.net/ListHelp

[Laetitia Gangloff (Acsone) (laetitia-gangloff)]

This project is now hosted on https://github.com/OCA/product-attribute. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub

review: Needs Resubmitting

Unmerged revisions

217. By hbto [Vauxoo] http://www.vauxoo.com on 2013-10-10

[FIX][product_volumetric_weight] Less dependencies

216. By hbto [Vauxoo] http://www.vauxoo.com on 2013-10-10

[FIX][product_volumetric_weight] Minor changes

215. By hbto [Vauxoo] http://www.vauxoo.com on 2013-10-08

[IMP][product_volumetric_weight] Added module which will let set a volumetric
weight to the product.

=== added directory 'product_volumetric_weight'
=== added file 'product_volumetric_weight/__init__.py'
--- product_volumetric_weight/__init__.py	1970-01-01 00:00:00 +0000
+++ product_volumetric_weight/__init__.py	2013-10-10 20:49:25 +0000
@@ -0,0 +1,25 @@
+#!/usr/bin/python
+# -*- encoding: utf-8 -*-
+###############################################################################
+#    Module Writen to OpenERP, Open Source Management Solution
+#    Copyright (C) OpenERP Venezuela (<http://www.vauxoo.com>).
+#    All Rights Reserved
+############# Credits #########################################################
+#    Coded by: Yanina Aular <[e-mail]>
+#    Planified by: Humberto Arocha <[e-mail]>
+#    Audited by: Humberto Arocha <[e-mail]>
+###############################################################################
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as published
+#    by the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+###############################################################################
+import model
 
=== added file 'product_volumetric_weight/__openerp__.py'
--- product_volumetric_weight/__openerp__.py	1970-01-01 00:00:00 +0000
+++ product_volumetric_weight/__openerp__.py	2013-10-10 20:49:25 +0000
@@ -0,0 +1,50 @@
+#!/usr/bin/python
+# -*- encoding: utf-8 -*-
+###############################################################################
+#    Module Writen to OpenERP, Open Source Management Solution
+#    Copyright (C) OpenERP Venezuela (<http://www.vauxoo.com>).
+#    All Rights Reserved
+############# Credits #########################################################
+#    Coded by: Yanina Aular <[e-mail]>
+#    Planified by: Humberto Arocha <[e-mail]>
+#    Audited by: Humberto Arocha <[e-mail]>
+###############################################################################
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as published
+#    by the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+###############################################################################
+
+{
+    'name': 'Product Volumetric',
+    'version': '1.0',
+    'author': 'Vauxoo',
+    'website': 'http://www.vauxoo.com/',
+    'category': 'product',
+    'summary' : 'Added field volumetric weight to the product',
+    'description': '''
+Product Dimensions
+==================
+
+With this module, field volumetric weight is added to model product.
+
+''',
+    'depends': [
+        'product',
+    ],
+    'data': [
+        'view/product_view.xml',
+    ],
+    'demo': [],
+    'test': [],
+    'active': False,
+    'installable': True,
+}
 
=== added directory 'product_volumetric_weight/data'
=== added directory 'product_volumetric_weight/demo'
=== added directory 'product_volumetric_weight/doc'
=== added directory 'product_volumetric_weight/doc/images'
=== added directory 'product_volumetric_weight/i18n'
=== added directory 'product_volumetric_weight/model'
=== added file 'product_volumetric_weight/model/__init__.py'
--- product_volumetric_weight/model/__init__.py	1970-01-01 00:00:00 +0000
+++ product_volumetric_weight/model/__init__.py	2013-10-10 20:49:25 +0000
@@ -0,0 +1,26 @@
+#!/usr/bin/python
+# -*- encoding: utf-8 -*-
+###############################################################################
+#    Module Writen to OpenERP, Open Source Management Solution
+#    Copyright (C) OpenERP Venezuela (<http://www.vauxoo.com>).
+#    All Rights Reserved
+############# Credits #########################################################
+#    Coded by: Yanina Aular <[e-mail]>
+#    Planified by: Humberto Arocha <[e-mail]>
+#    Audited by: Humberto Arocha <[e-mail]>
+###############################################################################
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as published
+#    by the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+###############################################################################
+
+import product
 
=== added file 'product_volumetric_weight/model/product.py'
--- product_volumetric_weight/model/product.py	1970-01-01 00:00:00 +0000
+++ product_volumetric_weight/model/product.py	2013-10-10 20:49:25 +0000
@@ -0,0 +1,37 @@
+#!/usr/bin/python
+# -*- encoding: utf-8 -*-
+###############################################################################
+#    Module Writen to OpenERP, Open Source Management Solution
+#    Copyright (C) OpenERP Venezuela (<http://www.vauxoo.com>).
+#    All Rights Reserved
+############# Credits #########################################################
+#    Coded by: Yanina Aular <[e-mail]>
+#    Planified by: Humberto Arocha <[e-mail]>
+#    Audited by: Humberto Arocha <[e-mail]>
+###############################################################################
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as published
+#    by the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+###############################################################################
+
+import datetime
+from openerp.osv import fields, osv
+from openerp.tools.translate import _
+from openerp import tools
+
+
+class product_product(osv.Model):
+    _inherit = 'product.product'
+    _columns = {
+        'volumetric_weight': fields.float('Volumetric Weight', help='Volumetric Weight per Unit'), 
+    }
+    
 
=== added directory 'product_volumetric_weight/report'
=== added directory 'product_volumetric_weight/security'
=== added directory 'product_volumetric_weight/static'
=== added directory 'product_volumetric_weight/static/description'
=== added file 'product_volumetric_weight/static/description/index.html'
=== added directory 'product_volumetric_weight/static/src'
=== added directory 'product_volumetric_weight/static/src/css'
=== added directory 'product_volumetric_weight/static/src/img'
=== added file 'product_volumetric_weight/static/src/img/icon.png'
 Binary files product_volumetric_weight/static/src/img/icon.png	1970-01-01 00:00:00 +0000 and product_volumetric_weight/static/src/img/icon.png	2013-10-10 20:49:25 +0000 differ
=== added directory 'product_volumetric_weight/static/src/js'
=== added directory 'product_volumetric_weight/static/src/xml'
=== added directory 'product_volumetric_weight/test'
=== added directory 'product_volumetric_weight/view'
=== added file 'product_volumetric_weight/view/product_view.xml'
--- product_volumetric_weight/view/product_view.xml	1970-01-01 00:00:00 +0000
+++ product_volumetric_weight/view/product_view.xml	2013-10-10 20:49:25 +0000
@@ -0,0 +1,17 @@
+<?xml version="1.0" encoding="utf-8"?>
+<openerp>
+    <data>
+        <record id="product_volumetric_form_view" model="ir.ui.view">         
+            <field name="name">product.product</field>            
+            <field name="model">product.product</field>                             
+            <field name="inherit_id" ref="product.product_normal_form_view"/>             
+            <field name="arch" type="xml">                                      
+                <xpath expr="//page[@string='Information']" position="inside">
+                    <group string="Dimensions of Unit">
+                        <field name="volumetric_weight"/>
+                    </group>
+                </xpath>                                                        
+            </field>                                                            
+        </record>
+    </data>
+</openerp>