Merge lp:~urbanape/bindwood/fix-lp461371 into lp:bindwood

Proposed by Zachery Bir
Status: Merged
Approved by: Tim Cole
Approved revision: 18
Merged at revision: not available
Proposed branch: lp:~urbanape/bindwood/fix-lp461371
Merge into: lp:bindwood
Diff against target: 12 lines
1 file modified
content/sync.js (+1/-1)
To merge this branch: bzr merge lp:~urbanape/bindwood/fix-lp461371
Reviewer Review Type Date Requested Status
Tim Cole (community) Approve
Stuart Langridge (community) Approve
Review via email: mp+13986@code.launchpad.net

Commit message

Fix a typo that prevents Bindwood from properly propagating change notifications to CouchDB.

To post a comment you must log in.
Revision history for this message
Zachery Bir (urbanape) wrote :

This branch fixes a silly typo that keeps Bindwood from properly propagating change notifications to CouchDB.

Revision history for this message
Zachery Bir (urbanape) wrote :

If you want to test, install latest trunk, make a change to a local bookmark, and watch it fail to propagate to CouchDB. A little while later, watch as the local bookmarks is reverted from its Couch record.

In this branch, the change is properly propagated to Couch.

Revision history for this message
Stuart Langridge (sil) wrote :

Good catch; works for me. Approved.

review: Approve
Revision history for this message
Tim Cole (tcole) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'content/sync.js'
--- content/sync.js 2009-10-23 16:55:55 +0000
+++ content/sync.js 2009-10-26 20:10:23 +0000
@@ -886,7 +886,7 @@
886 // A property of a bookmark has changed. On multiple886 // A property of a bookmark has changed. On multiple
887 // property updates, this will be called multiple times,887 // property updates, this will be called multiple times,
888 // once per property (i.e., for title and URI)888 // once per property (i.e., for title and URI)
889 if (!Bindwood.itemWeCareAbout(aItemId)) {889 if (!Bindwood.itemWeCareAbout(aBookmarkId)) {
890 Bindwood.writeMessage("Ignoring this change event");890 Bindwood.writeMessage("Ignoring this change event");
891 return;891 return;
892 }892 }

Subscribers

People subscribed via source and target branches