Merge lp:~unity-team/unity/unity.fix-lp729715 into lp:unity

Proposed by Jason Smith
Status: Merged
Merged at revision: 1056
Proposed branch: lp:~unity-team/unity/unity.fix-lp729715
Merge into: lp:unity
Diff against target: 69 lines (+21/-9)
2 files modified
src/Launcher.cpp (+15/-1)
src/Launcher.h (+6/-8)
To merge this branch: bzr merge lp:~unity-team/unity/unity.fix-lp729715
Reviewer Review Type Date Requested Status
Jay Taoko (community) Approve
Review via email: mp+55799@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jay Taoko (jaytaoko) wrote :

Approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/Launcher.cpp'
--- src/Launcher.cpp 2011-03-31 07:08:44 +0000
+++ src/Launcher.cpp 2011-03-31 17:45:48 +0000
@@ -278,7 +278,6 @@
278 m_LastSpreadIcon = NULL;278 m_LastSpreadIcon = NULL;
279279
280 _current_icon = NULL;280 _current_icon = NULL;
281 _last_selected_icon = NULL;
282 _current_icon_index = -1;281 _current_icon_index = -1;
283 _last_icon_index = -1;282 _last_icon_index = -1;
284283
@@ -2011,6 +2010,21 @@
2011 if (icon->needs_redraw_connection.connected ())2010 if (icon->needs_redraw_connection.connected ())
2012 icon->needs_redraw_connection.disconnect ();2011 icon->needs_redraw_connection.disconnect ();
20132012
2013 if (icon == _current_icon)
2014 _current_icon = 0;
2015 if (icon == m_ActiveTooltipIcon)
2016 m_ActiveTooltipIcon = 0;
2017 if (icon == m_ActiveMenuIcon)
2018 m_ActiveMenuIcon = 0;
2019 if (icon == m_LastSpreadIcon)
2020 m_LastSpreadIcon = 0;
2021 if (icon == _icon_under_mouse)
2022 _icon_under_mouse = 0;
2023 if (icon == _icon_mouse_down)
2024 _icon_mouse_down = 0;
2025 if (icon == _drag_icon)
2026 _drag_icon = 0;
2027
2014 icon->UnReference ();2028 icon->UnReference ();
2015 EnsureAnimation();2029 EnsureAnimation();
2016 RemoveChild (icon);2030 RemoveChild (icon);
20172031
=== modified file 'src/Launcher.h'
--- src/Launcher.h 2011-03-30 09:34:07 +0000
+++ src/Launcher.h 2011-03-31 17:45:48 +0000
@@ -382,13 +382,15 @@
382 nux::HLayout* m_Layout;382 nux::HLayout* m_Layout;
383 int m_ContentOffsetY;383 int m_ContentOffsetY;
384384
385 // used by keyboard/a11y-navigation
386 LauncherIcon* _current_icon;
385 LauncherIcon* m_ActiveTooltipIcon;387 LauncherIcon* m_ActiveTooltipIcon;
386 LauncherIcon* m_ActiveMenuIcon;388 LauncherIcon* m_ActiveMenuIcon;
387 LauncherIcon* m_LastSpreadIcon;389 LauncherIcon* m_LastSpreadIcon;
390 LauncherIcon* _icon_under_mouse;
391 LauncherIcon* _icon_mouse_down;
392 LauncherIcon* _drag_icon;
388393
389 // used by keyboard/a11y-navigation
390 LauncherIcon* _current_icon;
391 LauncherIcon* _last_selected_icon;
392 int _current_icon_index;394 int _current_icon_index;
393 int _last_icon_index;395 int _last_icon_index;
394396
@@ -413,11 +415,7 @@
413 LauncherActionState _launcher_action_state;415 LauncherActionState _launcher_action_state;
414 LaunchAnimation _launch_animation;416 LaunchAnimation _launch_animation;
415 UrgentAnimation _urgent_animation;417 UrgentAnimation _urgent_animation;
416 AutoHideAnimation _autohide_animation;418 AutoHideAnimation _autohide_animation;
417
418 LauncherIcon* _icon_under_mouse;
419 LauncherIcon* _icon_mouse_down;
420 LauncherIcon* _drag_icon;
421419
422 int _space_between_icons;420 int _space_between_icons;
423 int _icon_size;421 int _icon_size;