Merge lp:~unity-team/unity-lens-video/unity-scope-video-remote-precise into lp:ubuntu/precise/unity-scope-video-remote

Proposed by Timo Jyrinki
Status: Merged
Merge reported by: Sebastien Bacher
Merged at revision: not available
Proposed branch: lp:~unity-team/unity-lens-video/unity-scope-video-remote-precise
Merge into: lp:ubuntu/precise/unity-scope-video-remote
Diff against target: 117 lines (+42/-16)
4 files modified
MANIFEST.in (+4/-0)
debian/changelog (+15/-0)
debian/control (+3/-1)
src/unity-scope-video-remote (+20/-15)
To merge this branch: bzr merge lp:~unity-team/unity-lens-video/unity-scope-video-remote-precise
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Review via email: mp+158864@code.launchpad.net

Commit message

* Cherry-pick a fix from upstream:
  - Use https connection when talking to the server (LP: #1071079)

Description of the change

* Cherry-pick a fix from upstream:
  - Use https connection when talking to the server (LP: #1071079)

To post a comment you must log in.
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Tested manually with a built package (from ppa:unity-team/sru) with tcpdump.

Revision history for this message
Sebastien Bacher (seb128) wrote :

thanks, I've uploaded that to the precise SRU queue

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'MANIFEST.in'
--- MANIFEST.in 2012-01-31 15:55:00 +0000
+++ MANIFEST.in 2013-04-15 08:48:32 +0000
@@ -2,3 +2,7 @@
2include video-remote.scope2include video-remote.scope
3include src/unity-scope-video-remote3include src/unity-scope-video-remote
4include COPYING4include COPYING
5include unity-scope-video-remote.service
6include video-remote.scope
7include src/unity-scope-video-remote
8include COPYING
59
=== modified file 'debian/changelog'
--- debian/changelog 2012-04-06 20:56:42 +0000
+++ debian/changelog 2013-04-15 08:48:32 +0000
@@ -1,3 +1,18 @@
1unity-scope-video-remote (0.3.5-0ubuntu2.2) UNRELEASED; urgency=low
2
3 * Cherry-pick a fix from upstream:
4 - Use https connection when talking to the server (LP: #1071079)
5 * Update maintainer to be Ubuntu Developers
6
7 -- Timo Jyrinki <timo-jyrinki@ubuntu.com> Mon, 25 Feb 2013 11:44:03 +0200
8
9unity-scope-video-remote (0.3.5-0ubuntu2.1) precise-proposed; urgency=low
10
11 * Exit on DBus hickup at startup, Unity will restart the scope (LP: #950862)
12 * Depends on gvfs-bin (LP: #972304)
13
14 -- David Callé <davidc@framli.eu> Wed, 27 Jun 2012 20:33:46 +0200
15
1unity-scope-video-remote (0.3.5-0ubuntu2) precise; urgency=low16unity-scope-video-remote (0.3.5-0ubuntu2) precise; urgency=low
217
3 * src/unity-scope-video-remote18 * src/unity-scope-video-remote
419
=== modified file 'debian/control'
--- debian/control 2012-03-02 20:24:25 +0000
+++ debian/control 2013-04-15 08:48:32 +0000
@@ -1,7 +1,8 @@
1Source: unity-scope-video-remote1Source: unity-scope-video-remote
2Section: gnome2Section: gnome
3Priority: optional3Priority: optional
4Maintainer: David Calle <davidc@framli.eu>4Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
5XSBC-Original-Maintainer: David Calle <davidc@framli.eu>
5Build-Depends: debhelper (>= 8), python, python-distutils-extra6Build-Depends: debhelper (>= 8), python, python-distutils-extra
6Standards-Version: 3.9.27Standards-Version: 3.9.2
7Homepage: https://launchpad.net/unity-lens-videos8Homepage: https://launchpad.net/unity-lens-videos
@@ -15,6 +16,7 @@
15 gir1.2-soup-2.4,16 gir1.2-soup-2.4,
16 gir1.2-glib-2.0,17 gir1.2-glib-2.0,
17 python-zeitgeist,18 python-zeitgeist,
19 gvfs-bin,
18 unity-lens-video20 unity-lens-video
19Enhances: unity-lens-video21Enhances: unity-lens-video
20Description: Remote videos engine22Description: Remote videos engine
2123
=== modified file 'debian/rules' (properties changed: +x to -x)
=== modified file 'src/unity-scope-video-remote'
--- src/unity-scope-video-remote 2012-04-06 20:56:42 +0000
+++ src/unity-scope-video-remote 2013-04-15 08:48:32 +0000
@@ -43,7 +43,7 @@
43#pylint: enable=E061143#pylint: enable=E0611
4444
45BUS_NAME = "net.launchpad.scope.RemoteVideos"45BUS_NAME = "net.launchpad.scope.RemoteVideos"
46SERVER = "http://videosearch.ubuntu.com/v0"46SERVER = "https://videosearch.ubuntu.com/v0"
4747
48REFRESH_INTERVAL = 3600 # fetch sources & recommendations once an hour48REFRESH_INTERVAL = 3600 # fetch sources & recommendations once an hour
49RETRY_INTERVAL = 60 # retry sources/recommendations after a minute49RETRY_INTERVAL = 60 # retry sources/recommendations after a minute
@@ -76,6 +76,8 @@
76 self.scope.connect ("activate-uri", self.on_activate_uri)76 self.scope.connect ("activate-uri", self.on_activate_uri)
77 self.session = Soup.SessionAsync()77 self.session = Soup.SessionAsync()
78 self.session.props.user_agent = "Unity Video Lens Remote Scope v0.4"78 self.session.props.user_agent = "Unity Video Lens Remote Scope v0.4"
79 self.session.props.ssl_use_system_ca_file = True
80 self.session.props.ssl_strict = True
79 self.session.add_feature_by_type(SoupGNOME.ProxyResolverGNOME)81 self.session.add_feature_by_type(SoupGNOME.ProxyResolverGNOME)
80 self.query_list_of_sources()82 self.query_list_of_sources()
81 self.update_recommendations()83 self.update_recommendations()
@@ -287,20 +289,23 @@
287289
288def main():290def main():
289 """Connect to the session bus, exit if there is a running instance."""291 """Connect to the session bus, exit if there is a running instance."""
290 session_bus_connection = Gio.bus_get_sync(Gio.BusType.SESSION, None)292 try:
291 session_bus = Gio.DBusProxy.new_sync(session_bus_connection, 0, None,293 session_bus_connection = Gio.bus_get_sync(Gio.BusType.SESSION, None)
292 'org.freedesktop.DBus',294 session_bus = Gio.DBusProxy.new_sync(session_bus_connection, 0, None,
293 '/org/freedesktop/DBus',295 'org.freedesktop.DBus',
294 'org.freedesktop.DBus', None)296 '/org/freedesktop/DBus',
295 result = session_bus.call_sync('RequestName',297 'org.freedesktop.DBus', None)
296 GLib.Variant("(su)", (BUS_NAME, 0x4)),298 result = session_bus.call_sync('RequestName',
297 0, -1, None)299 GLib.Variant("(su)", (BUS_NAME, 0x4)),
298300 0, -1, None)
299 # Unpack variant response with signature "(u)". 1 means we got it.301
300 result = result.unpack()[0]302 # Unpack variant response with signature "(u)". 1 means we got it.
301303 result = result.unpack()[0]
302 if result != 1:304
303 print >> sys.stderr, "Failed to own name %s. Bailing out." % BUS_NAME305 if result != 1:
306 print >> sys.stderr, "Failed to own name %s. Bailing out." % BUS_NAME
307 raise SystemExit(1)
308 except:
304 raise SystemExit(1)309 raise SystemExit(1)
305310
306 Daemon()311 Daemon()

Subscribers

People subscribed via source and target branches

to all changes: