Merge ~ubuntu-core-dev/grub/+git/ubuntu:breadcrumbs into ~ubuntu-core-dev/grub/+git/ubuntu:ubuntu

Proposed by Mathieu Trudel-Lapierre
Status: Merged
Merged at revision: a053265bdf9d204aede8c593bed6e68a69513f72
Proposed branch: ~ubuntu-core-dev/grub/+git/ubuntu:breadcrumbs
Merge into: ~ubuntu-core-dev/grub/+git/ubuntu:ubuntu
Diff against target: 93 lines (+40/-2)
5 files modified
debian/.git-dpm (+2/-2)
debian/changelog (+6/-0)
debian/patches/mkconfig_leave_breadcrumbs.patch (+29/-0)
debian/patches/series (+1/-0)
util/grub-mkconfig.in (+2/-0)
Reviewer Review Type Date Requested Status
Steve Langasek Approve
Review via email: mp+361465@code.launchpad.net

Commit message

debian/patches/mkconfig_leave_breadcrumbs.patch: make sure grub-mkconfig
leaves a trace of what files were sourced to help generate the config
we're building.

Description of the change

Add breadcrumbs so we know what files in /etc/default/grub, /etc/default/grub.d/* are used to generate grub configuration.

To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) :
Revision history for this message
Steve Langasek (vorlon) wrote :

+1 based on out-of-band confirmation from Matt that this matches existing quoting convention in grub output.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/debian/.git-dpm b/debian/.git-dpm
index 1670e9a..5fbfdf7 100644
--- a/debian/.git-dpm
+++ b/debian/.git-dpm
@@ -1,6 +1,6 @@
1# see git-dpm(1) from git-dpm package1# see git-dpm(1) from git-dpm package
2896d6d6ed832e6a2a1429cf17a51bc94efcb3de124c5bf7a6fa6798a5972bdf7999edd3bb5e294647
3896d6d6ed832e6a2a1429cf17a51bc94efcb3de134c5bf7a6fa6798a5972bdf7999edd3bb5e294647
459aeb1cfaa3d5bfd7bbeeee0f0d37f6d9eed51fe459aeb1cfaa3d5bfd7bbeeee0f0d37f6d9eed51fe
559aeb1cfaa3d5bfd7bbeeee0f0d37f6d9eed51fe559aeb1cfaa3d5bfd7bbeeee0f0d37f6d9eed51fe
6grub2_2.02+dfsg1.orig.tar.xz6grub2_2.02+dfsg1.orig.tar.xz
diff --git a/debian/changelog b/debian/changelog
index f4ca0e8..d14d8ec 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,8 +1,14 @@
1grub2 (2.02+dfsg1-5ubuntu9) UNRELEASED; urgency=medium1grub2 (2.02+dfsg1-5ubuntu9) UNRELEASED; urgency=medium
22
3 [ Steve Langasek ]
3 * debian/patches/quick-boot-lvm.patch: If we don't have writable4 * debian/patches/quick-boot-lvm.patch: If we don't have writable
4 grubenv and we're on EFI, always show the menu. Closes LP: #1800722.5 grubenv and we're on EFI, always show the menu. Closes LP: #1800722.
56
7 [ Mathieu Trudel-Lapierre ]
8 * debian/patches/mkconfig_leave_breadcrumbs.patch: make sure grub-mkconfig
9 leaves a trace of what files were sourced to help generate the config
10 we're building.
11
6 -- Steve Langasek <steve.langasek@ubuntu.com> Tue, 30 Oct 2018 15:46:28 -070012 -- Steve Langasek <steve.langasek@ubuntu.com> Tue, 30 Oct 2018 15:46:28 -0700
713
8grub2 (2.02+dfsg1-5ubuntu8) cosmic; urgency=medium14grub2 (2.02+dfsg1-5ubuntu8) cosmic; urgency=medium
diff --git a/debian/patches/mkconfig_leave_breadcrumbs.patch b/debian/patches/mkconfig_leave_breadcrumbs.patch
9new file mode 10064415new file mode 100644
index 0000000..62a4f58
--- /dev/null
+++ b/debian/patches/mkconfig_leave_breadcrumbs.patch
@@ -0,0 +1,29 @@
1From 4c5bf7a6fa6798a5972bdf7999edd3bb5e294647 Mon Sep 17 00:00:00 2001
2From: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com>
3Date: Fri, 14 Dec 2018 13:46:14 -0500
4Subject: grub-mkconfig: leave a trace of what files were sourced to generate
5 the config
6
7Patch-Name: mkconfig_leave_breadcrumbs.patch
8Signed-off-by: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com>
9---
10 util/grub-mkconfig.in | 2 ++
11 1 file changed, 2 insertions(+)
12
13diff --git a/util/grub-mkconfig.in b/util/grub-mkconfig.in
14index 9fca8cd7e..f1e7ca829 100644
15--- a/util/grub-mkconfig.in
16+++ b/util/grub-mkconfig.in
17@@ -155,10 +155,12 @@ if [ x"$GRUB_FS" = xunknown ]; then
18 fi
19
20 if test -f ${sysconfdir}/default/grub ; then
21+ gettext_printf "Sourcing file \`%s'\n" "${sysconfdir}/default/grub" 1>&2
22 . ${sysconfdir}/default/grub
23 fi
24 for x in ${sysconfdir}/default/grub.d/*.cfg ; do
25 if [ -e "${x}" ]; then
26+ gettext_printf "Sourcing file \`%s'\n" "${x}" 1>&2
27 . "${x}"
28 fi
29 done
diff --git a/debian/patches/series b/debian/patches/series
index 472bf2b..75a5629 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -93,3 +93,4 @@ linuxefi_fix_relocate_coff.patch
93linuxefi_truncate_overlong_relocs.patch93linuxefi_truncate_overlong_relocs.patch
94add-initrd-less-boot-fallback.patch94add-initrd-less-boot-fallback.patch
95quick-boot-lvm.patch95quick-boot-lvm.patch
96mkconfig_leave_breadcrumbs.patch
diff --git a/util/grub-mkconfig.in b/util/grub-mkconfig.in
index 9fca8cd..f1e7ca8 100644
--- a/util/grub-mkconfig.in
+++ b/util/grub-mkconfig.in
@@ -155,10 +155,12 @@ if [ x"$GRUB_FS" = xunknown ]; then
155fi155fi
156156
157if test -f ${sysconfdir}/default/grub ; then157if test -f ${sysconfdir}/default/grub ; then
158 gettext_printf "Sourcing file \`%s'\n" "${sysconfdir}/default/grub" 1>&2
158 . ${sysconfdir}/default/grub159 . ${sysconfdir}/default/grub
159fi160fi
160for x in ${sysconfdir}/default/grub.d/*.cfg ; do161for x in ${sysconfdir}/default/grub.d/*.cfg ; do
161 if [ -e "${x}" ]; then162 if [ -e "${x}" ]; then
163 gettext_printf "Sourcing file \`%s'\n" "${x}" 1>&2
162 . "${x}"164 . "${x}"
163 fi165 fi
164done166done

Subscribers

People subscribed via source and target branches