Merge lp:~tpeeters/ubuntu-ui-toolkit/headerNoClip into lp:ubuntu-ui-toolkit/staging
Proposed by
Tim Peeters
Status: | Merged |
---|---|
Approved by: | Zsombor Egri |
Approved revision: | 1796 |
Merged at revision: | 1796 |
Proposed branch: | lp:~tpeeters/ubuntu-ui-toolkit/headerNoClip |
Merge into: | lp:ubuntu-ui-toolkit/staging |
Diff against target: |
90 lines (+18/-20) 4 files modified
src/Ubuntu/Components/1.3/AdaptivePageLayout.qml (+1/-0) src/Ubuntu/Components/1.3/AppHeader.qml (+5/-0) src/Ubuntu/Components/1.3/MainView.qml (+3/-20) src/Ubuntu/Components/Themes/Ambiance/1.3/PageHeadStyle.qml (+9/-0) |
To merge this branch: | bzr merge lp:~tpeeters/ubuntu-ui-toolkit/headerNoClip |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Zsombor Egri | Approve | ||
Andrew Hayzen (community) | functional | Approve | |
PS Jenkins bot | continuous-integration | Approve | |
Review via email: mp+281738@code.launchpad.net |
Commit message
Add background to AppHeader and remove contents clipping from MainView.
Description of the change
Note that with this change, the AppHeader no longer has a transparent background. So if the MainView had a gradient background, the gradient will not show through the header any more, but the header will have a solid background color equalling the color at the top of the MainView.
tests/resources
To post a comment you must log in.
PASSED: Continuous integration, rev:1796 jenkins. qa.ubuntu. com/job/ ubuntu- sdk-team- ubuntu- ui-toolkit- staging- ci/2696/ jenkins. qa.ubuntu. com/job/ ubuntu- sdk-team- ubuntu- ui-toolkit- staging- vivid-amd64- ci/1419 jenkins. qa.ubuntu. com/job/ ubuntu- sdk-team- ubuntu- ui-toolkit- staging- vivid-armhf- ci/1422 jenkins. qa.ubuntu. com/job/ ubuntu- sdk-team- ubuntu- ui-toolkit- staging- vivid-armhf- ci/1422/ artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ ubuntu- sdk-team- ubuntu- ui-toolkit- staging- vivid-i386- ci/1418
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/ubuntu- sdk-team- ubuntu- ui-toolkit- staging- ci/2696/ rebuild
http://