Merge lp:~timkuhlman/charms/trusty/grafana/layer-grafana-http into lp:~canonical-is-sa/charms/trusty/grafana/layer-grafana

Proposed by Tim Kuhlman
Status: Merged
Merged at revision: 36
Proposed branch: lp:~timkuhlman/charms/trusty/grafana/layer-grafana-http
Merge into: lp:~canonical-is-sa/charms/trusty/grafana/layer-grafana
Diff against target: 64 lines (+15/-3)
4 files modified
config.yaml (+6/-1)
layer.yaml (+1/-1)
metadata.yaml (+2/-0)
reactive/grafana.py (+6/-1)
To merge this branch: bzr merge lp:~timkuhlman/charms/trusty/grafana/layer-grafana-http
Reviewer Review Type Date Requested Status
Tom Haddon Approve
Review via email: mp+293458@code.launchpad.net

Description of the change

Added a website relation, specifically so it can be related to the apache charm which will easily add an https + openid frontend.

To post a comment you must log in.
Revision history for this message
Tom Haddon (mthaddon) wrote :

Looks good, merging.

review: Approve
36. By Tom Haddon

[timkuhlman,r=mthaddon] Added a website relation, specifically so it can be related to the apache charm which will easily add an https + openid frontend

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'config.yaml'
--- config.yaml 2016-04-27 16:42:30 +0000
+++ config.yaml 2016-04-29 23:34:37 +0000
@@ -61,8 +61,13 @@
61 type: string61 type: string
62 description: |62 description: |
63 Comma separated list of nagios servicegroups for the graphite check63 Comma separated list of nagios servicegroups for the graphite check
64 port:
65 type: string
66 default: "3000"
67 description: |
68 The port grafana will expose web services on.
64 admin_password:69 admin_password:
65 default:70 default: ""
66 type: string71 type: string
67 description: |72 description: |
68 Grafana admin password. Default, pwgen(16) random password73 Grafana admin password. Default, pwgen(16) random password
6974
=== modified file 'layer.yaml'
--- layer.yaml 2016-04-13 16:43:03 +0000
+++ layer.yaml 2016-04-29 23:34:37 +0000
@@ -1,2 +1,2 @@
1includes: ['layer:basic', 'interface:nrpe-external-master', 'interface:grafana-source']1includes: ['layer:basic', 'interface:nrpe-external-master', 'interface:grafana-source', 'interface:http']
2ignore: ['.*.swp' ]2ignore: ['.*.swp' ]
33
=== modified file 'metadata.yaml'
--- metadata.yaml 2016-04-27 13:46:26 +0000
+++ metadata.yaml 2016-04-29 23:34:37 +0000
@@ -12,6 +12,8 @@
12 nrpe-external-master:12 nrpe-external-master:
13 interface: nrpe-external-master13 interface: nrpe-external-master
14 scope: container14 scope: container
15 website:
16 interface: http
15requires:17requires:
16 grafana-source:18 grafana-source:
17 interface: grafana-source19 interface: grafana-source
1820
=== modified file 'reactive/grafana.py'
--- reactive/grafana.py 2016-04-27 16:42:30 +0000
+++ reactive/grafana.py 2016-04-29 23:34:37 +0000
@@ -77,7 +77,7 @@
77 owner='root', group='grafana',77 owner='root', group='grafana',
78 perms=0o640,78 perms=0o640,
79 )79 )
80 check_ports(config.get('port', '3000'))80 check_ports(config.get('port'))
81 set_state('grafana.start')81 set_state('grafana.start')
82 hookenv.status_set('active', 'Ready')82 hookenv.status_set('active', 'Ready')
8383
@@ -148,6 +148,11 @@
148 pass148 pass
149149
150150
151@when('website.available')
152def configure_website(website):
153 website.configure(port=hookenv.config('port'))
154
155
151def validate_datasources():156def validate_datasources():
152 """TODO: make sure datasources option is merged with157 """TODO: make sure datasources option is merged with
153 relation data158 relation data

Subscribers

People subscribed via source and target branches

to all changes: