Merge lp:~therve/landscape-client/network-plugin-reboot into lp:~landscape/landscape-client/trunk
Proposed by
Thomas Herve
Status: | Merged |
---|---|
Approved by: | Kevin McDermott |
Approved revision: | 287 |
Merged at revision: | 284 |
Proposed branch: | lp:~therve/landscape-client/network-plugin-reboot |
Merge into: | lp:~landscape/landscape-client/trunk |
Diff against target: |
177 lines (+91/-8) 3 files modified
landscape/lib/network.py (+1/-1) landscape/monitor/networkactivity.py (+26/-5) landscape/monitor/tests/test_networkactivity.py (+64/-2) |
To merge this branch: | bzr merge lp:~therve/landscape-client/network-plugin-reboot |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Kevin McDermott (community) | Approve | ||
Jamu Kakar (community) | Approve | ||
Review via email: mp+32755@code.launchpad.net |
Description of the change
The branch handles the rollovers of /proc/net/dev, hopefully.
Restarting was indeed not a problem, because we keep a memory safeguard. I'm still a little bit worried about the persist, but I guess it's fine.
To post a comment you must log in.
[1]
+ self._rolloverunit = pow(2, 64) if is_64() else pow(2, 32)
Please s/_rolloverunit /_rollover_ unit/.
The change seems slightly odd to me, but I guess it's a step up from
what we have, +1!