Unity

Merge lp:~themuso/unity/set-focus-to-false-on-window-deactivation into lp:unity

  1. set-focus-to-false-on-window-deactivation
  2. Merge into trunk
Proposed by Luke Yelavich
Status: Merged
Approved by: Stephen M. Webb
Approved revision: no longer in the source branch.
Merged at revision: 3923
Proposed branch: lp:~themuso/unity/set-focus-to-false-on-window-deactivation
Merge into: lp:unity
Diff against target: 39 lines (+15/-0)
1 file modified
plugins/unityshell/src/nux-area-accessible.cpp (+15/-0)
To merge this branch: bzr merge lp:~themuso/unity/set-focus-to-false-on-window-deactivation
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Unity Team Pending
Review via email: mp+250411@code.launchpad.net

Commit message

Set focus to FALSE on window deactivation

This ensures that dash results can be reviewed with orca and other assistive apps when the dash is opened more than once in a session.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:3922
http://jenkins.qa.ubuntu.com/job/unity-ci/1159/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-vivid-amd64-ci/47
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-vivid-armhf-ci/46
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-vivid-i386-ci/46

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-ci/1159/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'plugins/unityshell/src/nux-area-accessible.cpp'
--- plugins/unityshell/src/nux-area-accessible.cpp 2013-01-09 18:09:10 +0000
+++ plugins/unityshell/src/nux-area-accessible.cpp 2015-02-20 04:53:25 +0000
@@ -88,6 +88,8 @@
88 AtkObject* accessible);88 AtkObject* accessible);
89static void on_parent_window_activate_cb(AtkObject* parent_window,89static void on_parent_window_activate_cb(AtkObject* parent_window,
90 NuxAreaAccessible* self);90 NuxAreaAccessible* self);
91static void on_parent_window_deactivate_cb(AtkObject* parent_window,
92 NuxAreaAccessible* self);
91static AtkObject* search_for_parent_window(AtkObject* object);93static AtkObject* search_for_parent_window(AtkObject* object);
92static gboolean nux_area_accessible_real_check_pending_notification(NuxAreaAccessible* self);94static gboolean nux_area_accessible_real_check_pending_notification(NuxAreaAccessible* self);
93static void check_parent_window_connected(NuxAreaAccessible* self);95static void check_parent_window_connected(NuxAreaAccessible* self);
@@ -427,6 +429,10 @@
427 "activate",429 "activate",
428 G_CALLBACK(on_parent_window_activate_cb),430 G_CALLBACK(on_parent_window_activate_cb),
429 self);431 self);
432 g_signal_connect(self->priv->parent_window,
433 "deactivate",
434 G_CALLBACK(on_parent_window_deactivate_cb),
435 self);
430 }436 }
431}437}
432438
@@ -485,6 +491,15 @@
485 nux_area_accessible_check_pending_notification(self);491 nux_area_accessible_check_pending_notification(self);
486}492}
487493
494static void
495on_parent_window_deactivate_cb(AtkObject* parent_window,
496 NuxAreaAccessible* self)
497{
498 g_return_if_fail(NUX_IS_AREA_ACCESSIBLE(self));
499
500 self->priv->focused = FALSE;
501}
502
488503
489/*504/*
490 * nux_area_check_pending_notification:505 * nux_area_check_pending_notification: