Merge lp:~soren/ubuntu/lucid/puppet/etckeeper-integration into lp:ubuntu/lucid/puppet

Proposed by Mathias Gug
Status: Merged
Merge reported by: Mathias Gug
Merged at revision: not available
Proposed branch: lp:~soren/ubuntu/lucid/puppet/etckeeper-integration
Merge into: lp:ubuntu/lucid/puppet
Diff against target: 81 lines (+42/-0)
5 files modified
debian/changelog (+14/-0)
debian/etckeeper-commit-post (+10/-0)
debian/etckeeper-commit-pre (+10/-0)
debian/puppet.conf (+2/-0)
debian/rules (+6/-0)
To merge this branch: bzr merge lp:~soren/ubuntu/lucid/puppet/etckeeper-integration
Reviewer Review Type Date Requested Status
Mathias Gug Approve
Review via email: mp+19492@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Mathias Gug (mathiaz) wrote :

Accepted. Included in 0.25.4-2ubuntu2.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2010-02-12 17:31:26 +0000
+++ debian/changelog 2010-02-17 15:05:25 +0000
@@ -1,3 +1,17 @@
1puppet (0.25.4-1ubuntu2) UNRELEASED; urgency=low
2
3 * etckeeper integration (server-lucid-puppet-etckeeper-integration):
4 - debian/etckeeper-commit-post, debian/etckeeper-commit-pre:
5 + Call "etckeeper commit" before and after catalog runs.
6 Silently bail out if etckeeper is not available.
7 - debian/puppet.conf:
8 + Call out to the etckeeper hooks using the new prerun_command,
9 and postrun_command hooks.
10 - debian/rules:
11 + Install the etckeeper hook scripts in /etc/puppet.
12
13 -- Soren Hansen <soren@ubuntu.com> Mon, 15 Feb 2010 21:24:54 +0100
14
1puppet (0.25.4-1ubuntu1) lucid; urgency=low15puppet (0.25.4-1ubuntu1) lucid; urgency=low
216
3 * Merge from debian testing. Remaining changes:17 * Merge from debian testing. Remaining changes:
418
=== added file 'debian/etckeeper-commit-post'
--- debian/etckeeper-commit-post 1970-01-01 00:00:00 +0000
+++ debian/etckeeper-commit-post 2010-02-17 15:05:25 +0000
@@ -0,0 +1,10 @@
1#!/bin/sh
2
3PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
4
5which etckeeper > /dev/null 2>&1 || exit 0
6
7etckeeper commit "committing changes in /etc after puppet catalog run"
8
9# Failure of etckeeper should not be fatal.
10exit 0
011
=== added file 'debian/etckeeper-commit-pre'
--- debian/etckeeper-commit-pre 1970-01-01 00:00:00 +0000
+++ debian/etckeeper-commit-pre 2010-02-17 15:05:25 +0000
@@ -0,0 +1,10 @@
1#!/bin/sh
2
3PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
4
5which etckeeper > /dev/null 2>&1 || exit 0
6
7etckeeper commit "saving uncommitted changes in /etc prior to puppet catalog run"
8
9# Failure of etckeeper should not be fatal.
10exit 0
011
=== modified file 'debian/puppet.conf'
--- debian/puppet.conf 2008-03-28 12:38:30 +0000
+++ debian/puppet.conf 2010-02-17 15:05:25 +0000
@@ -5,6 +5,8 @@
5rundir=/var/run/puppet5rundir=/var/run/puppet
6factpath=$vardir/lib/facter6factpath=$vardir/lib/facter
7pluginsync=true7pluginsync=true
8prerun_command=/etc/puppet/etckeeper-commit-pre
9postrun_command=/etc/puppet/etckeeper-commit-post
810
9[puppetmasterd]11[puppetmasterd]
10templatedir=/var/lib/puppet/templates12templatedir=/var/lib/puppet/templates
1113
=== modified file 'debian/rules'
--- debian/rules 2010-02-12 17:31:26 +0000
+++ debian/rules 2010-02-17 15:05:25 +0000
@@ -66,6 +66,12 @@
66 $(INSTALL) -m0644 ext/emacs/puppet-mode.el \66 $(INSTALL) -m0644 ext/emacs/puppet-mode.el \
67 $(CURDIR)/debian/puppet-el/usr/share/emacs/site-lisp/puppet-mode.el67 $(CURDIR)/debian/puppet-el/usr/share/emacs/site-lisp/puppet-mode.el
6868
69 # etckeeper integration
70 $(INSTALL) -m0755 debian/etckeeper-commit-pre \
71 $(CURDIR)/debian/puppet/etc/puppet/etckeeper-commit-pre
72 $(INSTALL) -m0755 debian/etckeeper-commit-post \
73 $(CURDIR)/debian/puppet/etc/puppet/etckeeper-commit-post
74
69 dh_installexamples examples/*75 dh_installexamples examples/*
7076
71 install -d -m0775 $(pkgconfdir)/templates77 install -d -m0775 $(pkgconfdir)/templates

Subscribers

People subscribed via source and target branches

to all changes: