Merge lp:~smspillaz/unity/unity.fix_1036521 into lp:unity

Proposed by Sam Spilsbury
Status: Merged
Merge reported by: Neil J. Patel
Merged at revision: not available
Proposed branch: lp:~smspillaz/unity/unity.fix_1036521
Merge into: lp:unity
Diff against target: 20 lines (+2/-1)
1 file modified
launcher/CairoBaseWindow.cpp (+2/-1)
To merge this branch: bzr merge lp:~smspillaz/unity/unity.fix_1036521
Reviewer Review Type Date Requested Status
Daniel van Vugt Approve
Review via email: mp+125104@code.launchpad.net

Commit message

Don't call GraphicsContext::DeactivateFramebuffer which will immediately restore the backbuffer. Instead call WindowCompositor::RestoreMainFramebuffer to bind either the backbuffer or reference framebuffer for reading as that is the one we're drawing to as is the most-up-to-date

Description of the change

Don't call GraphicsContext::DeactivateFramebuffer which will immediately restore the backbuffer. Instead call WindowCompositor::RestoreMainFramebuffer to bind either the backbuffer or reference framebuffer for reading as that is the one we're drawing to as is the most-up-to-date

No test suite here, the real tested code needs to go in: https://code.launchpad.net/~smspillaz/nux/nux.fix_1036521/+merge/125103

To post a comment you must log in.
Revision history for this message
Daniel van Vugt (vanvugt) wrote :
review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

No commit message specified.

Revision history for this message
Neil J. Patel (njpatel) wrote :

Will resubmit with a remerge of trunk with API fixes.

Revision history for this message
Neil J. Patel (njpatel) wrote :

Manually merged in with fixes. Yay automerge hell.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'launcher/CairoBaseWindow.cpp'
--- launcher/CairoBaseWindow.cpp 2012-05-07 22:28:17 +0000
+++ launcher/CairoBaseWindow.cpp 2012-09-19 06:28:21 +0000
@@ -19,6 +19,7 @@
1919
2020
21#include <Nux/Nux.h>21#include <Nux/Nux.h>
22#include <Nux/WindowCompositor.h>
2223
23#include "unity-shared/CairoTexture.h"24#include "unity-shared/CairoTexture.h"
24#include "CairoBaseWindow.h"25#include "CairoBaseWindow.h"
@@ -58,7 +59,7 @@
58 if (_use_blurred_background && _compute_blur_bkg)59 if (_use_blurred_background && _compute_blur_bkg)
59 {60 {
60 auto current_fbo = nux::GetGraphicsDisplay()->GetGpuDevice()->GetCurrentFrameBufferObject();61 auto current_fbo = nux::GetGraphicsDisplay()->GetGpuDevice()->GetCurrentFrameBufferObject();
61 nux::GetGraphicsDisplay()->GetGpuDevice()->DeactivateFrameBuffer();62 nux::GetWindowCompositor ().RestoreMainFramebuffer();
6263
63 gfxContext.SetViewport(0, 0, gfxContext.GetWindowWidth(), gfxContext.GetWindowHeight());64 gfxContext.SetViewport(0, 0, gfxContext.GetWindowWidth(), gfxContext.GetWindowHeight());
64 gfxContext.SetScissor(0, 0, gfxContext.GetWindowWidth(), gfxContext.GetWindowHeight());65 gfxContext.SetScissor(0, 0, gfxContext.GetWindowWidth(), gfxContext.GetWindowHeight());