Merge lp:~sjakthol/update-manager/fix-for-1031280 into lp:update-manager

Proposed by Sami Jaktholm
Status: Merged
Merged at revision: 2533
Proposed branch: lp:~sjakthol/update-manager/fix-for-1031280
Merge into: lp:update-manager
Diff against target: 21 lines (+2/-2)
1 file modified
UpdateManager/UpdateManager.py (+2/-2)
To merge this branch: bzr merge lp:~sjakthol/update-manager/fix-for-1031280
Reviewer Review Type Date Requested Status
Michael Vogt (community) Approve
Review via email: mp+119249@code.launchpad.net

Description of the change

Fixes bug 1031280 by converting SystemError into string before it's concatenated with the problem description string.

Testcase:
1. Break one of your sources.list entries (e.g. change 'deb http://someurletc...' to 'dab http://someurletc')
2. Open Software Updater
3. Confirm that error dialog appears with description about the issue

Current version in Quantal just crashes without error dialog.

To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'UpdateManager/UpdateManager.py'
--- UpdateManager/UpdateManager.py 2012-07-06 19:25:03 +0000
+++ UpdateManager/UpdateManager.py 2012-08-11 17:29:18 +0000
@@ -260,7 +260,7 @@
260 desc = _("An unresolvable problem occurred while "260 desc = _("An unresolvable problem occurred while "
261 "initializing the package information.\n\n"261 "initializing the package information.\n\n"
262 "Please report this bug against the 'update-manager' "262 "Please report this bug against the 'update-manager' "
263 "package and include the following error message:\n") + e263 "package and include the following error message:\n") + str(e)
264 self.start_error(header, desc)264 self.start_error(header, desc)
265265
266 # Let the Gtk event loop breath if it hasn't had a chance.266 # Let the Gtk event loop breath if it hasn't had a chance.
@@ -275,7 +275,7 @@
275 desc = _("An unresolvable problem occurred while "275 desc = _("An unresolvable problem occurred while "
276 "calculating the upgrade.\n\n"276 "calculating the upgrade.\n\n"
277 "Please report this bug against the 'update-manager' "277 "Please report this bug against the 'update-manager' "
278 "package and include the following error message:\n") + e278 "package and include the following error message:\n") + str(e)
279 self.start_error(header, desc)279 self.start_error(header, desc)
280280
281 self.unity.set_updates_count(self.cache.install_count)281 self.unity.set_updates_count(self.cache.install_count)

Subscribers

People subscribed via source and target branches

to status/vote changes: