Merge lp:~sinzui/launchpad/contact-team into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Brad Crittenden |
Approved revision: | no longer in the source branch. |
Merged at revision: | 14780 |
Proposed branch: | lp:~sinzui/launchpad/contact-team |
Merge into: | lp:launchpad |
Diff against target: |
488 lines (+59/-213) 6 files modified
lib/lp/registry/browser/person.py (+25/-54) lib/lp/registry/browser/tests/person-views.txt (+1/-22) lib/lp/registry/browser/tests/team-views.txt (+2/-2) lib/lp/registry/browser/tests/user-to-user-views.txt (+20/-116) lib/lp/registry/stories/team/xx-team-home.txt (+10/-18) lib/lp/registry/templates/contact-user.pt (+1/-1) |
To merge this branch: | bzr merge lp:~sinzui/launchpad/contact-team |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brad Crittenden (community) | code | Approve | |
Review via email: mp+92589@code.launchpad.net |
Commit message
[r=bac][bug=246022] Allow team members to contact all the team members, non-members contact the team admins.
Description of the change
Allow team members to contact all the team members, non-members contact the
team admins.
Launchpad bug: https:/
Pre-
A team administrator cannot contact all members at once if, for example,
the contact address for the team is a mailing list, and not all members
are subscribed to it.
This issues has mutated over the years. When bug mail was out of control,
we decided to honour a team's choice to set a contact address to send
all email to a black hole. Bug mail is no longer an issue. When a member
choose the contact-this-team form, Launchpad will send email to all members
so that important messages can be sent. contact-this-team is still not
substitute for mailing lists because we limit its use to 3 time a day.
While discussing the rules recently, we discovered that we did not update
contact-this-team to contact team admins instead of the owner. We allow
the owner to leave the team, delegating all responsibility to the admins.
-------
RULES
* Delete the rules for when the team has a contact address, allowing
the team member rules to be the only rule in play.
* Change the contact owner rule to contact admins.
* ADDENDUM: I cannot 'hit' the cancel link. I do not think the cancel
is a verb and suffices.
QA
* Visit https:/
* Set the contact address to the mailing list.
* Choose contact this team's members.
* Verify the page says
You are contacting nn members of the Registry Administrators (registry)
team directly.
* Verify the page says
If you do not want Registry Administrators to know your email address,
_cancel_ now.
* Visit https:/
team you are not a member of)
* Choose contact this team's admins.
* Verify the page says
You are contacting the Bazaar Developers (bzr) team admins.
LINT
lib/
lib/
lib/
lib/
lib/
lib/
TEST
./bin/test -vcc -t user-to-user-views -t person-views -t team-views \
-t xx-team-home lp.registry
IMPLEMENTATION
Removed the TO_TEAM state of ContactViaWebNo
all callsites that accessed it, deleted tests that check that the team
email address was contacted.
Renamed TO_OWNER to TO_ADMINS and revised the descriptive test. Updated
tests to verify team admins are contacted. Replaced
_getPrimaryReci
tests pass). While there was no method that returned person and email
address, my implementation uses the get_recipients helper that caches
the user/team email addresses.
This code looks good Curtis and is a welcome improvement.