Merge lp:~sileht/testscenarios/testscenarios into lp:~testtools-committers/testscenarios/trunk

Proposed by Mehdi Abaakouk
Status: Work in progress
Proposed branch: lp:~sileht/testscenarios/testscenarios
Merge into: lp:~testtools-committers/testscenarios/trunk
Diff against target: 10 lines (+2/-0)
1 file modified
lib/testscenarios/scenarios.py (+2/-0)
To merge this branch: bzr merge lp:~sileht/testscenarios/testscenarios
Reviewer Review Type Date Requested Status
Robert Collins Needs Information
Review via email: mp+211038@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Apart from pointless whitespace changes, this looks good to me

22. By Mehdi Abaakouk

Allow use scenario with nose

This patch informs nose that test generated and orignal test are the same.

Closes bug: #872887

Revision history for this message
Mehdi Abaakouk (sileht) wrote :

I have cleaned the commit.

Revision history for this message
Victor Stinner (vstinner) wrote :

What is the status of this issue? I still need it for a patch on OpenStack Oslo Incubator:
https://review.openstack.org/#/c/80534/2/tests/unit/test_gettext.py

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Any of the people listed here can commit this: https://launchpad.net/~testtools-committers (I cannot)

Revision history for this message
Chmouel Boudjnah (chmouel) wrote :

I'd love to have that!

Revision history for this message
Robert Collins (lifeless) wrote :

What does this do precisely? The idea that they are the same test case seems wrong, since they *were* but are *no longer* identical.

review: Needs Information
Revision history for this message
Robert Collins (lifeless) wrote :

This still needs the question asked answered

Revision history for this message
Robert Collins (lifeless) wrote :

Also the source for testscenarios is now ongithub, please submit a PR there.

Unmerged revisions

22. By Mehdi Abaakouk

Allow use scenario with nose

This patch informs nose that test generated and orignal test are the same.

Closes bug: #872887

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/testscenarios/scenarios.py'
--- lib/testscenarios/scenarios.py 2012-04-04 10:02:46 +0000
+++ lib/testscenarios/scenarios.py 2014-03-14 14:18:40 +0000
@@ -52,6 +52,8 @@
52 newtest.shortDescription = (lambda: newtest_desc)52 newtest.shortDescription = (lambda: newtest_desc)
53 for key, value in parameters.iteritems():53 for key, value in parameters.iteritems():
54 setattr(newtest, key, value)54 setattr(newtest, key, value)
55 # Tell nose that test and newtest are the same testcase
56 setattr(test, '_nose_case', newtest)
55 return newtest57 return newtest
5658
5759

Subscribers

People subscribed via source and target branches