Merge lp:~sil2100/notify-osd/packaging_review into lp:notify-osd

Proposed by Łukasz Zemczak
Status: Merged
Approved by: Allan LeSage
Approved revision: 462
Merged at revision: 462
Proposed branch: lp:~sil2100/notify-osd/packaging_review
Merge into: lp:notify-osd
Diff against target: 150 lines (+57/-57)
4 files modified
debian/changelog (+7/-0)
debian/control (+10/-8)
debian/copyright (+38/-49)
debian/rules (+2/-0)
To merge this branch: bzr merge lp:~sil2100/notify-osd/packaging_review
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Ken VanDine Approve
Review via email: mp+161949@code.launchpad.net

Commit message

Modifications related to compliance with our packaging standards

Description of the change

Packaging review. Modifications related to compliance with our packaging standards

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:462
http://jenkins.qa.ubuntu.com/job/notify-osd-ci/1/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-coverity-check/15/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notify-osd-raring-amd64-ci/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notify-osd-raring-armhf-ci/1
Coverity artifacts:
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/15/artifact/results/coverity/CID_10486.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/15/artifact/results/coverity/CID_10487.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/15/artifact/results/coverity/CID_10488.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/15/artifact/results/coverity/CID_10690.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/15/artifact/results/coverity/CID_10691.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/15/artifact/results/coverity/CID_10692.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/15/artifact/results/coverity/CID_10693.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/15/artifact/results/coverity/CID_10694.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/15/artifact/results/coverity/CID_10932.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/15/artifact/results/coverity/CID_10933.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/15/artifact/results/coverity/CID_10934.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/15/artifact/results/coverity/CID_10935.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/15/artifact/results/coverity/CID_10936.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/15/artifact/results/coverity/CID_10937.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/15/artifact/results/coverity/CID_10938.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/15/artifact/results/coverity/CID_10939.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/15/artifact/results/coverity/CID_10940.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/15/artifact/results/coverity/CID_10941.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/15/artifact/results/coverity/CID_13648.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/15/artifact/results/coverity/CID_13649.html

Click here to trigger a rebuild:
http://s-jenkins:8080/job/notify-osd-ci/1/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ken VanDine (ken-vandine) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/notify-osd-autolanding/1/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-coverity-check/19/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notify-osd-raring-amd64-autolanding/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notify-osd-raring-armhf-autolanding/1
Coverity artifacts:
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/19/artifact/results/coverity/CID_10486.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/19/artifact/results/coverity/CID_10487.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/19/artifact/results/coverity/CID_10488.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/19/artifact/results/coverity/CID_10690.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/19/artifact/results/coverity/CID_10691.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/19/artifact/results/coverity/CID_10692.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/19/artifact/results/coverity/CID_10693.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/19/artifact/results/coverity/CID_10694.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/19/artifact/results/coverity/CID_10932.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/19/artifact/results/coverity/CID_10933.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/19/artifact/results/coverity/CID_10934.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/19/artifact/results/coverity/CID_10935.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/19/artifact/results/coverity/CID_10936.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/19/artifact/results/coverity/CID_10937.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/19/artifact/results/coverity/CID_10938.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/19/artifact/results/coverity/CID_10939.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/19/artifact/results/coverity/CID_10940.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/19/artifact/results/coverity/CID_10941.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/19/artifact/results/coverity/CID_13648.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/19/artifact/results/coverity/CID_13649.html

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/notify-osd-autolanding/2/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-coverity-check/20/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notify-osd-raring-amd64-autolanding/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notify-osd-raring-armhf-autolanding/2
Coverity artifacts:
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/20/artifact/results/coverity/CID_10486.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/20/artifact/results/coverity/CID_10487.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/20/artifact/results/coverity/CID_10488.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/20/artifact/results/coverity/CID_10690.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/20/artifact/results/coverity/CID_10691.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/20/artifact/results/coverity/CID_10692.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/20/artifact/results/coverity/CID_10693.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/20/artifact/results/coverity/CID_10694.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/20/artifact/results/coverity/CID_10932.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/20/artifact/results/coverity/CID_10933.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/20/artifact/results/coverity/CID_10934.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/20/artifact/results/coverity/CID_10935.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/20/artifact/results/coverity/CID_10936.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/20/artifact/results/coverity/CID_10937.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/20/artifact/results/coverity/CID_10938.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/20/artifact/results/coverity/CID_10939.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/20/artifact/results/coverity/CID_10940.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/20/artifact/results/coverity/CID_10941.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/20/artifact/results/coverity/CID_13648.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/20/artifact/results/coverity/CID_13649.html

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
Approved revid is not set in launchpad (maybe a permission problem?).
http://jenkins.qa.ubuntu.com/job/notify-osd-autolanding/4/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notify-osd-raring-amd64-autolanding/4
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notify-osd-raring-armhf-autolanding/4

review: Needs Fixing (continuous-integration)
Revision history for this message
Allan LeSage (allanlesage) wrote :

I'm monitoring this, sorry for the mess :) .

Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2012-11-28 06:30:40 +0000
+++ debian/changelog 2013-05-01 21:18:25 +0000
@@ -1,3 +1,10 @@
1notify-osd (0.9.35daily12.11.28-0ubuntu2) UNRELEASED; urgency=low
2
3 * debian/control, debian/copyright, debian/rules:
4 - Modifications related to compliance with our packaging standards
5
6 -- Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com> Wed, 01 May 2013 22:57:49 +0200
7
1notify-osd (0.9.35daily12.11.28-0ubuntu1) raring; urgency=low8notify-osd (0.9.35daily12.11.28-0ubuntu1) raring; urgency=low
29
3 [ Robert Bruce Park ]10 [ Robert Bruce Park ]
411
=== modified file 'debian/control'
--- debian/control 2012-11-26 20:17:09 +0000
+++ debian/control 2013-05-01 21:18:25 +0000
@@ -15,18 +15,20 @@
15XS-Testsuite: autopkgtest15XS-Testsuite: autopkgtest
16Standards-Version: 3.9.216Standards-Version: 3.9.2
17Homepage: https://launchpad.net/notify-osd17Homepage: https://launchpad.net/notify-osd
18# If you aren't a member of ~canonical-dx-team but need to upload packaging changes,18# If you aren't a member of ~indicator-applet-developers but need to upload
19# just go ahead. ~canonical-dx-team will notice and sync up the code again.19# packaging changes, just go ahead. ~indicator-applet-developers will notice
20Vcs-Bzr: https://code.launchpad.net/~canonical-dx-team/notify-osd/precise20# and sync up the code again.
21Vcs-Bzr: https://code.launchpad.net/~indicator-applet-developers/notify-osd/trunk
22Vcs-Browser: https://bazaar.launchpad.net/~indicator-applet-developers/notify-osd/trunk/files
2123
22Package: notify-osd24Package: notify-osd
23Architecture: any25Architecture: any
24Depends: ${misc:Depends},26Depends: gsettings-desktop-schemas,
27 ${misc:Depends},
25 ${shlibs:Depends},28 ${shlibs:Depends},
26 gsettings-desktop-schemas,29Recommends: notify-osd-icons,
27Recommends: notify-osd-icons30Provides: notification-daemon,
28Provides: notification-daemon31Replaces: notification-daemon,
29Replaces: notification-daemon
30Description: daemon that displays passive pop-up notifications32Description: daemon that displays passive pop-up notifications
31 The Desktop Notifications framework provides a standard way of doing33 The Desktop Notifications framework provides a standard way of doing
32 passive pop-up notifications on the Linux desktop. These are34 passive pop-up notifications on the Linux desktop. These are
3335
=== modified file 'debian/copyright'
--- debian/copyright 2012-11-22 21:11:36 +0000
+++ debian/copyright 2013-05-01 21:18:25 +0000
@@ -1,49 +1,38 @@
1This package was debianized by David Barth <david.barth@canonical.com> on1Format: http://dep.debian.net/deps/dep5/
2Wed Dec 3 18:04:59 PST 20082Upstream-Name: notify-osd
33Upstream-Contact: Mirco Mueller <mirco.mueller@canonical.com>
4It was downloaded from https://launchpad.net/notify-osd4Source: https://launchpad.net/notify-osd
55
6Copyright (C) Canonical, Oct. 20086Files: *
77Copyright: 2011 Canonical Ltd
8egg/* is Copyright (C) 2006, 2007 OpenedHand8License: GPL-3.0
99 This program is free software: you can redistribute it and/or modify
10License:10 it under the terms of the GNU General Public License as published by
1111 the Free Software Foundation, version 3 of the License.
12 This program is free software; you can redistribute it and/or modify12 .
13 it under the terms of the GNU General Public License as published by13 This package is distributed in the hope that it will be useful,
14 the Free Software Foundation, version 3 of the License.14 but WITHOUT ANY WARRANTY; without even the implied warranty of
1515 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 This program is distributed in the hope that it will be useful,16 GNU General Public License for more details.
17 but WITHOUT ANY WARRANTY; without even the implied warranty of17 .
18 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the18 You should have received a copy of the GNU General Public License
19 GNU General Public License for more details.19 along with this program. If not, see <http://www.gnu.org/licenses/>.
2020 .
21 You should have received a copy of the GNU General Public License21 On Debian systems, the complete text of the GNU General
22 along with this program; if not, write to the Free Software22 Public License version 3 can be found in "/usr/share/common-licenses/GPL-3".
23 Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA23
2424Files: egg/*
25On Debian systems, the complete text of the GNU General25Copyright: 2006, 2007 OpenedHand
26Public License can be found in `/usr/share/common-licenses/GPL-3'.26License: LGPL-2+
2727 This library is free software; you can redistribute it and/or
28License for egg/*:28 modify it under the terms of the GNU Lesser General Public
2929 License as published by the Free Software Foundation; either
30 This library is free software; you can redistribute it and/or30 version 2 of the License, or (at your option) any later version.
31 modify it under the terms of the GNU Lesser General Public31 .
32 License as published by the Free Software Foundation; either32 This library is distributed in the hope that it will be useful,
33 version 2 of the License, or (at your option) any later version.33 but WITHOUT ANY WARRANTY; without even the implied warranty of
3434 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
35 This library is distributed in the hope that it will be useful,35 Lesser General Public License for more details.
36 but WITHOUT ANY WARRANTY; without even the implied warranty of36 .
37 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU37 On Debian systems, the complete text of the GNU Lesser General Public
38 Lesser General Public License for more details.38 Licence can be found in `/usr/share/common-licenses/LGPL-2'
39
40 You should have received a copy of the GNU Library General Public
41 License along with this library; if not, write to the Free Software
42 Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA
43 02110-1301 USA
44
45On Debian systems, the complete text of the GNU Lesser General
46Public License can be found in `/usr/share/common-licenses/LGPL-2'.
47
48The Debian packaging is (C) 2009, Canonical Ltd. and
49is licensed under the GPLv3, see `/usr/share/common-licenses/GPL-3'.
5039
=== modified file 'debian/rules'
--- debian/rules 2012-11-26 20:17:09 +0000
+++ debian/rules 2013-05-01 21:18:25 +0000
@@ -1,5 +1,7 @@
1#!/usr/bin/make -f1#!/usr/bin/make -f
22
3export DPKG_GENSYMBOLS_CHECK_LEVEL=4
4
3%:5%:
4 dh $@ --with autoreconf6 dh $@ --with autoreconf
57

Subscribers

People subscribed via source and target branches