Merge lp:~sil2100/notify-osd/packaging_review into lp:notify-osd
- packaging_review
- Merge into trunk
Status: | Merged |
---|---|
Approved by: | Allan LeSage |
Approved revision: | 462 |
Merged at revision: | 462 |
Proposed branch: | lp:~sil2100/notify-osd/packaging_review |
Merge into: | lp:notify-osd |
Diff against target: |
150 lines (+57/-57) 4 files modified
debian/changelog (+7/-0) debian/control (+10/-8) debian/copyright (+38/-49) debian/rules (+2/-0) |
To merge this branch: | bzr merge lp:~sil2100/notify-osd/packaging_review |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Approve | |
Ken VanDine | Approve | ||
Review via email: mp+161949@code.launchpad.net |
Commit message
Modifications related to compliance with our packaging standards
Description of the change
Packaging review. Modifications related to compliance with our packaging standards
PS Jenkins bot (ps-jenkins) wrote : | # |
Ken VanDine (ken-vandine) : | # |
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Autolanding.
More details in the following jenkins job:
http://
Executed test runs:
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
Coverity artifacts:
http://
http://
http://
http://
http://
http://
http://
http://
http://
http://
http://
http://
http://
http://
http://
http://
http://
http://
http://
http://
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Autolanding.
More details in the following jenkins job:
http://
Executed test runs:
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
Coverity artifacts:
http://
http://
http://
http://
http://
http://
http://
http://
http://
http://
http://
http://
http://
http://
http://
http://
http://
http://
http://
http://
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Autolanding.
More details in the following jenkins job:
http://
Executed test runs:
SUCCESS: http://
None: http://
PS Jenkins bot (ps-jenkins) : | # |
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Autolanding.
Approved revid is not set in launchpad (maybe a permission problem?).
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
Allan LeSage (allanlesage) wrote : | # |
I'm monitoring this, sorry for the mess :) .
PS Jenkins bot (ps-jenkins) : | # |
Preview Diff
1 | === modified file 'debian/changelog' | |||
2 | --- debian/changelog 2012-11-28 06:30:40 +0000 | |||
3 | +++ debian/changelog 2013-05-01 21:18:25 +0000 | |||
4 | @@ -1,3 +1,10 @@ | |||
5 | 1 | notify-osd (0.9.35daily12.11.28-0ubuntu2) UNRELEASED; urgency=low | ||
6 | 2 | |||
7 | 3 | * debian/control, debian/copyright, debian/rules: | ||
8 | 4 | - Modifications related to compliance with our packaging standards | ||
9 | 5 | |||
10 | 6 | -- Łukasz 'sil2100' Zemczak <lukasz.zemczak@canonical.com> Wed, 01 May 2013 22:57:49 +0200 | ||
11 | 7 | |||
12 | 1 | notify-osd (0.9.35daily12.11.28-0ubuntu1) raring; urgency=low | 8 | notify-osd (0.9.35daily12.11.28-0ubuntu1) raring; urgency=low |
13 | 2 | 9 | ||
14 | 3 | [ Robert Bruce Park ] | 10 | [ Robert Bruce Park ] |
15 | 4 | 11 | ||
16 | === modified file 'debian/control' | |||
17 | --- debian/control 2012-11-26 20:17:09 +0000 | |||
18 | +++ debian/control 2013-05-01 21:18:25 +0000 | |||
19 | @@ -15,18 +15,20 @@ | |||
20 | 15 | XS-Testsuite: autopkgtest | 15 | XS-Testsuite: autopkgtest |
21 | 16 | Standards-Version: 3.9.2 | 16 | Standards-Version: 3.9.2 |
22 | 17 | Homepage: https://launchpad.net/notify-osd | 17 | Homepage: https://launchpad.net/notify-osd |
26 | 18 | # If you aren't a member of ~canonical-dx-team but need to upload packaging changes, | 18 | # If you aren't a member of ~indicator-applet-developers but need to upload |
27 | 19 | # just go ahead. ~canonical-dx-team will notice and sync up the code again. | 19 | # packaging changes, just go ahead. ~indicator-applet-developers will notice |
28 | 20 | Vcs-Bzr: https://code.launchpad.net/~canonical-dx-team/notify-osd/precise | 20 | # and sync up the code again. |
29 | 21 | Vcs-Bzr: https://code.launchpad.net/~indicator-applet-developers/notify-osd/trunk | ||
30 | 22 | Vcs-Browser: https://bazaar.launchpad.net/~indicator-applet-developers/notify-osd/trunk/files | ||
31 | 21 | 23 | ||
32 | 22 | Package: notify-osd | 24 | Package: notify-osd |
33 | 23 | Architecture: any | 25 | Architecture: any |
35 | 24 | Depends: ${misc:Depends}, | 26 | Depends: gsettings-desktop-schemas, |
36 | 27 | ${misc:Depends}, | ||
37 | 25 | ${shlibs:Depends}, | 28 | ${shlibs:Depends}, |
42 | 26 | gsettings-desktop-schemas, | 29 | Recommends: notify-osd-icons, |
43 | 27 | Recommends: notify-osd-icons | 30 | Provides: notification-daemon, |
44 | 28 | Provides: notification-daemon | 31 | Replaces: notification-daemon, |
41 | 29 | Replaces: notification-daemon | ||
45 | 30 | Description: daemon that displays passive pop-up notifications | 32 | Description: daemon that displays passive pop-up notifications |
46 | 31 | The Desktop Notifications framework provides a standard way of doing | 33 | The Desktop Notifications framework provides a standard way of doing |
47 | 32 | passive pop-up notifications on the Linux desktop. These are | 34 | passive pop-up notifications on the Linux desktop. These are |
48 | 33 | 35 | ||
49 | === modified file 'debian/copyright' | |||
50 | --- debian/copyright 2012-11-22 21:11:36 +0000 | |||
51 | +++ debian/copyright 2013-05-01 21:18:25 +0000 | |||
52 | @@ -1,49 +1,38 @@ | |||
102 | 1 | This package was debianized by David Barth <david.barth@canonical.com> on | 1 | Format: http://dep.debian.net/deps/dep5/ |
103 | 2 | Wed Dec 3 18:04:59 PST 2008 | 2 | Upstream-Name: notify-osd |
104 | 3 | 3 | Upstream-Contact: Mirco Mueller <mirco.mueller@canonical.com> | |
105 | 4 | It was downloaded from https://launchpad.net/notify-osd | 4 | Source: https://launchpad.net/notify-osd |
106 | 5 | 5 | ||
107 | 6 | Copyright (C) Canonical, Oct. 2008 | 6 | Files: * |
108 | 7 | 7 | Copyright: 2011 Canonical Ltd | |
109 | 8 | egg/* is Copyright (C) 2006, 2007 OpenedHand | 8 | License: GPL-3.0 |
110 | 9 | 9 | This program is free software: you can redistribute it and/or modify | |
111 | 10 | License: | 10 | it under the terms of the GNU General Public License as published by |
112 | 11 | 11 | the Free Software Foundation, version 3 of the License. | |
113 | 12 | This program is free software; you can redistribute it and/or modify | 12 | . |
114 | 13 | it under the terms of the GNU General Public License as published by | 13 | This package is distributed in the hope that it will be useful, |
115 | 14 | the Free Software Foundation, version 3 of the License. | 14 | but WITHOUT ANY WARRANTY; without even the implied warranty of |
116 | 15 | 15 | MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | |
117 | 16 | This program is distributed in the hope that it will be useful, | 16 | GNU General Public License for more details. |
118 | 17 | but WITHOUT ANY WARRANTY; without even the implied warranty of | 17 | . |
119 | 18 | MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | 18 | You should have received a copy of the GNU General Public License |
120 | 19 | GNU General Public License for more details. | 19 | along with this program. If not, see <http://www.gnu.org/licenses/>. |
121 | 20 | 20 | . | |
122 | 21 | You should have received a copy of the GNU General Public License | 21 | On Debian systems, the complete text of the GNU General |
123 | 22 | along with this program; if not, write to the Free Software | 22 | Public License version 3 can be found in "/usr/share/common-licenses/GPL-3". |
124 | 23 | Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA | 23 | |
125 | 24 | 24 | Files: egg/* | |
126 | 25 | On Debian systems, the complete text of the GNU General | 25 | Copyright: 2006, 2007 OpenedHand |
127 | 26 | Public License can be found in `/usr/share/common-licenses/GPL-3'. | 26 | License: LGPL-2+ |
128 | 27 | 27 | This library is free software; you can redistribute it and/or | |
129 | 28 | License for egg/*: | 28 | modify it under the terms of the GNU Lesser General Public |
130 | 29 | 29 | License as published by the Free Software Foundation; either | |
131 | 30 | This library is free software; you can redistribute it and/or | 30 | version 2 of the License, or (at your option) any later version. |
132 | 31 | modify it under the terms of the GNU Lesser General Public | 31 | . |
133 | 32 | License as published by the Free Software Foundation; either | 32 | This library is distributed in the hope that it will be useful, |
134 | 33 | version 2 of the License, or (at your option) any later version. | 33 | but WITHOUT ANY WARRANTY; without even the implied warranty of |
135 | 34 | 34 | MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | |
136 | 35 | This library is distributed in the hope that it will be useful, | 35 | Lesser General Public License for more details. |
137 | 36 | but WITHOUT ANY WARRANTY; without even the implied warranty of | 36 | . |
138 | 37 | MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | 37 | On Debian systems, the complete text of the GNU Lesser General Public |
139 | 38 | Lesser General Public License for more details. | 38 | Licence can be found in `/usr/share/common-licenses/LGPL-2' |
91 | 39 | |||
92 | 40 | You should have received a copy of the GNU Library General Public | ||
93 | 41 | License along with this library; if not, write to the Free Software | ||
94 | 42 | Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA | ||
95 | 43 | 02110-1301 USA | ||
96 | 44 | |||
97 | 45 | On Debian systems, the complete text of the GNU Lesser General | ||
98 | 46 | Public License can be found in `/usr/share/common-licenses/LGPL-2'. | ||
99 | 47 | |||
100 | 48 | The Debian packaging is (C) 2009, Canonical Ltd. and | ||
101 | 49 | is licensed under the GPLv3, see `/usr/share/common-licenses/GPL-3'. | ||
140 | 50 | 39 | ||
141 | === modified file 'debian/rules' | |||
142 | --- debian/rules 2012-11-26 20:17:09 +0000 | |||
143 | +++ debian/rules 2013-05-01 21:18:25 +0000 | |||
144 | @@ -1,5 +1,7 @@ | |||
145 | 1 | #!/usr/bin/make -f | 1 | #!/usr/bin/make -f |
146 | 2 | 2 | ||
147 | 3 | export DPKG_GENSYMBOLS_CHECK_LEVEL=4 | ||
148 | 4 | |||
149 | 3 | %: | 5 | %: |
150 | 4 | dh $@ --with autoreconf | 6 | dh $@ --with autoreconf |
151 | 5 | 7 |
FAILED: Continuous integration, rev:462 jenkins. qa.ubuntu. com/job/ notify- osd-ci/ 1/ jenkins. qa.ubuntu. com/job/ generic- coverity- check/15/ console jenkins. qa.ubuntu. com/job/ notify- osd-raring- amd64-ci/ 1 jenkins. qa.ubuntu. com/job/ notify- osd-raring- armhf-ci/ 1 jenkins. qa.ubuntu. com/job/ generic- coverity- check/15/ artifact/ results/ coverity/ CID_10486. html jenkins. qa.ubuntu. com/job/ generic- coverity- check/15/ artifact/ results/ coverity/ CID_10487. html jenkins. qa.ubuntu. com/job/ generic- coverity- check/15/ artifact/ results/ coverity/ CID_10488. html jenkins. qa.ubuntu. com/job/ generic- coverity- check/15/ artifact/ results/ coverity/ CID_10690. html jenkins. qa.ubuntu. com/job/ generic- coverity- check/15/ artifact/ results/ coverity/ CID_10691. html jenkins. qa.ubuntu. com/job/ generic- coverity- check/15/ artifact/ results/ coverity/ CID_10692. html jenkins. qa.ubuntu. com/job/ generic- coverity- check/15/ artifact/ results/ coverity/ CID_10693. html jenkins. qa.ubuntu. com/job/ generic- coverity- check/15/ artifact/ results/ coverity/ CID_10694. html jenkins. qa.ubuntu. com/job/ generic- coverity- check/15/ artifact/ results/ coverity/ CID_10932. html jenkins. qa.ubuntu. com/job/ generic- coverity- check/15/ artifact/ results/ coverity/ CID_10933. html jenkins. qa.ubuntu. com/job/ generic- coverity- check/15/ artifact/ results/ coverity/ CID_10934. html jenkins. qa.ubuntu. com/job/ generic- coverity- check/15/ artifact/ results/ coverity/ CID_10935. html jenkins. qa.ubuntu. com/job/ generic- coverity- check/15/ artifact/ results/ coverity/ CID_10936. html jenkins. qa.ubuntu. com/job/ generic- coverity- check/15/ artifact/ results/ coverity/ CID_10937. html jenkins. qa.ubuntu. com/job/ generic- coverity- check/15/ artifact/ results/ coverity/ CID_10938. html jenkins. qa.ubuntu. com/job/ generic- coverity- check/15/ artifact/ results/ coverity/ CID_10939. html jenkins. qa.ubuntu. com/job/ generic- coverity- check/15/ artifact/ results/ coverity/ CID_10940. html jenkins. qa.ubuntu. com/job/ generic- coverity- check/15/ artifact/ results/ coverity/ CID_10941. html jenkins. qa.ubuntu. com/job/ generic- coverity- check/15/ artifact/ results/ coverity/ CID_13648. html jenkins. qa.ubuntu. com/job/ generic- coverity- check/15/ artifact/ results/ coverity/ CID_13649. html
http://
Executed test runs:
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
Coverity artifacts:
http://
http://
http://
http://
http://
http://
http://
http://
http://
http://
http://
http://
http://
http://
http://
http://
http://
http://
http://
http://
Click here to trigger a rebuild: s-jenkins: 8080/job/ notify- osd-ci/ 1/rebuild
http://