Merge lp:~sil2100/appmenu-qt/disable_qt5 into lp:appmenu-qt

Proposed by Łukasz Zemczak
Status: Merged
Approved by: Timo Jyrinki
Approved revision: 59
Merged at revision: 59
Proposed branch: lp:~sil2100/appmenu-qt/disable_qt5
Merge into: lp:appmenu-qt
Diff against target: 78 lines (+3/-39)
2 files modified
debian/control (+2/-19)
debian/rules (+1/-20)
To merge this branch: bzr merge lp:~sil2100/appmenu-qt/disable_qt5
Reviewer Review Type Date Requested Status
Timo Jyrinki Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+201931@code.launchpad.net

Commit message

Remove the appmenu-qt5 packages - those are now built using the new appmenu-qt5 sources, using QPA and upstream Qt5 approaches to global menus

Description of the change

Remove the appmenu-qt5 packages - those are now built using the new appmenu-qt5 sources, using QPA and upstream Qt5 approaches to global menus

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Looks good, and the new appmenu-qt5 builds already.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/control'
--- debian/control 2013-05-02 15:24:55 +0000
+++ debian/control 2014-01-16 14:06:21 +0000
@@ -1,17 +1,15 @@
1Source: appmenu-qt1Source: appmenu-qt
2Section: kde2Section: kde
3Priority: extra3Priority: optional
4Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>4Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
5XSBC-Original-Maintainer: Debian KDE Extras Team <pkg-kde-extras@lists.alioth.debian.org>5XSBC-Original-Maintainer: Debian KDE Extras Team <pkg-kde-extras@lists.alioth.debian.org>
6Uploaders: Ritesh Raj Sarraf <rrs@debian.org>,6Uploaders: Ritesh Raj Sarraf <rrs@debian.org>,
7Build-Depends: cmake,7Build-Depends: cmake,
8 debhelper (>= 9),8 debhelper (>= 9),
9 libdbusmenu-qt-dev,9 libdbusmenu-qt-dev,
10 libdbusmenu-qt5-dev,
11 libqt4-dev (>= 4:4.8),10 libqt4-dev (>= 4:4.8),
12 pkg-config,11 pkg-config,
13 qtbase5-dev (>= 5.0.1+dfsg-0ubuntu4~),12Standards-Version: 3.9.5
14Standards-Version: 3.9.3
15Homepage: https://launchpad.net/appmenu-qt13Homepage: https://launchpad.net/appmenu-qt
16# If you aren't ~indicator-applet-developers but need to upload packaging changes,14# If you aren't ~indicator-applet-developers but need to upload packaging changes,
17# just go ahead. ~indicator-applet-developers will notice and sync up the code again.15# just go ahead. ~indicator-applet-developers will notice and sync up the code again.
@@ -27,18 +25,3 @@
27 global menu bar25 global menu bar
28 .26 .
29 appmenu-qt will work for applications designed for Qt and KDE27 appmenu-qt will work for applications designed for Qt and KDE
30
31Package: appmenu-qt5
32Architecture: any
33Depends: ${misc:Depends},
34 ${shlibs:Depends},
35Suggests: libqt5core5,
36 libqt5dbus5,
37 libqt5gui5,
38 libqt5widgets5,
39Description: application menu for Qt5
40 appmenu provides you with an integrated application menu in your
41 global menu bar
42 .
43 appmenu-qt5 will work for applications designed for Qt and KDE
44 This is the Qt5 version
4528
=== modified file 'debian/rules'
--- debian/rules 2013-03-28 14:26:55 +0000
+++ debian/rules 2014-01-16 14:06:21 +0000
@@ -8,18 +8,7 @@
8 dh $@8 dh $@
99
10override_dh_auto_configure:10override_dh_auto_configure:
11 mkdir qt411 QT_SELECT=qt4 cmake -DUSE_QT4=true
12 mkdir qt5
13 cd qt4 && QT_SELECT=qt4 cmake -DUSE_QT4=true ../
14 cd qt5 && QT_SELECT=qt5 cmake -DUSE_QT5=true ../
15
16override_dh_auto_build:
17 cd qt4 && make
18 cd qt5 && make
19
20override_dh_auto_install:
21 cd qt4 && make DESTDIR=../debian/appmenu-qt install
22 cd qt5 && make DESTDIR=../debian/appmenu-qt5 install
2312
24override_dh_installchangelogs:13override_dh_installchangelogs:
25 dh_installchangelogs NEWS14 dh_installchangelogs NEWS
@@ -29,11 +18,3 @@
2918
30override_dh_install:19override_dh_install:
31 dh_install --fail-missing20 dh_install --fail-missing
32
33override_dh_gencontrol:
34 # Ugly hack, since we don't want to have Qt5 as our depends, we prefer
35 # those as Suggests for now
36 sed -i '/^shlibs/s/libqt5[^,]*, //g' debian/appmenu-qt5.substvars
37 sed -i '/^shlibs/s/,[^,]* libqt5.*$$//' debian/appmenu-qt5.substvars
38
39 dh_gencontrol

Subscribers

People subscribed via source and target branches