Merge lp:~sergiusens/ubuntu-qtcreator-plugins/phablet-flash-new-syntax into lp:ubuntu-qtcreator-plugins

Proposed by Sergio Schvezov
Status: Needs review
Proposed branch: lp:~sergiusens/ubuntu-qtcreator-plugins/phablet-flash-new-syntax
Merge into: lp:ubuntu-qtcreator-plugins
Diff against target: 53 lines (+15/-4)
3 files modified
ubuntu-qtcreator-plugins-common/share/qtcreator/ubuntu/scripts/device_flashdaily (+5/-2)
ubuntu-qtcreator-plugins-common/share/qtcreator/ubuntu/scripts/device_flashdaily_bootstrap (+4/-2)
ubuntu-qtcreator-plugins-common/share/qtcreator/ubuntu/scripts/functions.inc (+6/-0)
To merge this branch: bzr merge lp:~sergiusens/ubuntu-qtcreator-plugins/phablet-flash-new-syntax
Reviewer Review Type Date Requested Status
Ubuntu SDK team Pending
Review via email: mp+179317@code.launchpad.net

Commit message

Contemplating phablet-flash's new syntax

Description of the change

This is to take into account:
https://code.launchpad.net/~sergiusens/phablet-tools/flash_change/+merge/177927

I've added a check into the functions to verify the tool syntax to use.
I did not update the help though since the aforementioned MR should be merged Fri.

To post a comment you must log in.

Unmerged revisions

269. By Sergio Schvezov

phablet-flash new syntax.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'ubuntu-qtcreator-plugins-common/share/qtcreator/ubuntu/scripts/device_flashdaily'
--- ubuntu-qtcreator-plugins-common/share/qtcreator/ubuntu/scripts/device_flashdaily 2013-06-25 16:28:00 +0000
+++ ubuntu-qtcreator-plugins-common/share/qtcreator/ubuntu/scripts/device_flashdaily 2013-08-09 04:04:13 +0000
@@ -30,8 +30,11 @@
30 echo ${DEVICE_HARDWARE}30 echo ${DEVICE_HARDWARE}
31 echo31 echo
32 echo " In order to flash your device, you must do it manually:"32 echo " In order to flash your device, you must do it manually:"
33 echo " phablet-flash -s ${SERIALNUMBER} -d ${IMAGE_HARDWARE}"33 echo " phablet-flash cdimage-touch -s ${SERIALNUMBER} -d ${IMAGE_HARDWARE}"
34 echo34 echo
35elif [[ phablet_tools_new_syntax ]]; then
36 x-terminal-emulator -e "bash -ic 'phablet-flash cdimage-touch -s ${SERIALNUMBER}'"
35else37else
36 x-terminal-emulator -e "bash -ic 'phablet-flash -s ${SERIALNUMBER}'"38 x-terminal-emulator -e "bash -ic 'phablet-flash -s ${SERIALNUMBER}'"
37fi
38\ No newline at end of file39\ No newline at end of file
40else
41fi
3942
=== modified file 'ubuntu-qtcreator-plugins-common/share/qtcreator/ubuntu/scripts/device_flashdaily_bootstrap'
--- ubuntu-qtcreator-plugins-common/share/qtcreator/ubuntu/scripts/device_flashdaily_bootstrap 2013-06-25 16:28:00 +0000
+++ ubuntu-qtcreator-plugins-common/share/qtcreator/ubuntu/scripts/device_flashdaily_bootstrap 2013-08-09 04:04:13 +0000
@@ -30,8 +30,10 @@
30 echo ${DEVICE_HARDWARE}30 echo ${DEVICE_HARDWARE}
31 echo31 echo
32 echo " In order to flash your device, you must do it manually:"32 echo " In order to flash your device, you must do it manually:"
33 echo " phablet-flash -s ${SERIALNUMBER} -d ${IMAGE_HARDWARE} -b"33 echo " phablet-flash cdimage-touch -s ${SERIALNUMBER} -d ${IMAGE_HARDWARE} -b"
34 echo34 echo
35elif [[ phablet_tools_new_syntax ]]; then
36 x-terminal-emulator -e "bash -ic 'phablet-flash cdimage-touch -s ${SERIALNUMBER}' -b"
35else37else
36 x-terminal-emulator -e "bash -ic 'phablet-flash -s ${SERIALNUMBER}' -b"38 x-terminal-emulator -e "bash -ic 'phablet-flash -s ${SERIALNUMBER}' -b"
37fi
38\ No newline at end of file39\ No newline at end of file
40fi
3941
=== modified file 'ubuntu-qtcreator-plugins-common/share/qtcreator/ubuntu/scripts/functions.inc'
--- ubuntu-qtcreator-plugins-common/share/qtcreator/ubuntu/scripts/functions.inc 2013-07-25 09:24:30 +0000
+++ ubuntu-qtcreator-plugins-common/share/qtcreator/ubuntu/scripts/functions.inc 2013-08-09 04:04:13 +0000
@@ -64,6 +64,12 @@
64 adb_shell "su ${USERNAME} -c \"$@\""64 adb_shell "su ${USERNAME} -c \"$@\""
65}65}
6666
67function phablet_tools_new_syntax {
68 installed_version=$(dpkg-query --show --showformat '${Version}' phablet-tools)
69 dpkg --compare-versions $installed_version ge 1.0
70 echo $?
71}
72
67function ubuntu_stamp {73function ubuntu_stamp {
68 adb_shell cat /system/*ubuntu_stamp74 adb_shell cat /system/*ubuntu_stamp
69}75}

Subscribers

People subscribed via source and target branches