Merge lp:~seb128/ubuntu-archive-scripts/report-include-timezone into lp:ubuntu-archive-scripts

Proposed by Sebastien Bacher
Status: Merged
Approved by: Łukasz Zemczak
Approved revision: 271
Merged at revision: 270
Proposed branch: lp:~seb128/ubuntu-archive-scripts/report-include-timezone
Merge into: lp:ubuntu-archive-scripts
Diff against target: 20 lines (+2/-1)
1 file modified
generate-team-p-m (+2/-1)
To merge this branch: bzr merge lp:~seb128/ubuntu-archive-scripts/report-include-timezone
Reviewer Review Type Date Requested Status
Łukasz Zemczak Approve
Review via email: mp+380301@code.launchpad.net

Commit message

team-report: include the timezone in the update timestamp

To post a comment you must log in.
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Ok, this seems fine, just a minor stylistic nitpick inline. From what I see tm_zone is supported on all the Ubuntu relevant python versions, so we're good.

review: Needs Fixing
271. By Sebastien Bacher

team-report: include the timezone in the update timestamp

Revision history for this message
Sebastien Bacher (seb128) wrote :

updated with the import on a new line now

Revision history for this message
Łukasz Zemczak (sil2100) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'generate-team-p-m'
--- generate-team-p-m 2018-12-19 02:42:03 +0000
+++ generate-team-p-m 2020-03-19 15:08:39 +0000
@@ -18,6 +18,7 @@
18import argparse18import argparse
19from collections import defaultdict, OrderedDict19from collections import defaultdict, OrderedDict
20import datetime20import datetime
21import time
21import json22import json
22import os23import os
23import threading24import threading
@@ -330,7 +331,7 @@
330 all_teams=all_teams,331 all_teams=all_teams,
331 team_to_problems=team_to_problems,332 team_to_problems=team_to_problems,
332 team_to_attn_count=team_to_attn_count,333 team_to_attn_count=team_to_attn_count,
333 now=excuses["generated-date"].strftime("%Y.%m.%d %H:%M:%S")))334 now=excuses["generated-date"].strftime("%Y.%m.%d %H:%M:%S") + ' ' + time.localtime().tm_zone))
334 if args.yaml_output:335 if args.yaml_output:
335 team_to_problem_data = {}336 team_to_problem_data = {}
336 for t, ps in team_to_problems.items():337 for t, ps in team_to_problems.items():

Subscribers

People subscribed via source and target branches