Merge lp:~schwann/ubuntu-ui-toolkit/uitk-autopilot-tab-switch-issue into lp:ubuntu-ui-toolkit

Proposed by Günter Schwann
Status: Merged
Approved by: Zoltan Balogh
Approved revision: 737
Merged at revision: 739
Proposed branch: lp:~schwann/ubuntu-ui-toolkit/uitk-autopilot-tab-switch-issue
Merge into: lp:ubuntu-ui-toolkit
Diff against target: 53 lines (+24/-0)
2 files modified
tests/autopilot/ubuntuuitoolkit/emulators.py (+3/-0)
tests/autopilot/ubuntuuitoolkit/tests/test_emulators.py (+21/-0)
To merge this branch: bzr merge lp:~schwann/ubuntu-ui-toolkit/uitk-autopilot-tab-switch-issue
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu SDK team Pending
Review via email: mp+183625@code.launchpad.net

Commit message

Fixes tab switching with open toolbar fixes https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1220064

Description of the change

When the toolbar is open, the tabbar does not receive the needed click

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'tests/autopilot/ubuntuuitoolkit/emulators.py'
--- tests/autopilot/ubuntuuitoolkit/emulators.py 2013-08-21 13:51:07 +0000
+++ tests/autopilot/ubuntuuitoolkit/emulators.py 2013-09-03 10:40:35 +0000
@@ -241,6 +241,9 @@
241 """Open the next tab."""241 """Open the next tab."""
242 # Click the tab bar to switch to selection mode.242 # Click the tab bar to switch to selection mode.
243 self.pointing_device.click_object(self)243 self.pointing_device.click_object(self)
244 if not self.selectionMode:
245 # in case someone stole the click, like the open toolbar
246 self.pointing_device.click_object(self)
244 self.pointing_device.click_object(self._get_next_tab_button())247 self.pointing_device.click_object(self._get_next_tab_button())
245248
246 def _get_next_tab_button(self):249 def _get_next_tab_button(self):
247250
=== modified file 'tests/autopilot/ubuntuuitoolkit/tests/test_emulators.py'
--- tests/autopilot/ubuntuuitoolkit/tests/test_emulators.py 2013-08-09 00:48:33 +0000
+++ tests/autopilot/ubuntuuitoolkit/tests/test_emulators.py 2013-09-03 10:40:35 +0000
@@ -173,14 +173,35 @@
173 Tab {173 Tab {
174 objectName: "tab1"174 objectName: "tab1"
175 title: "Tab1"175 title: "Tab1"
176 Page {
177 tools: ToolbarItems {
178 ToolbarButton {
179 text: "Test1"
180 }
181 }
182 }
176 }183 }
177 Tab {184 Tab {
178 objectName: "tab2"185 objectName: "tab2"
179 title: "Tab2"186 title: "Tab2"
187 Page {
188 tools: ToolbarItems {
189 ToolbarButton {
190 text: "Test2"
191 }
192 }
193 }
180 }194 }
181 Tab {195 Tab {
182 objectName: "tab3"196 objectName: "tab3"
183 title: "Tab3"197 title: "Tab3"
198 Page {
199 tools: ToolbarItems {
200 ToolbarButton {
201 text: "Test3"
202 }
203 }
204 }
184 }205 }
185 }206 }
186}207}

Subscribers

People subscribed via source and target branches

to status/vote changes: