Merge lp:~scarneiro/ubuntu/quantal/adept/fix-invalid-brace.expansions into lp:ubuntu/quantal/adept

Proposed by Sebastian Carneiro
Status: Rejected
Rejected by: Stéphane Graber
Proposed branch: lp:~scarneiro/ubuntu/quantal/adept/fix-invalid-brace.expansions
Merge into: lp:ubuntu/quantal/adept
Diff against target: 51 lines (+16/-4)
4 files modified
debian/adept-common.install (+4/-2)
debian/adept-updater.install (+2/-1)
debian/changelog (+8/-0)
debian/control (+2/-1)
To merge this branch: bzr merge lp:~scarneiro/ubuntu/quantal/adept/fix-invalid-brace.expansions
Reviewer Review Type Date Requested Status
Dimitri John Ledkov Disapprove
Ubuntu branches Pending
Review via email: mp+111331@code.launchpad.net

Description of the change

Replaced invalid brace expansions from debhelper config files:
debian/adept-common.install, and debian/adept-updater.install

To post a comment you must log in.
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

The fix is very good, and the changelog enty and the version numbers are correct.

Unfortunately adept is no longer developed and has been removed from Debian.
It is no longer shipped in Ubuntu either, and we are removing the package from the archive, so this fix no longer applicable to quantal.

review: Disapprove

Unmerged revisions

81. By Sebastian Carneiro

debian/adept-common.install,
debian/adept-updater.install: Removed invalid brace expansion from
debhelper config files.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/adept-common.install'
--- debian/adept-common.install 2008-08-15 15:24:22 +0000
+++ debian/adept-common.install 2012-06-21 04:17:19 +0000
@@ -1,3 +1,5 @@
1debian/tmp/usr/share/icons/crystalsvg/*/actions/adept_{c,d,i,k,p,r,s,u}*.{png,svgz}1debian/tmp/usr/share/icons/crystalsvg/*/actions/adept_[cdikprsu]*.png
2debian/tmp/usr/share/icons/crystalsvg/*/actions/extender_*.{png,svgz}2debian/tmp/usr/share/icons/crystalsvg/*/actions/adept_[cdikprsu]*.svgz
3debian/tmp/usr/share/icons/crystalsvg/*/actions/extender_*.png
4debian/tmp/usr/share/icons/crystalsvg/*/actions/extender_*.svgz
3debian/tmp/usr/share/apps/adept/*.svg5debian/tmp/usr/share/apps/adept/*.svg
46
=== modified file 'debian/adept-updater.install'
--- debian/adept-updater.install 2006-05-25 20:58:11 +0000
+++ debian/adept-updater.install 2012-06-21 04:17:19 +0000
@@ -1,4 +1,5 @@
1debian/tmp/usr/bin/adept_updater1debian/tmp/usr/bin/adept_updater
2debian/tmp/usr/share/icons/hicolor/*/apps/adept_updater.{png,svgz}2debian/tmp/usr/share/icons/hicolor/*/apps/adept_updater.png
3debian/tmp/usr/share/icons/hicolor/*/apps/adept_updater.svgz
3debian/tmp/usr/share/apps/adept_updater/adept_updaterui.rc4debian/tmp/usr/share/apps/adept_updater/adept_updaterui.rc
4debian/tmp/usr/share/applications/kde/adept_updater.desktop5debian/tmp/usr/share/applications/kde/adept_updater.desktop
56
=== modified file 'debian/changelog'
--- debian/changelog 2012-05-03 21:54:12 +0000
+++ debian/changelog 2012-06-21 04:17:19 +0000
@@ -1,3 +1,11 @@
1adept (3.0~beta7.2+qa2ubuntu1) quantal; urgency=low
2
3 * debian/adept-common.install,
4 debian/adept-updater.install: Removed invalid brace expansion from
5 debhelper config files.
6
7 -- Sebastian Carneiro <scarneiro@fibertel.com.ar> Wed, 20 Jun 2012 23:59:52 -0300
8
1adept (3.0~beta7.2+qa2) unstable; urgency=low9adept (3.0~beta7.2+qa2) unstable; urgency=low
210
3 * QA upload.11 * QA upload.
412
=== modified file 'debian/control'
--- debian/control 2012-01-11 00:40:14 +0000
+++ debian/control 2012-06-21 04:17:19 +0000
@@ -1,7 +1,8 @@
1Source: adept1Source: adept
2Section: kde2Section: kde
3Priority: optional3Priority: optional
4Maintainer: Debian QA Group <packages@qa.debian.org>4Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
5XSBC-Original-Maintainer: Debian QA Group <packages@qa.debian.org>
5Build-Depends: debhelper (>= 8), kdelibs5-dev, cmake, pkg-config, libwibble-dev (>= 0.1.22), libwibble-dev (<< 0.2), libtagcoll2-dev (>= 2.0.6), libtagcoll2-dev (<< 2.1), libapt-pkg-dev (>= 0.7.26~exp10), libxapian-dev (>= 1.0.5)6Build-Depends: debhelper (>= 8), kdelibs5-dev, cmake, pkg-config, libwibble-dev (>= 0.1.22), libwibble-dev (<< 0.2), libtagcoll2-dev (>= 2.0.6), libtagcoll2-dev (<< 2.1), libapt-pkg-dev (>= 0.7.26~exp10), libxapian-dev (>= 1.0.5)
6Standards-Version: 3.9.27Standards-Version: 3.9.2
78

Subscribers

People subscribed via source and target branches