1
=== modified file 'tests/qmltests/CMakeLists.txt'
2
--- tests/qmltests/CMakeLists.txt	2013-04-22 09:57:23 +0000
3
+++ tests/qmltests/CMakeLists.txt	2013-04-22 12:17:29 +0000
4
@@ -27,6 +27,7 @@
5
27
add_qml_test(Greeter Clock)
27
add_qml_test(Greeter Clock)
6
28
add_qml_test(Panel IndicatorItem)
28
add_qml_test(Panel IndicatorItem)
7
29
add_qml_test(utils/Unity/Test UnityTest)
29
add_qml_test(utils/Unity/Test UnityTest)
8
30
add_qml_test(interfaces NotificationInterface NO_ADD_TEST NO_TARGETS)
9
30
31
10
31
set(qmltest_DEFAULT_TARGETS qmluitests qmltests)
32
set(qmltest_DEFAULT_TARGETS qmluitests qmltests)
11
32
set(qmltest_DEFAULT_NO_ADD_TEST TRUE)
33
set(qmltest_DEFAULT_NO_ADD_TEST TRUE)
12
33
34
13
=== added directory 'tests/qmltests/interfaces'
14
=== added file 'tests/qmltests/interfaces/tst_NotificationInterface.qml'
15
--- tests/qmltests/interfaces/tst_NotificationInterface.qml	1970-01-01 00:00:00 +0000
16
+++ tests/qmltests/interfaces/tst_NotificationInterface.qml	2013-04-22 12:17:29 +0000
17
@@ -0,0 +1,198 @@
18
1
/*
19
2
 * Copyright 2013 Canonical Ltd.
20
3
 *
21
4
 * This program is free software; you can redistribute it and/or modify
22
5
 * it under the terms of the GNU General Public License as published by
23
6
 * the Free Software Foundation; version 3.
24
7
 *
25
8
 * This program is distributed in the hope that it will be useful,
26
9
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
27
10
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
28
11
 * GNU General Public License for more details.
29
12
 *
30
13
 * You should have received a copy of the GNU General Public License
31
14
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
32
15
 */
33
16
34
17
import QtQuick 2.0
35
18
import QtTest 1.0
36
19
import Unity.Notifications 0.1 as Notifications
37
20
import Unity.Notifications.Mocks 0.1 as NotificationMocks
38
21
39
22
TestCase {
40
23
41
24
    NotificationMocks.Source {
42
25
        id: source
43
26
    }
44
27
45
28
    Repeater {
46
29
        id: repeater
47
30
        model: Notifications.Model
48
31
        delegate: Item {
49
32
            property var data: model
50
33
            property Repeater actionRepeater
51
34
52
35
            actionRepeater: Repeater {
53
36
                model: parent.data.actions
54
37
                delegate: Item {
55
38
                    property var data: model
56
39
                }
57
40
            }
58
41
        }
59
42
    }
60
43
61
44
    SignalSpy {
62
45
        id: dataSpy
63
46
        target: Notifications.Model
64
47
        signalName: "dataChanged"
65
48
    }
66
49
67
50
    function initTestCase() {
68
51
        Notifications.Model.source = source;
69
52
    }
70
53
71
54
    function init() {
72
55
        Notifications.Model.confirmationPlaceholder = false;
73
56
        tryCompare(repeater, "count", "0", "There should be no notifications")
74
57
    }
75
58
76
59
    function cleanup() {
77
60
        // dismiss all Notifications
78
61
        for (var i = 0; i < repeater.count; i++) {
79
62
            repeater.itemAt(i).data.notification.dismissed()
80
63
        }
81
64
        dataSpy.clear()
82
65
    }
83
66
84
67
    /* make sure all the required types are registered */
85
68
    function test_types() {
86
69
        compare(typeof Notifications.Urgency.Low, "number",
87
70
                "there should be an Urgency::Low enum");
88
71
        compare(typeof Notifications.Urgency.Normal, "number",
89
72
                "there should be an Urgency::Normal enum");
90
73
        compare(typeof Notifications.Urgency.Critical, "number",
91
74
                "there should be an Urgency::Critical enum");
92
75
        compare(typeof Notifications.Type.Confirmation, "number",
93
76
                "there should be a Type::Confirmation enum");
94
77
        compare(typeof Notifications.Type.Ephemeral, "number",
95
78
                "there should be a Type::Ephemeral enum");
96
79
        compare(typeof Notifications.Type.Interactive, "number",
97
80
                "there should be a Type::Interactive enum");
98
81
        compare(typeof Notifications.Type.SnapDecision, "number",
99
82
                "there should be a Type::SnapDecision enum");
100
83
        compare(typeof Notifications.Type.Placeholder, "number",
101
84
                "there should be a Type::Placeholder enum");
102
85
        compare(typeof Notifications.Hint.ButtonTint, "number",
103
86
                "there should be a Hint::ButtonTint enum");
104
87
        compare(typeof Notifications.Hint.IconOnly, "number",
105
88
                "there should be a Hint::IconOnly enum");
106
89
        compare(typeof Notifications.Notification, "object",
107
90
                "Notification should be a registered type");
108
91
        compare(typeof Notifications.Action, "object",
109
92
                "Action should be a registered type");
110
93
        compare(typeof Notifications.Model, "object",
111
94
                "Notifications.Model should be a registered singleton");
112
95
        compare(typeof Notifications.Model.source, "object",
113
96
                "Notifications.Model should have a source property");
114
97
        compare(typeof Notifications.Model.confirmationPlaceholder, "boolean",
115
98
                "Notifications.Model should have a confirmationPlaceholder property");
116
99
    }
117
100
118
101
    /* make sure all the required roles and methods of Notification are exposed */
119
102
    function test_notification_members() {
120
103
        source.send({
121
104
            "type": Notifications.Type.Interactive,
122
105
        });
123
106
        tryCompare(repeater, "count", 1, "there should be one notification");
124
107
125
108
        var data = repeater.itemAt(0).data;
126
109
        compare(typeof data.type, "number",
127
110
                "NotificationModel should expose a \"type\" role of type Type");
128
111
        compare(typeof data.urgency, "number",
129
112
                "NotificationModel should expose a \"urgency\" role of type Urgency");
130
113
        compare(typeof data.id, "number",
131
114
                "NotificationModel should expose a \"id\" role of type int");
132
115
        compare(typeof data.summary, "string",
133
116
                "NotificationModel should expose a \"summary\" role of type QString");
134
117
        compare(typeof data.body, "string",
135
118
                "NotificationModel should expose a \"body\" role of type QString");
136
119
        compare(typeof data.value, "number",
137
120
                "NotificationModel should expose a \"value\" role of type int");
138
121
        compare(typeof data.icon, "object",
139
122
                "NotificationModel should expose an \"icon\" role of type QUrl");
140
123
        compare(typeof data.secondaryIcon, "object",
141
124
                "NotificationModel should expose a \"secondaryIcon\" role of type QUrl");
142
125
        compare(typeof data.actions, "object",
143
126
                "NotificationModel should expose an \"actions\" role of type QQmlListProperty");
144
127
        compare(typeof data.hints, "number",
145
128
                "NotificationModel should expose a \"hints\" role of type Hints");
146
129
        compare(typeof data.notification, "object",
147
130
                "NotificationModel should expose a \"notification\" role of type Notification");
148
131
149
132
        var notification = data.notification;
150
133
        compare(typeof notification.dismissed, "function",
151
134
                "Notification::dismissed should be a signal");
152
135
        compare(typeof notification.onHovered, "function",
153
136
                "Notification::onHovered should be a slot");
154
137
        compare(typeof notification.onDisplayed, "function",
155
138
                "Notification::onDisplayed should be a slot");
156
139
    }
157
140
158
141
    /* make sure all the required roles and methods of Action are exposed */
159
142
    function test_action_members() {
160
143
        source.send({
161
144
            "type": Notifications.Type.Interactive,
162
145
            "actions": [
163
146
                {"label": "test"}
164
147
            ]
165
148
        });
166
149
        tryCompare(repeater, "count", 1, "there should be one notification");
167
150
168
151
        var data = repeater.itemAt(0).data;
169
152
        data = repeater.itemAt(0).actionRepeater.itemAt(0).data;
170
153
        compare(typeof data.label, "string",
171
154
                "Notification::actions should expose a \"label\" role of type QString");
172
155
        compare(typeof data.action, "object",
173
156
                "Notification::actions should expose an \"action\" role of type Action");
174
157
175
158
        var action = data.action;
176
159
        compare(typeof action.invoke, "function", "Action::invoke should be a function");
177
160
    }
178
161
179
162
    /* make sure the model is empty by default */
180
163
    function test_empty() {
181
164
        tryCompare(repeater, "count", 0, "there should be no notifications");
182
165
    }
183
166
184
167
    /* make sure there is a placeholder item used as the first item when
185
168
       confirmationPlaceholder is true and that any additional notification is added
186
169
       after it */
187
170
    function test_placeholder() {
188
171
        Notifications.Model.confirmationPlaceholder = true;
189
172
        tryCompare(repeater, "count", 1, "there should be one notification");
190
173
        compare(repeater.itemAt(0).data.type, Notifications.Type.Placeholder,
191
174
                "the notification should be of Placeholder type");
192
175
        source.send({
193
176
            "type": Notifications.Type.Ephemeral
194
177
        })
195
178
        tryCompare(repeater, "count", 2, "second notification was added");
196
179
        compare(repeater.itemAt(0).data.type, Notifications.Type.Placeholder,
197
180
                "the first notification should be of Placeholder type");
198
181
        compare(repeater.itemAt(1).data.type, Notifications.Type.Ephemeral,
199
182
                "the second notification should be of Ephemeral type");
200
183
    }
201
184
202
185
    /* make sure the placeholder item is updated with data incoming in a Confirmation
203
186
       notification */
204
187
    function test_confirmation() {
205
188
        Notifications.Model.confirmationPlaceholder = true;
206
189
        tryCompare(repeater, "count", 1, "there should be only one notification");
207
190
        source.send({
208
191
            "type": Notifications.Type.Confirmation
209
192
        });
210
193
        tryCompare(dataSpy, "count", 1, "notification data should have been updated");
211
194
        compare(repeater.count, 1, "there should be only one notification");
212
195
        compare(repeater.itemAt(0).type, Notifications.Type.Confirmation,
213
196
                "the first notification should be of Confirmation type");
214
197
    }
215
198
}
Status:	Rejected
Rejected by:	Michał Sawicz on 2013-05-16
Proposed branch:	lp:~saviq/unity/phablet.notification-interface-tests
Merge into:	lp:unity/phablet
Diff against target:	215 lines (+199/-0) 2 files modified tests/qmltests/CMakeLists.txt (+1/-0) tests/qmltests/interfaces/tst_NotificationInterface.qml (+198/-0)
To merge this branch:	bzr merge lp:~saviq/unity/phablet.notification-interface-tests
Related bugs:	Link a bug report
Related blueprints:	Backend for Notifications NG (Undefined)
Reviewer	Review Type	Date Requested	Status
Michał Sawicz			Disapprove on 2013-05-16
PS Jenkins bot (community)	continuous-integration		Approve on 2013-04-22
Michi Henning		2013-03-28	Pending
Mirco Müller		2013-03-28	Pending
Jussi Pakkanen		2013-03-28	Pending
Thomas Voß	architecture	2013-03-28	Pending
Michael Zanetti	code	2013-03-28	Pending
Review via email: mp+155914@code.launchpad.net