Merge lp:~sam92/notify-osd/focusfollowdefault into lp:notify-osd

Proposed by Samuel Mehrbrodt
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 480
Merged at revision: 480
Proposed branch: lp:~sam92/notify-osd/focusfollowdefault
Merge into: lp:notify-osd
Diff against target: 12 lines (+1/-1)
1 file modified
data/com.canonical.NotifyOSD.gschema.xml (+1/-1)
To merge this branch: bzr merge lp:~sam92/notify-osd/focusfollowdefault
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Matthew Paul Thomas (community) design Approve
Review via email: mp+198541@code.launchpad.net

Commit message

Make 'focus-follow' the default for Multihead environments

Description of the change

I think this is the better default because in some setups you have a TV or a projector that is placed on the right side of your desktop by default and so the notifications would always show up there.

This is especially annoying when showing a presentation and the notifications start to appear on the projector.

To post a comment you must log in.
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

What display does it use when multi-head-mode is dont-focus-follow?

Revision history for this message
Samuel Mehrbrodt (sam92) wrote :

It uses the display on the far right.

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Oh dear ... What I originally specified was that the bubble should appear on the display that contains the focused window (or the largest proportion of the focused window, if it's split across multiple displays), because that's the display you're most likely to be paying attention to. <https://wiki.ubuntu.com/NotifyOSD#position>

The display containing the pointer should be used only as a fallback, when no window is focused. But I guess using that display all the time is better than using it none of the time, so I'm approving this change as an improvement. I'd still like to see the specified behavior implemented, and the multihead-mode setting dropped altogether.

review: Approve (design)
Revision history for this message
Samuel Mehrbrodt (sam92) wrote :

Any chance to get this in for the next LTS (14.04)?

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
No commit message was specified in the merge proposal. Hit 'Add commit message' on the merge proposal web page or follow the link below. You can approve the merge proposal yourself to rerun.
https://code.launchpad.net/~sam92/notify-osd/focusfollowdefault/+merge/198541/+edit-commit-message

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'data/com.canonical.NotifyOSD.gschema.xml'
--- data/com.canonical.NotifyOSD.gschema.xml 2011-07-13 10:07:04 +0000
+++ data/com.canonical.NotifyOSD.gschema.xml 2013-12-11 11:29:23 +0000
@@ -1,7 +1,7 @@
1<schemalist>1<schemalist>
2 <schema id="com.canonical.notify-osd" path="/apps/notify-osd/">2 <schema id="com.canonical.notify-osd" path="/apps/notify-osd/">
3 <key name="multihead-mode" type="s">3 <key name="multihead-mode" type="s">
4 <default>'dont-focus-follow'</default>4 <default>'focus-follow'</default>
5 <summary>Multihead position behaviour</summary>5 <summary>Multihead position behaviour</summary>
6 <description>Should the notification position follow the mouse-focus or not in multi-screen environments. Use values "dont-focus-follow" or "focus-follow".</description>6 <description>Should the notification position follow the mouse-focus or not in multi-screen environments. Use values "dont-focus-follow" or "focus-follow".</description>
7 </key>7 </key>

Subscribers

People subscribed via source and target branches