Merge lp:~rsalveti/indicator-sound/making_sure_always_syncing_accountservice into lp:indicator-sound/14.10

Proposed by Ricardo Salveti
Status: Merged
Approved by: Ted Gould
Approved revision: 457
Merged at revision: 459
Proposed branch: lp:~rsalveti/indicator-sound/making_sure_always_syncing_accountservice
Merge into: lp:indicator-sound/14.10
Diff against target: 27 lines (+3/-0)
1 file modified
src/volume-control.vala (+3/-0)
To merge this branch: bzr merge lp:~rsalveti/indicator-sound/making_sure_always_syncing_accountservice
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+237890@code.launchpad.net

Commit message

volume-control: making sure we're always in sync with accountservice

Description of the change

volume-control: making sure we're always in sync with accountservice

Syncing volume in the following situations:
1 - volume changed as a consequence of a sink add/remove event;
2 - changed role on touch;
3 - external entity setting up the volume for the active role on touch;

To post a comment you must log in.
457. By Ricardo Salveti

volume-control: making sure we're always in sync with accountservice

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ted Gould (ted) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/volume-control.vala'
--- src/volume-control.vala 2014-10-08 18:17:29 +0000
+++ src/volume-control.vala 2014-10-10 03:55:22 +0000
@@ -170,6 +170,7 @@
170 {170 {
171 _volume = volume_to_double (i.volume.max ());171 _volume = volume_to_double (i.volume.max ());
172 volume_changed (_volume);172 volume_changed (_volume);
173 start_local_volume_timer();
173 }174 }
174 }175 }
175176
@@ -238,6 +239,7 @@
238 /* Someone else changed the volume for this role, reflect on the indicator */239 /* Someone else changed the volume for this role, reflect on the indicator */
239 _volume = volume_to_double (volume);240 _volume = volume_to_double (volume);
240 volume_changed (_volume);241 volume_changed (_volume);
242 start_local_volume_timer();
241 }243 }
242 }244 }
243 }245 }
@@ -280,6 +282,7 @@
280282
281 _volume = volume_to_double (volume);283 _volume = volume_to_double (volume);
282 volume_changed (_volume);284 volume_changed (_volume);
285 start_local_volume_timer();
283 } catch (GLib.Error e) {286 } catch (GLib.Error e) {
284 warning ("unable to get volume for active role %s (%s)", sink_input_objp, e.message);287 warning ("unable to get volume for active role %s (%s)", sink_input_objp, e.message);
285 }288 }

Subscribers

People subscribed via source and target branches