Merge lp:~rodrigo-moya/ubuntu/natty/gnome-settings-daemon/fix-649809 into lp:~ubuntu-desktop/gnome-settings-daemon/ubuntu

Proposed by Rodrigo Moya
Status: Merged
Merged at revision: 137
Proposed branch: lp:~rodrigo-moya/ubuntu/natty/gnome-settings-daemon/fix-649809
Merge into: lp:~ubuntu-desktop/gnome-settings-daemon/ubuntu
Diff against target: 57 lines (+36/-1)
3 files modified
debian/changelog (+8/-0)
debian/patches/93_wait_for_xsettings.patch (+27/-0)
debian/patches/series (+1/-1)
To merge this branch: bzr merge lp:~rodrigo-moya/ubuntu/natty/gnome-settings-daemon/fix-649809
Reviewer Review Type Date Requested Status
Ubuntu Desktop Pending
Review via email: mp+55346@code.launchpad.net
To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2011-03-23 17:42:53 +0000
+++ debian/changelog 2011-03-29 14:18:37 +0000
@@ -1,3 +1,11 @@
1gnome-settings-daemon (2.32.1-0ubuntu12) natty; urgency=low
2
3 * debian/patches/93_wait_for_xsettings.patch:
4 - Add patch to avoid race condition between gdm's gnome-settings-daemon
5 and user's (LP: #649809)
6
7 -- Rodrigo Moya <rodrigo.moya@canonical.com> Tue, 29 Mar 2011 10:26:47 +0200
8
1gnome-settings-daemon (2.32.1-0ubuntu11) natty; urgency=low9gnome-settings-daemon (2.32.1-0ubuntu11) natty; urgency=low
210
3 * debian/patches/92_datetime_fixups.patch:11 * debian/patches/92_datetime_fixups.patch:
412
=== added file 'debian/patches/93_wait_for_xsettings.patch'
--- debian/patches/93_wait_for_xsettings.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/93_wait_for_xsettings.patch 2011-03-29 14:18:37 +0000
@@ -0,0 +1,27 @@
1diff --git a/plugins/xsettings/gsd-xsettings-manager.c b/plugins/xsettings/gsd-xsettings-manager.c
2index 709d9f8..fdad93c 100644
3--- a/plugins/xsettings/gsd-xsettings-manager.c
4+++ b/plugins/xsettings/gsd-xsettings-manager.c
5@@ -583,12 +583,20 @@ setup_xsettings_managers (GnomeXSettingsManager *manager)
6 int n_screens;
7 gboolean res;
8 gboolean terminated;
9+ gint tries = 0;
10
11 display = gdk_display_get_default ();
12 n_screens = gdk_display_get_n_screens (display);
13
14- res = xsettings_manager_check_running (gdk_x11_display_get_xdisplay (display),
15- gdk_screen_get_number (gdk_screen_get_default ()));
16+ do {
17+ res = xsettings_manager_check_running (gdk_x11_display_get_xdisplay (display),
18+ gdk_screen_get_number (gdk_screen_get_default ()));
19+ if (res) {
20+ g_usleep (100000);
21+ tries++;
22+ }
23+ } while (res && tries <= 20);
24+
25 if (res) {
26 g_warning ("You can only run one xsettings manager at a time; exiting");
27 return FALSE;
028
=== modified file 'debian/patches/series'
--- debian/patches/series 2011-03-23 17:42:53 +0000
+++ debian/patches/series 2011-03-29 14:18:37 +0000
@@ -15,4 +15,4 @@
1545_support_new_video_key.patch1545_support_new_video_key.patch
1691_update_gvc_source.patch1691_update_gvc_source.patch
1792_datetime_fixups.patch1792_datetime_fixups.patch
181893_wait_for_xsettings.patch

Subscribers

People subscribed via source and target branches

to all changes: