Merge lp:~robert-ancell/unity-control-center/lowercase-usernames into lp:unity-control-center

Proposed by Robert Ancell
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 12867
Merged at revision: 12873
Proposed branch: lp:~robert-ancell/unity-control-center/lowercase-usernames
Merge into: lp:unity-control-center
Diff against target: 20 lines (+1/-2)
1 file modified
panels/user-accounts/um-utils.c (+1/-2)
To merge this branch: bzr merge lp:~robert-ancell/unity-control-center/lowercase-usernames
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Review via email: mp+299635@code.launchpad.net

Commit message

Ubuntu only supports usernames with lowercase letters.

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

that makes sense

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'panels/user-accounts/um-utils.c'
--- panels/user-accounts/um-utils.c 2014-04-04 13:44:16 +0000
+++ panels/user-accounts/um-utils.c 2016-07-11 02:42:45 +0000
@@ -520,7 +520,6 @@
520 */520 */
521 for (c = username; *c; c++) {521 for (c = username; *c; c++) {
522 if (! ((*c >= 'a' && *c <= 'z') ||522 if (! ((*c >= 'a' && *c <= 'z') ||
523 (*c >= 'A' && *c <= 'Z') ||
524 (*c >= '0' && *c <= '9') ||523 (*c >= '0' && *c <= '9') ||
525 (*c == '_') || (*c == '.') ||524 (*c == '_') || (*c == '.') ||
526 (*c == '-' && c != username)))525 (*c == '-' && c != username)))
@@ -543,7 +542,7 @@
543 }542 }
544 else {543 else {
545 *tip = g_strdup (_("The username must only consist of:\n"544 *tip = g_strdup (_("The username must only consist of:\n"
546 " \xe2\x9e\xa3 letters from the English alphabet\n"545 " \xe2\x9e\xa3 lowercase letters from the English alphabet\n"
547 " \xe2\x9e\xa3 digits\n"546 " \xe2\x9e\xa3 digits\n"
548 " \xe2\x9e\xa3 any of the characters '.', '-' and '_'"));547 " \xe2\x9e\xa3 any of the characters '.', '-' and '_'"));
549 }548 }

Subscribers

People subscribed via source and target branches