Merge lp:~roadmr/checkbox/packaging-libqt5v8-dependency into lp:~checkbox-dev/checkbox/checkbox-packaging

Proposed by Daniel Manrique
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 69
Merged at revision: 68
Proposed branch: lp:~roadmr/checkbox/packaging-libqt5v8-dependency
Merge into: lp:~checkbox-dev/checkbox/checkbox-packaging
Diff against target: 99 lines (+10/-24)
3 files modified
debian/changelog (+7/-1)
debian/control (+3/-13)
debian/rules (+0/-10)
To merge this branch: bzr merge lp:~roadmr/checkbox/packaging-libqt5v8-dependency
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Review via email: mp+211587@code.launchpad.net

This proposal supersedes a proposal from 2014-03-18.

Description of the change

* Reduced set of qt5 build-depends to minimum necessary
* Drop GUI_ARCHES logic in debian/rules.
* Drop arch-restriction from packages.
* Drop libqt5v8-5-dev build-dependency. (LP: #1292801)
* Remove arch restriction from checkbox. All dependencies are present
  now, and keeping things in dep-wait state is recommended cause it
  doesn't block anything and this upload would not be necessary.

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote : Posted in a previous version of this proposal

wrong target branch

review: Needs Resubmitting
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2014-03-14 17:26:45 +0000
+++ debian/changelog 2014-03-18 17:24:10 +0000
@@ -1,6 +1,12 @@
1checkbox (0.17.9) UNRELEASED; urgency=medium1checkbox (0.17.9) UNRELEASED; urgency=medium
22
3 * Open for development (remove this message before releasing)3 [ Dimitri John Ledkov ]
4 * Drop GUI_ARCHES logic in debian/rules.
5 * Drop arch-restriction from packages.
6 * Drop libqt5v8-5-dev build-dependency. (LP: #1292801)
7 * Remove arch restriction from checkbox. All dependencies are present
8 now, and keeping things in dep-wait state is recommended cause it
9 doesn't block anything and this upload would not be necessary.
410
5 -- Daniel Manrique <roadmr@ubuntu.com> Fri, 14 Mar 2014 13:25:25 -040011 -- Daniel Manrique <roadmr@ubuntu.com> Fri, 14 Mar 2014 13:25:25 -0400
612
713
=== modified file 'debian/control'
--- debian/control 2014-02-13 15:58:44 +0000
+++ debian/control 2014-03-18 17:24:10 +0000
@@ -8,13 +8,8 @@
8Build-Depends: debhelper (>= 9.2),8Build-Depends: debhelper (>= 9.2),
9 dh-translations,9 dh-translations,
10 libnl-genl-3-dev,10 libnl-genl-3-dev,
11 libqt5sql5-sqlite,
11 libqt4-dev,12 libqt4-dev,
12 libqt5qml-graphicaleffects [!arm64 !powerpc !ppc64el],
13 libqt5sql5-sqlite,
14 libqt5svg5-dev,
15 libqt5v8-5-dev [!arm64 !powerpc !ppc64el],
16 libqt5webkit5-dev [!arm64 !powerpc !ppc64el],
17 libqt5xmlpatterns5-dev,
18 po-debconf,13 po-debconf,
19 python,14 python,
20 python-distutils-extra,15 python-distutils-extra,
@@ -28,15 +23,10 @@
28 python3-requests ( >= 1.0),23 python3-requests ( >= 1.0),
29 python3-setuptools,24 python3-setuptools,
30 python3-sphinx,25 python3-sphinx,
31 qt3d5-dev [!arm64 !powerpc !ppc64el],
32 qt4-qmake,26 qt4-qmake,
33 qt5-default,27 qt5-default,
34 qtbase5-dev,28 qtbase5-dev,
35 qtdeclarative5-dev [!arm64 !powerpc !ppc64el],29 qtdeclarative5-dev,
36 qtdeclarative5-dev-tools [!arm64 !powerpc !ppc64el],
37 qtlocation5-dev [!arm64 !powerpc !ppc64el],
38 qtscript5-dev,
39 qttools5-dev,
40 qttools5-dev-tools30 qttools5-dev-tools
41Vcs-Bzr: https://code.launchpad.net/~checkbox-dev/checkbox/checkbox-packaging31Vcs-Bzr: https://code.launchpad.net/~checkbox-dev/checkbox/checkbox-packaging
4232
@@ -426,7 +416,7 @@
426 checkbox-certification-server416 checkbox-certification-server
427417
428Package: checkbox-gui418Package: checkbox-gui
429Architecture: i386 armhf amd64419Architecture: any
430Depends: checkbox-ng-service,420Depends: checkbox-ng-service,
431 plainbox-provider-checkbox,421 plainbox-provider-checkbox,
432 qtdeclarative5-localstorage-plugin,422 qtdeclarative5-localstorage-plugin,
433423
=== modified file 'debian/rules'
--- debian/rules 2014-02-13 15:58:44 +0000
+++ debian/rules 2014-03-18 17:24:10 +0000
@@ -7,9 +7,6 @@
77
8REL_NO := $(shell lsb_release -rs)8REL_NO := $(shell lsb_release -rs)
9RELEASE_GTE_RARING := $(shell expr $(REL_NO) \>= 13.04)9RELEASE_GTE_RARING := $(shell expr $(REL_NO) \>= 13.04)
10# The checkbox-gui binary only makes sense to build for the following
11# architectures.
12GUI_ARCHS := amd64 armhf i386
13%:10%:
14 dh "$@" --with python3,sphinxdoc,translations11 dh "$@" --with python3,sphinxdoc,translations
1512
@@ -37,12 +34,7 @@
37 echo "from unittest.mock import *" > $(CURDIR)/plainbox/plainbox/vendor/mock.py34 echo "from unittest.mock import *" > $(CURDIR)/plainbox/plainbox/vendor/mock.py
38 dh_quilt_patch35 dh_quilt_patch
39endif36endif
40ifneq (,$(findstring $(DEB_BUILD_ARCH), $(GUI_ARCHS)))
41 cd $(CURDIR)/checkbox-gui && qmake PREFIX=/usr && make37 cd $(CURDIR)/checkbox-gui && qmake PREFIX=/usr && make
42 $(warning NOTICE: Building GUI on supported architecture)
43else
44 $(warning NOTICE: NOT building GUI on unsupported architecture)
45endif
46 python3 setup.py build38 python3 setup.py build
4739
48ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))40ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
@@ -62,9 +54,7 @@
62 python3 setup.py install --root=$(CURDIR)/debian/tmp --install-layout=deb54 python3 setup.py install --root=$(CURDIR)/debian/tmp --install-layout=deb
63 mkdir -p $(CURDIR)/debian/tmp/usr/lib/checkbox/bin/55 mkdir -p $(CURDIR)/debian/tmp/usr/lib/checkbox/bin/
64 cp -R $(CURDIR)/debian/tmp/usr/share/checkbox/scripts/* $(CURDIR)/debian/tmp/usr/lib/checkbox/bin/56 cp -R $(CURDIR)/debian/tmp/usr/share/checkbox/scripts/* $(CURDIR)/debian/tmp/usr/lib/checkbox/bin/
65ifneq (,$(findstring $(DEB_BUILD_ARCH), $(GUI_ARCHS)))
66 cd $(CURDIR)/checkbox-gui && make INSTALL_ROOT=$(CURDIR)/debian/tmp install57 cd $(CURDIR)/checkbox-gui && make INSTALL_ROOT=$(CURDIR)/debian/tmp install
67endif
68 dh_install58 dh_install
6959
70override_dh_installdocs:60override_dh_installdocs:

Subscribers

People subscribed via source and target branches