snappy-hwe-snaps

Merge ~rmescandon/snappy-hwe-snaps/+git/engineering-tests:nm-debug-config-test into ~snappy-hwe-team/snappy-hwe-snaps/+git/engineering-tests:master

  1. Git
  2. lp:~rmescandon/snappy-hwe-snaps/+git/engineering-tests
  3. nm-debug-config-test
  4. Merge into master
Proposed by Roberto Mier Escandon
Status: Merged
Approved by: Konrad Zapałowicz
Approved revision: a09e2d8daa45515a753a98d9e2b0748b41c91bbd
Merged at revision: 7c2447984ea2d839a8d8515f8117edc9efaa1fb7
Proposed branch: ~rmescandon/snappy-hwe-snaps/+git/engineering-tests:nm-debug-config-test
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/engineering-tests:master
Diff against target: 62 lines (+54/-0)
1 file modified
com.canonical.se:engineering-tests/units/network-manager/network-manager.pxu (+54/-0)
Reviewer Review Type Date Requested Status
Konrad Zapałowicz (community) code Approve
System Enablement Bot continuous-integration Approve
Review via email: mp+327102@code.launchpad.net

Description of the change

Plainbox tests for network manager debug enable/disable config option

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

FAILED: Continuous integration, rev:76ec3c696c2058b3b41565f005f78dd09af924c5
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1758/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/2518/console
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1665/console
    None: https://jenkins.canonical.com/system-enablement/job/generic-cleanup-snap/2036/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1758/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:e9756ff6c1e7ea9332c5f1a456f750806b31415d
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1760/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/2520
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1668/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/2820
    None: https://jenkins.canonical.com/system-enablement/job/generic-cleanup-snap/2039/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1760/rebuild

review: Approve (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:60201dd66c3329e87cf42f4c8a9f11bf28079d70
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1795/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/2596
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1703/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/2889
    None: https://jenkins.canonical.com/system-enablement/job/generic-cleanup-snap/2108/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1795/rebuild

review: Approve (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:fe7eda662bde3e5795738f5f8f59292ca122cd95
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1926/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/3278
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1834/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/3541
    None: https://jenkins.canonical.com/system-enablement/job/generic-cleanup-snap/2740/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1926/rebuild

review: Approve (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:a09e2d8daa45515a753a98d9e2b0748b41c91bbd
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1927/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/3279
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1835/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/3542
    None: https://jenkins.canonical.com/system-enablement/job/generic-cleanup-snap/2741/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1927/rebuild

review: Approve (continuous-integration)
Revision history for this message
Konrad Zapałowicz (kzapalowicz) wrote :

lgtm

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/com.canonical.se:engineering-tests/units/network-manager/network-manager.pxu b/com.canonical.se:engineering-tests/units/network-manager/network-manager.pxu
index 27d9b8b..e905919 100644
--- a/com.canonical.se:engineering-tests/units/network-manager/network-manager.pxu
+++ b/com.canonical.se:engineering-tests/units/network-manager/network-manager.pxu
@@ -323,3 +323,57 @@ _steps:
323 $ sudo apt install wakeonlan323 $ sudo apt install wakeonlan
324_verification:324_verification:
325 Did the SUT wake up from S5?325 Did the SUT wake up from S5?
326
327id: network_manager/debug/default_off
328category_id: network_manager
329plugin: manual
330_summary: The debug option defaults to off
331_purpose:
332 Makes sure that the debug option defaults to disabled
333_steps:
334 1. Install the network-manager snap fresh (i.e. not an upgrade)
335 2. Run the following:
336 .
337 $ sudo snap get network-manager debug.enable
338_verification:
339 Verify that the returned value is "false"
340
341id: network_manager/debug/disabling_works
342category_id: network_manager
343plugin: manual
344depends: network_manager/debug/default_off
345_summary: Disabling debug actually disables debug logging
346_purpose:
347 Makes sure that when debug.enabled is set to "false" no debug logs are written
348_steps:
349 1. Make sure that debug is disabled. Run:
350 .
351 $ sudo snap set network-manager debug.enable=false
352 .
353 2. Show only most recent journal entries
354 .
355 $ sudo journalctl -f -u snap.network-manager.networkmanager.service
356 .
357_verification:
358 Verify that any new log entry in journal coming from network-manager is in <info>,
359 <warn> or <error>, but never in <debug> level
360
361id: network_manager/automount/debug_works
362category_id: network_manager
363plugin: manual
364depends: network_manager/debug/default_off
365_summary: When debug is enabled, debug logs are available
366_purpose:
367 Makes sure that when debug option is enabled the <debug> logs are available
368_steps:
369 1. Make sure that debug is enabled. Run:
370 .
371 $ sudo snap set network-manager debug.enable=true
372 .
373 2. Show only most recent journal entries
374 .
375 $ sudo journalctl -f -u snap.network-manager.networkmanager.service
376 .
377_verification:
378 Verify that any new log entry in journal coming from network-manager is in <debug>
379 level

Subscribers

People subscribed via source and target branches