Merge lp:~ricotz/bamf/annotation-fixes into lp:bamf/0.4

Proposed by Rico Tzschichholz
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 491
Merged at revision: 490
Proposed branch: lp:~ricotz/bamf/annotation-fixes
Merge into: lp:bamf/0.4
Diff against target: 123 lines (+37/-3)
6 files modified
lib/libbamf/Makefile.am (+5/-1)
lib/libbamf/bamf-application.c (+12/-0)
lib/libbamf/bamf-control.c (+5/-0)
lib/libbamf/bamf-tab-source.c (+13/-0)
lib/libbamf/bamf-view.c (+1/-1)
lib/libbamf/bamf-window.c (+1/-1)
To merge this branch: bzr merge lp:~ricotz/bamf/annotation-fixes
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
Review via email: mp+128544@code.launchpad.net

Commit message

libbamf: gir-annotion fixes and make gi-scanner verbose

Description of the change

libbamf: gir-annotion fixes and make gi-scanner verbose

To post a comment you must log in.
lp:~ricotz/bamf/annotation-fixes updated
491. By Rico Tzschichholz

libbamf: only perform introspection on public api

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Looks good, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/libbamf/Makefile.am'
--- lib/libbamf/Makefile.am 2012-07-31 15:51:02 +0000
+++ lib/libbamf/Makefile.am 2012-10-08 17:07:43 +0000
@@ -113,11 +113,15 @@
113113
114if HAVE_INTROSPECTION114if HAVE_INTROSPECTION
115115
116introspection_sources = $(libbamf_la_SOURCES)116introspection_sources = \
117 $(sources_h) \
118 $(libbamf_sources) \
119 $(NULL)
117120
118Bamf-0.2.gir: libbamf.la121Bamf-0.2.gir: libbamf.la
119Bamf_0_2_gir_INCLUDES = GObject-2.0 GLib-2.0122Bamf_0_2_gir_INCLUDES = GObject-2.0 GLib-2.0
120Bamf_0_2_gir_CFLAGS = \123Bamf_0_2_gir_CFLAGS = \
124 --warn-all \
121 --c-include='libbamf/libbamf.h' \125 --c-include='libbamf/libbamf.h' \
122 $(DBUS_CFLAGS) \126 $(DBUS_CFLAGS) \
123 -I$(top_srcdir)/lib \127 -I$(top_srcdir)/lib \
124128
=== modified file 'lib/libbamf/bamf-application.c'
--- lib/libbamf/bamf-application.c 2012-09-28 19:54:41 +0000
+++ lib/libbamf/bamf-application.c 2012-10-08 17:07:43 +0000
@@ -72,6 +72,12 @@
72 int show_stubs;72 int show_stubs;
73};73};
7474
75/**
76 * bamf_application_get_supported_mime_types:
77 * @application: a #BamfApplication
78 *
79 * Returns: (transfer full) (array zero-terminated=1): A string array containing the supported mime-types.
80 */
75gchar **81gchar **
76bamf_application_get_supported_mime_types (BamfApplication *application)82bamf_application_get_supported_mime_types (BamfApplication *application)
77{83{
@@ -402,6 +408,12 @@
402 }408 }
403}409}
404410
411/**
412 * bamf_application_get_focusable_child:
413 * @application: a #BamfApplication
414 *
415 * Returns: (transfer none): The focusable child for this application.
416 */
405BamfView *417BamfView *
406bamf_application_get_focusable_child (BamfApplication *application)418bamf_application_get_focusable_child (BamfApplication *application)
407{419{
408420
=== modified file 'lib/libbamf/bamf-control.c'
--- lib/libbamf/bamf-control.c 2012-07-05 06:30:47 +0000
+++ lib/libbamf/bamf-control.c 2012-10-08 17:07:43 +0000
@@ -112,6 +112,11 @@
112 }112 }
113}113}
114114
115/**
116 * bamf_control_get_default:
117 *
118 * Returns: (transfer none): The default #BamfControl reference.
119 */
115BamfControl *120BamfControl *
116bamf_control_get_default (void)121bamf_control_get_default (void)
117{122{
118123
=== modified file 'lib/libbamf/bamf-tab-source.c'
--- lib/libbamf/bamf-tab-source.c 2012-08-21 22:02:12 +0000
+++ lib/libbamf/bamf-tab-source.c 2012-10-08 17:07:43 +0000
@@ -68,6 +68,12 @@
68 return TRUE;68 return TRUE;
69}69}
7070
71/**
72 * bamf_tab_source_get_tab_ids:
73 * @source: a #BamfTabSource
74 *
75 * Returns: (transfer none) (allow-none) (array zero-terminated=1): A string array containing the IDs of this #BamfTabSource.
76 */
71char **77char **
72bamf_tab_source_get_tab_ids (BamfTabSource *source)78bamf_tab_source_get_tab_ids (BamfTabSource *source)
73{79{
@@ -79,6 +85,13 @@
79 return NULL;85 return NULL;
80}86}
8187
88/**
89 * bamf_tab_source_get_tab_preview:
90 * @source: a #BamfTabSource
91 * @tab_id: an ID
92 *
93 * Returns: (transfer none) (allow-none): A #GArray containing the preview for the given ID of this #BamfTabSource.
94 */
82GArray *95GArray *
83bamf_tab_source_get_tab_preview (BamfTabSource *source,96bamf_tab_source_get_tab_preview (BamfTabSource *source,
84 char *tab_id)97 char *tab_id)
8598
=== modified file 'lib/libbamf/bamf-view.c'
--- lib/libbamf/bamf-view.c 2012-10-08 11:41:04 +0000
+++ lib/libbamf/bamf-view.c 2012-10-08 17:07:43 +0000
@@ -270,7 +270,7 @@
270 * bamf_view_user_visible:270 * bamf_view_user_visible:
271 * @view: a #BamfView271 * @view: a #BamfView
272 *272 *
273 * Returns a boolean useful for determining if a particular view is "user visible". User visible273 * Returns: a boolean useful for determining if a particular view is "user visible". User visible
274 * is a concept relating to whether or not a window should be shown in a launcher tasklist.274 * is a concept relating to whether or not a window should be shown in a launcher tasklist.
275 */275 */
276gboolean276gboolean
277277
=== modified file 'lib/libbamf/bamf-window.c'
--- lib/libbamf/bamf-window.c 2012-07-01 18:13:55 +0000
+++ lib/libbamf/bamf-window.c 2012-10-08 17:07:43 +0000
@@ -79,7 +79,7 @@
79 * bamf_window_get_transient:79 * bamf_window_get_transient:
80 * @self: a #BamfWindow80 * @self: a #BamfWindow
81 *81 *
82 * Returns: (transfer none) (nullable): A transient for this #BamfWindow.82 * Returns: (transfer none) (allow-none): A transient for this #BamfWindow.
83 */83 */
8484
85BamfWindow * bamf_window_get_transient (BamfWindow *self)85BamfWindow * bamf_window_get_transient (BamfWindow *self)

Subscribers

People subscribed via source and target branches