Merge ~rickwu4444/plainbox-provider-certification-client:add-nested-fw-diagnosis-to-iot-plan into plainbox-provider-certification-client:master

Proposed by Rick Wu
Status: Merged
Approved by: Rick Wu
Approved revision: 30b12fd3a03bbbe0028239e3b292097b7a892cf8
Merged at revision: eadee0ace0cfdeb2299541779dcdce6849d8189d
Proposed branch: ~rickwu4444/plainbox-provider-certification-client:add-nested-fw-diagnosis-to-iot-plan
Merge into: plainbox-provider-certification-client:master
Diff against target: 36 lines (+3/-0)
3 files modified
units/client-cert-iot-ubuntucore-16.pxu (+1/-0)
units/client-cert-iot-ubuntucore-18.pxu (+1/-0)
units/client-cert-iot-ubuntucore-20.pxu (+1/-0)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Kristin Chuang (community) Approve
Vic Liu Approve
Rick Wu Needs Resubmitting
Jonathan Cave Pending
Review via email: mp+396889@code.launchpad.net

Commit message

Add fwts test plan into nested part of "client-cert-iot-ubutucore-*.pxu".

Description of the change

Add fwts test plan into "client-cert-iot-*.pxu". Please refer https://code.launchpad.net/~rickwu4444/plainbox-provider-checkbox/+git/plainbox-provider-checkbox/+merge/396888" for more details.

To post a comment you must log in.
Revision history for this message
Vic Liu (zongminl) wrote :

I found the plan name firmware-ubuntucore a bit ambiguous, I'd like to propose to have:

iot-firmware-automated nested in the cert whitelist plans

review: Needs Fixing
Revision history for this message
Rick Wu (rickwu4444) wrote :

> I found the plan name firmware-ubuntucore a bit ambiguous, I'd like to propose
> to have:
>
> iot-firmware-automated nested in the cert whitelist plans

fixed!

Revision history for this message
Rick Wu (rickwu4444) wrote :

> I found the plan name firmware-ubuntucore a bit ambiguous, I'd like to propose
> to have:
>
> iot-firmware-automated nested in the cert whitelist plans

fixed!
1.add iot-firmware-automated into nested part of whitelist for UC16/18/20.

review: Needs Resubmitting
Revision history for this message
Vic Liu (zongminl) wrote :

LGTM, +1

review: Approve
Revision history for this message
Kristin Chuang (kristinchuang) wrote :

+1

review: Approve
Revision history for this message
Jonathan Cave (jocave) wrote :
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/units/client-cert-iot-ubuntucore-16.pxu b/units/client-cert-iot-ubuntucore-16.pxu
index fc105a4..ce30baf 100644
--- a/units/client-cert-iot-ubuntucore-16.pxu
+++ b/units/client-cert-iot-ubuntucore-16.pxu
@@ -125,6 +125,7 @@ bootstrap_include:
125nested_part:125nested_part:
126 self-automated126 self-automated
127 com.intel.ipdt::ipdt-plan127 com.intel.ipdt::ipdt-plan
128 iot-fwts-automated
128 audio-automated129 audio-automated
129 bluez-automated130 bluez-automated
130 camera-automated131 camera-automated
diff --git a/units/client-cert-iot-ubuntucore-18.pxu b/units/client-cert-iot-ubuntucore-18.pxu
index 0c14773..82f6875 100644
--- a/units/client-cert-iot-ubuntucore-18.pxu
+++ b/units/client-cert-iot-ubuntucore-18.pxu
@@ -125,6 +125,7 @@ bootstrap_include:
125nested_part:125nested_part:
126 self-automated126 self-automated
127 com.intel.ipdt::ipdt-plan127 com.intel.ipdt::ipdt-plan
128 iot-fwts-automated
128 audio-automated129 audio-automated
129 bluez-automated130 bluez-automated
130 camera-automated131 camera-automated
diff --git a/units/client-cert-iot-ubuntucore-20.pxu b/units/client-cert-iot-ubuntucore-20.pxu
index e5b0336..a270dfc 100644
--- a/units/client-cert-iot-ubuntucore-20.pxu
+++ b/units/client-cert-iot-ubuntucore-20.pxu
@@ -127,6 +127,7 @@ nested_part:
127 self-automated127 self-automated
128 ubuntucore-automated128 ubuntucore-automated
129 com.intel.ipdt::ipdt-plan129 com.intel.ipdt::ipdt-plan
130 iot-fwts-automated
130 audio-automated131 audio-automated
131 bluez-automated132 bluez-automated
132 camera-automated133 camera-automated

Subscribers

People subscribed via source and target branches

to all changes: