Merge lp:~ricardokirkner/locolander/merge-request-views into lp:locolander
Proposed by
Ricardo Kirkner
Status: | Merged |
---|---|
Approved by: | Natalia Bidart |
Approved revision: | 27 |
Merged at revision: | 24 |
Proposed branch: | lp:~ricardokirkner/locolander/merge-request-views |
Merge into: | lp:locolander |
Prerequisite: | lp:~ricardokirkner/locolander/celery-tasks |
Diff against target: |
209 lines (+124/-12) 4 files modified
locolander/locolanderweb/templates/locolanderweb/project/detail.html (+24/-9) locolander/locolanderweb/tests/test_views.py (+77/-0) locolander/locolanderweb/urls.py (+2/-0) locolander/locolanderweb/views.py (+21/-3) |
To merge this branch: | bzr merge lp:~ricardokirkner/locolander/merge-request-views |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Natalia Bidart | Approve | ||
Review via email: mp+174625@code.launchpad.net |
Commit message
added view for triggering a merge request run
To post a comment you must log in.
Branch looks great. There is only one blocker, and is in the merge_request_run view: the get_object_or_404 should ensure that the user currently logged is the owner of the project that holds the given merge request (otherwise anyone logged in could visit this url by knowing the MR id).