Merge lp:~renatofilho/ubuntu-docviewer-app/ubunut-app-platform into lp:ubuntu-docviewer-app

Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Pat McGowan
Approved revision: 358
Merged at revision: 356
Proposed branch: lp:~renatofilho/ubuntu-docviewer-app/ubunut-app-platform
Merge into: lp:ubuntu-docviewer-app
Diff against target: 117 lines (+82/-1)
3 files modified
cmake/modules/Click.cmake (+7/-0)
snapcraft.yaml (+70/-0)
src/app/config.h.in (+5/-1)
To merge this branch: bzr merge lp:~renatofilho/ubuntu-docviewer-app/ubunut-app-platform
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Approve
Pat McGowan Approve
Review via email: mp+312913@code.launchpad.net

Commit message

Create snapcract package.

To post a comment you must log in.
357. By Renato Araujo Oliveira Filho

Filter files packed into the snap.

358. By Renato Araujo Oliveira Filho

Avoid build problems if qmake fail to report the correct QML_DIR.

Revision history for this message
Pat McGowan (pat-mcgowan) :
review: Approve
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'cmake/modules/Click.cmake'
--- cmake/modules/Click.cmake 2016-03-10 22:37:32 +0000
+++ cmake/modules/Click.cmake 2016-12-09 15:31:32 +0000
@@ -69,5 +69,12 @@
69 OUTPUT_STRIP_TRAILING_WHITESPACE69 OUTPUT_STRIP_TRAILING_WHITESPACE
70 )70 )
7171
72 if (QT_IMPORTS_DIR STREQUAL "")
73 set(QT_IMPORTS_DIR "${CMAKE_INSTALL_FULL_LIBDIR}/qt5/qml")
74 message(STATUS "QT_IMPORTS_DIR is empty using default one: ${QT_IMPORTS_DIR}")
75 else()
76 message(STATUS "QT_IMPORTS_DIR set to ${QT_IMPORTS_DIR}")
77 endif()
78
72 set(DATA_DIR ${CMAKE_INSTALL_DATADIR}/${APP_NAME})79 set(DATA_DIR ${CMAKE_INSTALL_DATADIR}/${APP_NAME})
73endif(CLICK_MODE)80endif(CLICK_MODE)
7481
=== added directory 'snap'
=== added directory 'snap/ubuntu-app-platform'
=== added file 'snapcraft.yaml'
--- snapcraft.yaml 1970-01-01 00:00:00 +0000
+++ snapcraft.yaml 2016-12-09 15:31:32 +0000
@@ -0,0 +1,70 @@
1name: ubuntu-docviewer-app
2version: 2.1.350
3summary: Document Viewer
4description: Document Viewer application for Ubuntu devices
5confinement: strict
6grade: devel
7
8apps:
9 ubuntu-docviewer-app:
10 command: desktop-launch $SNAP/usr/bin/ubuntu-docviewer-app ---documentsDir=$(HOME=/home/$USER xdg-user-dir DOCUMENTS) -desktop_file_hint=unity8 "$@"
11 plugs:
12 - home
13 - opengl
14 - platform
15 - unity7
16 - unity8
17
18plugs:
19 platform:
20 interface: content
21 content: ubuntu-app-platform1
22 target: ubuntu-app-platform
23 default-provider: ubuntu-app-platform
24
25parts:
26 ubuntu-docviewer-app:
27 plugin: cmake
28 configflags: [-DCMAKE_INSTALL_PREFIX=/usr, -DCLICK_MODE=off]
29 source: .
30 build-packages:
31 - cmake
32 - intltool
33 - libpoppler-qt5-dev
34 - qtbase5-private-dev
35 - qtdeclarative5-private-dev
36 - qtdeclarative5-qtquick2-plugin
37 stage-packages:
38 - qtdeclarative5-poppler1.0
39 - xdg-user-dirs
40 snap:
41 # ubuntu-docviewer-app
42 - usr/bin/ubuntu-docviewer-app
43 - usr/share/applications
44 - usr/share/locale
45 - usr/share/ubuntu-docviewer-app
46
47 # qtdeclarative5-documentviewer-common
48 # qtdeclarative5-documentviewer-libreoffice
49 # qtdeclarative5-documentviewer-pdf
50 - usr/lib/*/qt5/qml/DocumentViewer
51
52 # qtdeclarative5-poppler1.0
53 - usr/lib/*/qt5/qml/org/docviewer
54 - usr/share/doc/qtdeclarative5-poppler1.0/copyright
55
56 # xdg-user-dirs
57 - usr/share/locale/*/LC_MESSAGES/xdg-user-dirs.mo
58 - usr/bin/xdg-user-dir
59 - usr/bin/xdg-user-dirs-update
60 - etc/xdg/user-dirs.conf
61 - etc/xdg/user-dirs.defaults
62 - etc/X11/Xsession.d/60xdg-user-dirs-update
63 - usr/share/doc/xdg-user-dirs/copyright
64 - usr/share/doc/xdg-user-dirs/AUTHORS
65
66 platform:
67 plugin: dump
68 source: snap
69 after: [desktop-ubuntu-app-platform]
70 snap: [ubuntu-app-platform]
071
=== modified file 'src/app/config.h.in'
--- src/app/config.h.in 2015-10-20 11:58:48 +0000
+++ src/app/config.h.in 2016-12-09 15:31:32 +0000
@@ -21,6 +21,8 @@
21#include <QtCore/QDir>21#include <QtCore/QDir>
22#include <QtCore/QString>22#include <QtCore/QString>
2323
24static QString SNAP_ENV = qgetenv("SNAP");
25
24inline bool isClick() {26inline bool isClick() {
25 static bool click = (QCoreApplication::applicationDirPath().contains("click.ubuntu.com"));27 static bool click = (QCoreApplication::applicationDirPath().contains("click.ubuntu.com"));
26 return click;28 return click;
@@ -34,7 +36,9 @@
3436
35inline QString docviewerDirectory()37inline QString docviewerDirectory()
36{38{
37 if (isClick()) {39 if (!SNAP_ENV.isEmpty()) {
40 return SNAP_ENV + QString("@CMAKE_INSTALL_PREFIX@/@DATA_DIR@");
41 } else if (isClick()) {
38 return QString(".");42 return QString(".");
39 } else if (isRunningInstalled()) {43 } else if (isRunningInstalled()) {
40 return QString("@CMAKE_INSTALL_PREFIX@/@DATA_DIR@");44 return QString("@CMAKE_INSTALL_PREFIX@/@DATA_DIR@");

Subscribers

People subscribed via source and target branches