dialer-app

Merge lp:~renatofilho/dialer-app/ubuntu-app-platform into lp:dialer-app

  1. ubuntu-app-platform
  2. Merge into trunk
Proposed by Renato Araujo Oliveira Filho
Status: Merged
Approved by: Tiago Salem Herrmann
Approved revision: 564
Merged at revision: 564
Proposed branch: lp:~renatofilho/dialer-app/ubuntu-app-platform
Merge into: lp:dialer-app
Diff against target: 107 lines (+56/-18)
2 files modified
setup/gui/dialer-app.desktop (+1/-1)
snapcraft.yaml (+55/-17)
To merge this branch: bzr merge lp:~renatofilho/dialer-app/ubuntu-app-platform
Reviewer Review Type Date Requested Status
Tiago Salem Herrmann (community) Approve
system-apps-ci-bot continuous-integration Approve
Review via email: mp+312689@code.launchpad.net

Commit message

Make use of 'ubuntu-app-platform' snap interface.

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

PASSED: Continuous integration, rev:564
https://jenkins.canonical.com/system-apps/job/lp-dialer-app-ci/29/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build/2142
    SUCCESS: https://jenkins.canonical.com/system-apps/job/test-0-autopkgtest/label=phone-armhf,release=vivid+overlay,testname=default/547
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/2145
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1973
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1973/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1973
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1973/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/1973
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/1973/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1973
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1973/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1973
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1973/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/1973
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/1973/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1973
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1973/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1973
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1973/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/1973
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/1973/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-dialer-app-ci/29/rebuild

review: Approve (continuous-integration)
Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

looks good to me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'setup/gui/dialer-app.desktop'
--- setup/gui/dialer-app.desktop 2016-10-11 18:49:19 +0000
+++ setup/gui/dialer-app.desktop 2016-12-07 15:54:57 +0000
@@ -233,7 +233,7 @@
233Keywords[zh_TW]=Phone;Dialer;Dial;Call;Keypad;手機;通話;撥打;233Keywords[zh_TW]=Phone;Dialer;Dial;Call;Keypad;手機;通話;撥打;
234Exec=dialer-app %u234Exec=dialer-app %u
235Terminal=false235Terminal=false
236Icon=/snap/dialer-app/current/usr/share/dialer-app/assets/dialer-app.png236Icon=${SNAP}/usr/share/dialer-app/assets/dialer-app.png
237MimeType=x-scheme-handler/contact;x-scheme-handler/call237MimeType=x-scheme-handler/contact;x-scheme-handler/call
238X-Ubuntu-Touch=true238X-Ubuntu-Touch=true
239X-Ubuntu-StageHint=SideStage239X-Ubuntu-StageHint=SideStage
240240
=== added directory 'snap'
=== added directory 'snap/ubuntu-app-platform'
=== modified file 'snapcraft.yaml'
--- snapcraft.yaml 2016-11-30 15:14:37 +0000
+++ snapcraft.yaml 2016-12-07 15:54:57 +0000
@@ -8,7 +8,14 @@
8apps:8apps:
9 dialer-app:9 dialer-app:
10 command: desktop-launch $SNAP/usr/bin/dialer-app --desktop_file_hint=unity8 "$@"10 command: desktop-launch $SNAP/usr/bin/dialer-app --desktop_file_hint=unity8 "$@"
11 plugs: [unity7, opengl]11 plugs: [opengl, platform, unity7, unity8]
12
13plugs:
14 platform:
15 interface: content
16 content: ubuntu-app-platform1
17 target: ubuntu-app-platform
18 default-provider: ubuntu-app-platform
1219
13parts:20parts:
14 dialer-app:21 dialer-app:
@@ -25,25 +32,56 @@
25 - qtdeclarative5-dev-tools32 - qtdeclarative5-dev-tools
2633
27 stage-packages:34 stage-packages:
28 - qml-module-qt-labs-settings
29 - qml-module-qtsysteminfo
30 - qml-module-ofono
31 - qml-module-ubuntu-components
32 - qtdeclarative5-gsettings1.0
33 - qtdeclarative5-ubuntu-addressbook0.135 - qtdeclarative5-ubuntu-addressbook0.1
34 - qtdeclarative5-ubuntu-content1
35 - qtdeclarative5-ubuntu-history0.136 - qtdeclarative5-ubuntu-history0.1
36 - qtdeclarative5-ubuntu-telephony0.137 - qtdeclarative5-ubuntu-telephony0.1
37 - qtdeclarative5-ubuntu-telephony-phonenumber0.138 - qtdeclarative5-ubuntu-telephony-phonenumber0.1
38 - qtdeclarative5-ubuntu-keyboard-extensions0.1
39 - qtdeclarative5-qtcontacts-plugin
40 - qtubuntu-desktop
41 - suru-icon-theme
42 - mir-graphics-drivers-desktop
4339
44 snap:40 snap:
45 - -usr/lib/python341 # dialer-app
46 - -usr/share/doc42 - usr/share/applications/dialer-app*.desktop
47 - -usr/include 43 - usr/share/url-dispatcher/urls
4844 - usr/share/locale/*/LC_MESSAGES/dialer-app.mo
49 after: [desktop-qt5]45 - usr/share/dialer-app/*.qml
46 - usr/share/dialer-app/LiveCallPage
47 - usr/share/dialer-app/HistoryPage
48 - usr/share/dialer-app/DialerPage
49 - usr/share/dialer-app/ContactsPage
50 - usr/share/dialer-app/ContactViewPage
51 - usr/share/dialer-app/ContactEditorPage
52 - usr/share/dialer-app/Dialogs
53 - usr/share/dialer-app/assets
54 - usr/share/dialer-app/MMI
55 - usr/bin/*dialer-app*
56
57 # qtdeclarative5-ubuntu-addressbook0.1
58 - usr/lib/*/qt5/qml/Ubuntu/Contacts.0.1/
59 - usr/share/doc/qtdeclarative5-ubuntu-contacts0.1/copyright
60 - usr/lib/*/qt5/qml/Ubuntu/AddressBook/
61 - usr/share/doc/qtdeclarative5-ubuntu-addressbook0.1/copyright
62
63 # qtdeclarative5-ubuntu-history0.1
64 - usr/share/doc/qtdeclarative5-ubuntu-history0.1/copyright
65 - usr/lib/*/qt5/qml/Ubuntu/History/libhistory-qml.so
66 - usr/lib/*/qt5/qml/Ubuntu/History/qmldir
67 - usr/lib/*/libhistoryservice.so.*
68 - usr/lib/*/libtelepathy-qt5.so.*
69
70 # qtdeclarative5-ubuntu-telephony0.1
71 - usr/lib/*/qt5/qml/Ubuntu/Telephony/
72 - usr/share/doc/qtdeclarative5-ubuntu-telephony0.1/copyright
73
74 # qtdeclarative5-ubuntu-telephony-phonenumber0.1
75 - usr/share/doc/qtdeclarative5-ubuntu-telephony-phonenumber0.1/copyright
76 - usr/lib/*/qt5/qml/Ubuntu/Telephony/PhoneNumber/PhoneNumberField.qml
77 - usr/lib/*/qt5/qml/Ubuntu/Telephony/PhoneNumber/libtelephonyservice-phonenumber-qml.so
78 - usr/lib/*/qt5/qml/Ubuntu/Telephony/PhoneNumber/PhoneNumber.js
79 - usr/lib/*/qt5/qml/Ubuntu/Telephony/PhoneNumber/PhoneNumberInput.qml
80 - usr/lib/*/qt5/qml/Ubuntu/Telephony/PhoneNumber/qmldir
81 - usr/lib/*/libphonenumber.so.7*
82
83 after: [desktop-ubuntu-app-platform]
84
85 environment:
86 source: snap/
87 plugin: dump

Subscribers

People subscribed via source and target branches