Merge lp:~ralsina/ubuntu-sso-client/find_exes into lp:ubuntu-sso-client
Proposed by
Roberto Alsina
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Roberto Alsina | ||||
Approved revision: | 924 | ||||
Merged at revision: | 925 | ||||
Proposed branch: | lp:~ralsina/ubuntu-sso-client/find_exes | ||||
Merge into: | lp:ubuntu-sso-client | ||||
Diff against target: |
40 lines (+11/-4) 2 files modified
ubuntu_sso/__init__.py (+6/-0) ubuntu_sso/utils/__init__.py (+5/-4) |
||||
To merge this branch: | bzr merge lp:~ralsina/ubuntu-sso-client/find_exes | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Manuel de la Peña (community) | Approve | ||
Natalia Bidart (community) | Approve | ||
Brian Curtin (community) | Approve | ||
Review via email: mp+98108@code.launchpad.net |
Commit message
- Added .exe to the constant for binary names if needed (LP: #958778)
Description of the change
fix paths and spawning on windows
To post a comment you must log in.
We should add tests fit this since we already had problems with get_bin due to the lack of tests. What about patching sys.platform and test the result?
Also, I think I'd a good idea to set the gtk one to none on windows to make the error more clear.