Merge lp:~raj-abhilash1/mailman/bugfix into lp:mailman

Proposed by Abhilash Raj
Status: Merged
Approved by: Barry Warsaw
Approved revision: no longer in the source branch.
Merged at revision: 7323
Proposed branch: lp:~raj-abhilash1/mailman/bugfix
Merge into: lp:mailman
Diff against target: 71 lines (+9/-14)
4 files modified
src/mailman/app/docs/chains.rst (+5/-8)
src/mailman/app/tests/test_subscriptions.py (+1/-1)
src/mailman/chains/hold.py (+1/-1)
src/mailman/templates/en/postauth.txt (+2/-4)
To merge this branch: bzr merge lp:~raj-abhilash1/mailman/bugfix
Reviewer Review Type Date Requested Status
Barry Warsaw Pending
Mailman Coders Pending
Review via email: mp+256418@code.launchpad.net

Description of the change

Updated the templates and reason for held message.

To post a comment you must log in.
lp:~raj-abhilash1/mailman/bugfix updated
7321. By Barry Warsaw

Update versions for 3.0rc1, but don't tag yet.

7322. By Barry Warsaw

Move a doctest to the right directory.

7323. By Barry Warsaw

Clean up some templates; given by raj-abhilash1

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/mailman/app/docs/chains.rst'
--- src/mailman/app/docs/chains.rst 2015-03-26 20:06:23 +0000
+++ src/mailman/app/docs/chains.rst 2015-04-16 14:06:01 +0000
@@ -132,13 +132,10 @@
132 List: test@example.com132 List: test@example.com
133 From: aperson@example.com133 From: aperson@example.com
134 Subject: My first post134 Subject: My first post
135 Reason: XXX135 Reason: N/A
136 <BLANKLINE>136 <BLANKLINE>
137 At your convenience, visit:137 At your convenience, visit your dashboard to approve or deny the
138 <BLANKLINE>138 request.
139 http://lists.example.com/admindb/test@example.com
140 <BLANKLINE>
141 to approve or deny the request.
142 <BLANKLINE>139 <BLANKLINE>
143 ...140 ...
144 Content-Type: message/rfc822141 Content-Type: message/rfc822
@@ -189,7 +186,7 @@
189 <BLANKLINE>186 <BLANKLINE>
190 The reason it is being held:187 The reason it is being held:
191 <BLANKLINE>188 <BLANKLINE>
192 XXX189 N/A
193 <BLANKLINE>190 <BLANKLINE>
194 Either the message will get posted to the list, or you will receive191 Either the message will get posted to the list, or you will receive
195 notification of the moderator's decision. If you would like to cancel192 notification of the moderator's decision. If you would like to cancel
196193
=== modified file 'src/mailman/app/tests/test_subscriptions.py'
--- src/mailman/app/tests/test_subscriptions.py 2015-04-16 02:51:39 +0000
+++ src/mailman/app/tests/test_subscriptions.py 2015-04-16 14:06:01 +0000
@@ -420,7 +420,7 @@
420 list(workflow)420 list(workflow)
421 line = mark.readline()421 line = mark.readline()
422 self.assertEqual(422 self.assertEqual(
423 line[29:-1],423 line[28:-1],
424 'test@example.com: held subscription request from anne@example.com'424 'test@example.com: held subscription request from anne@example.com'
425 )425 )
426426
427427
=== modified file 'src/mailman/chains/hold.py'
--- src/mailman/chains/hold.py 2015-01-05 01:22:39 +0000
+++ src/mailman/chains/hold.py 2015-04-16 14:06:01 +0000
@@ -158,7 +158,7 @@
158 listname = mlist.fqdn_listname,158 listname = mlist.fqdn_listname,
159 subject = original_subject,159 subject = original_subject,
160 sender = msg.sender,160 sender = msg.sender,
161 reason = 'XXX', #reason,161 reason = 'N/A', #reason,
162 confirmurl = '{0}/{1}'.format(mlist.script_url('confirm'), token),162 confirmurl = '{0}/{1}'.format(mlist.script_url('confirm'), token),
163 admindb_url = mlist.script_url('admindb'),163 admindb_url = mlist.script_url('admindb'),
164 )164 )
165165
=== modified file 'src/mailman/templates/en/postauth.txt'
--- src/mailman/templates/en/postauth.txt 2008-09-29 06:44:19 +0000
+++ src/mailman/templates/en/postauth.txt 2015-04-16 14:06:01 +0000
@@ -6,8 +6,6 @@
6 Subject: $subject6 Subject: $subject
7 Reason: $reason7 Reason: $reason
88
9At your convenience, visit:9At your convenience, visit your dashboard to approve or deny the
10request.
1011
11 $admindb_url
12
13to approve or deny the request.