Merge lp:~psusi/ubuntu/natty/indicator-session/sleep into lp:ubuntu/natty/indicator-session

Proposed by Phillip Susi
Status: Rejected
Rejected by: James Westby
Proposed branch: lp:~psusi/ubuntu/natty/indicator-session/sleep
Merge into: lp:ubuntu/natty/indicator-session
Diff against target: 61 lines (+9/-14)
3 files modified
debian/changelog (+7/-0)
debian/control (+1/-1)
src/session-service.c (+1/-13)
To merge this branch: bzr merge lp:~psusi/ubuntu/natty/indicator-session/sleep
Reviewer Review Type Date Requested Status
Chris Halse Rogers Approve
Ubuntu branches Pending
Review via email: mp+54094@code.launchpad.net

Description of the change

See linked bug report and related branches that all need merged together.

To post a comment you must log in.
Revision history for this message
Chris Halse Rogers (raof) wrote :

Looks good to me, but I can't upload.

review: Approve

Unmerged revisions

45. By Phillip Susi

Remove screen saver start and lock functions, as this is
the job of gnome-power-manager (LP: #578542).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2011-03-10 16:10:19 +0000
+++ debian/changelog 2011-03-19 03:39:27 +0000
@@ -1,3 +1,10 @@
1indicator-session (0.2.15-0ubuntu2) natty; urgency=low
2
3 * Remove screen saver start and lock functions, as this is
4 the job of gnome-power-manager (LP: #578542).
5
6 -- Phillip Susi <psusi@cfl.rr.com> Mon, 07 Mar 2011 19:14:47 -0500
7
1indicator-session (0.2.15-0ubuntu1) natty; urgency=low8indicator-session (0.2.15-0ubuntu1) natty; urgency=low
29
3 * New upstream release.10 * New upstream release.
411
=== modified file 'debian/control'
--- debian/control 2011-02-17 13:31:40 +0000
+++ debian/control 2011-03-19 03:39:27 +0000
@@ -20,7 +20,7 @@
2020
21Package: indicator-session21Package: indicator-session
22Architecture: any22Architecture: any
23Depends: ${shlibs:Depends}, ${misc:Depends}, upower23Depends: ${shlibs:Depends}, ${misc:Depends}, upower (>= 0.9.8-3ubuntu1)
24Recommends: indicator-applet (>= 0.2) | indicator-renderer24Recommends: indicator-applet (>= 0.2) | indicator-renderer
25Suggests: gdm25Suggests: gdm
26Conflicts: gdm (<= 2.27.4-0ubuntu9), indicator-sus26Conflicts: gdm (<= 2.27.4-0ubuntu9), indicator-sus
2727
=== modified file 'src/session-service.c'
--- src/session-service.c 2011-03-10 16:10:19 +0000
+++ src/session-service.c 2011-03-19 03:39:27 +0000
@@ -176,15 +176,6 @@
176 return;176 return;
177}177}
178178
179/* A return from the command to sleep the system. Make sure
180 that we unthrottle the screensaver. */
181static void
182sleep_response (DBusGProxy * proxy, DBusGProxyCall * call, gpointer data)
183{
184 screensaver_unthrottle();
185 return;
186}
187
188/* Let's put this machine to sleep, with some info on how179/* Let's put this machine to sleep, with some info on how
189 it should sleep. */180 it should sleep. */
190static void181static void
@@ -196,12 +187,9 @@
196 g_warning("Can not %s as no upower proxy", type);187 g_warning("Can not %s as no upower proxy", type);
197 }188 }
198189
199 screensaver_throttle(type);
200 lock_if_possible();
201
202 dbus_g_proxy_begin_call(up_main_proxy,190 dbus_g_proxy_begin_call(up_main_proxy,
203 type,191 type,
204 sleep_response,192 NULL,
205 NULL,193 NULL,
206 NULL,194 NULL,
207 G_TYPE_INVALID);195 G_TYPE_INVALID);

Subscribers

People subscribed via source and target branches

to all changes: